From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AECAC43464 for ; Mon, 21 Sep 2020 06:36:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7FD5D20BED for ; Mon, 21 Sep 2020 06:36:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FD5D20BED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93434900018; Mon, 21 Sep 2020 02:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E4D06B009B; Mon, 21 Sep 2020 02:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F98A900018; Mon, 21 Sep 2020 02:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 640646B0099 for ; Mon, 21 Sep 2020 02:36:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 22ECF1EE6 for ; Mon, 21 Sep 2020 06:36:33 +0000 (UTC) X-FDA: 77286109866.24.grade19_1c039ab27143 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 074491A4A0 for ; Mon, 21 Sep 2020 06:36:33 +0000 (UTC) X-HE-Tag: grade19_1c039ab27143 X-Filterd-Recvd-Size: 4283 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Sep 2020 06:36:32 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B25CE68AFE; Mon, 21 Sep 2020 08:36:28 +0200 (CEST) Date: Mon, 21 Sep 2020 08:36:28 +0200 From: Christoph Hellwig To: Mauro Carvalho Chehab , Thomas Bogendoerfer , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Tomasz Figa , Matt Porter , iommu@lists.linux-foundation.org Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-parisc@vger.kernel.org, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, Stefan Richter , netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: a saner API for allocating DMA addressable pages v3 Message-ID: <20200921063628.GB18349@lst.de> References: <20200915155122.1768241-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915155122.1768241-1-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Any comments? Thomas: this should be identical to the git tree I gave you for mips testing, and you add your tested-by (and reviewd-by tags where applicable)? Helge: for parisc this should effectively be the same as the first version, but I've dropped the tested-by tags due to the reshuffle, and chance you could retest it? On Tue, Sep 15, 2020 at 05:51:04PM +0200, Christoph Hellwig wrote: > Hi all, > > this series replaced the DMA_ATTR_NON_CONSISTENT flag to dma_alloc_attrs > with a separate new dma_alloc_pages API, which is available on all > platforms. In addition to cleaning up the convoluted code path, this > ensures that other drivers that have asked for better support for > non-coherent DMA to pages with incurring bounce buffering over can finally > be properly supported. > > As a follow up I plan to move the implementation of the > DMA_ATTR_NO_KERNEL_MAPPING flag over to this framework as well, given > that is also is a fundamentally non coherent allocation. The replacement > for that flag would then return a struct page, as it is allowed to > actually return pages without a kernel mapping as the name suggested > (although most of the time they will actually have a kernel mapping..) > > In addition to the conversions of the existing non-coherent DMA users, > I've also added a patch to convert the firewire ohci driver to use > the new dma_alloc_pages API. > > The first patch is queued up for 5.9 in the media tree, but included here > for completeness. > > > A git tree is available here: > > git://git.infradead.org/users/hch/misc.git dma_alloc_pages > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma_alloc_pages > > > Changes since v2: > - fix up the patch reshuffle which wasn't quite correct > - fix up a few commit messages > > Changes since v1: > - rebased on the latests dma-mapping tree, which merged many of the > cleanups > - fix an argument passing typo in 53c700, caught by sparse > - rename a few macro arguments in 53c700 > - pass the right device to the DMA API in the lib82596 drivers > - fix memory ownershiptransfers in sgiseeq > - better document what a page in the direct kernel mapping means > - split into dma_alloc_pages that returns a struct page and is in the > direct mapping vs dma_alloc_noncoherent that can be vmapped > - conver the firewire ohci driver to dma_alloc_pages > > Diffstat: > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text---