From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE99C43468 for ; Mon, 21 Sep 2020 15:30:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C9472085B for ; Mon, 21 Sep 2020 15:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pmxl16sH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C9472085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA967900088; Mon, 21 Sep 2020 11:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5741900083; Mon, 21 Sep 2020 11:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A469C900088; Mon, 21 Sep 2020 11:30:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 63125900083 for ; Mon, 21 Sep 2020 11:30:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 04D9533CD for ; Mon, 21 Sep 2020 15:30:12 +0000 (UTC) X-FDA: 77287454664.01.slip10_140fee627146 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id CE6961004933F for ; Mon, 21 Sep 2020 15:30:11 +0000 (UTC) X-HE-Tag: slip10_140fee627146 X-Filterd-Recvd-Size: 4267 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Sep 2020 15:30:11 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id b22so14459802lfs.13 for ; Mon, 21 Sep 2020 08:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DkqOMgrTl7zIBI5g2+ZD+/MpKpCbOEtbJ09u4yXxMck=; b=Pmxl16sH/7qJpClO1+ChSFj3ZaW7eiGRz+uQkC83Tk31YG2iFaRDELBOwCj9eDRiA/ oV7CHQReHSIjp44bi6inuRO2dizjW+c8mQDYO2c/ISQp38KgABD1aqt0WTnpoaDwenjp UJh3XidzufYBq5wxWRKykvDzLAKrUxhaOq4hGzcC4vqGIqPqMjid0tZOupGcf7NjBwXW rbRpdMF0IMMxh8CMWRU4Jn5lAFZ3zhXFzJQS4EkHQ8p+KJfrrkdoHNmrZx66Qr0nksv3 8xMPqimuwky48DKMsXgVxtHuTNVVPBgFKm0VjaAiHGXPwhFKAqkWrMMlmZJhCgrGv4gH pK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DkqOMgrTl7zIBI5g2+ZD+/MpKpCbOEtbJ09u4yXxMck=; b=tVqxuG/9xxkdKLGm7VxbBmOb+st8RSuwEXuDC15QXLPznH+k9blPGvhrEiHo0aoFX5 3zZV9+aWOc1O0OSn3uaSasgPBhN8jvsQgxgqH/JB3Q66e3p6Gdkvr8asmC7E5n4LkUYn 63MTz7TXSoZVLxQrF4K/2Nxy/plFMXTNQlNBn29BiDEarSiLrbReolqXbTLgGnaNkLmH fZHTY4ldJcVv6E86zdTQiFuLQ+XZ1CDfgkGfdXRtgHcpQigcVp1DiASAQvTRWMSMJEab zGivFyjFVkSCo8//E4me1BVAw4UgF9QmXkpwdzWwlf+hjC6Y66QuPEZhb1/aqe7lteGt 4JXQ== X-Gm-Message-State: AOAM533EBR0XY7Cw+WALiAB9F4IU4Ym/eV6AzLLV3tCTG9X0smo12fGY sPHiuAaO3Rhn38RfQI3B65LxvAw1zpq+L5a+ X-Google-Smtp-Source: ABdhPJy1eIBGFeYwuQMOuq/7S2ynwqFcHOs7jFpgskY8/IISq6FthNW2ufuKc1hYYw9eWWw3473bPg== X-Received: by 2002:a19:e041:: with SMTP id g1mr144347lfj.337.1600702209515; Mon, 21 Sep 2020 08:30:09 -0700 (PDT) Received: from localhost.localdomain (188.147.112.12.nat.umts.dynamic.t-mobile.pl. [188.147.112.12]) by smtp.gmail.com with ESMTPSA id b27sm2631635lfq.133.2020.09.21.08.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 08:30:09 -0700 (PDT) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [PATCH] mm/page_poison.c: replace bool variable with static key Date: Mon, 21 Sep 2020 17:29:31 +0200 Message-Id: <20200921152931.938-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Variable 'want_page_poisoning' is a switch deciding if page poisoning should be enabled. This patch changes it to be static key. Signed-off-by: Mateusz Nosek --- mm/page_poison.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/mm/page_poison.c b/mm/page_poison.c index 34b9181ee5d1..ae0482cded87 100644 --- a/mm/page_poison.c +++ b/mm/page_poison.c @@ -8,13 +8,23 @@ #include #include =20 -static bool want_page_poisoning __read_mostly; +static DEFINE_STATIC_KEY_FALSE_RO(want_page_poisoning); =20 static int __init early_page_poison_param(char *buf) { - if (!buf) - return -EINVAL; - return strtobool(buf, &want_page_poisoning); + int ret; + bool tmp; + + ret =3D strtobool(buf, &tmp); + if (ret) + return ret; + + if (tmp) + static_branch_enable(&want_page_poisoning); + else + static_branch_disable(&want_page_poisoning); + + return 0; } early_param("page_poison", early_page_poison_param); =20 @@ -31,7 +41,7 @@ bool page_poisoning_enabled(void) * Page poisoning is debug page alloc for some arches. If * either of those options are enabled, enable poisoning. */ - return (want_page_poisoning || + return (static_branch_unlikely(&want_page_poisoning) || (!IS_ENABLED(CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC) && debug_pagealloc_enabled())); } --=20 2.20.1