From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D989FC4363C for ; Mon, 21 Sep 2020 21:18:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5021323A5C for ; Mon, 21 Sep 2020 21:18:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JixBZlB2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5021323A5C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE479900007; Mon, 21 Sep 2020 17:18:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBBB58E0001; Mon, 21 Sep 2020 17:18:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD253900007; Mon, 21 Sep 2020 17:18:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id AEB828E0001 for ; Mon, 21 Sep 2020 17:18:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 78984180AD802 for ; Mon, 21 Sep 2020 21:18:15 +0000 (UTC) X-FDA: 77288331750.17.beef40_5a00e1727148 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 47B2D180D0181 for ; Mon, 21 Sep 2020 21:18:15 +0000 (UTC) X-HE-Tag: beef40_5a00e1727148 X-Filterd-Recvd-Size: 8682 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Sep 2020 21:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600723094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Czb1qrslD9yUv/Haw0aWfjN1eWciuskZPTm0uxjzTrw=; b=JixBZlB2O1WzPxLKJRG19qP0AEQeU0umoG3xYxbb3jBHzwfPN0SwRorb2PWdl+WALtDw+U ee8tcZfThMn2jhBwMXhr+Vm0jS/ZEZfhkLdJGB8hFYPJBzvHN7FrCzghc0WUtZx7hnELr4 0Yj/q1Fdvy4GqRQDnxqWqzfOaZlCHv8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-fMU5ww50PpCcz8CWGEBnTQ-1; Mon, 21 Sep 2020 17:18:03 -0400 X-MC-Unique: fMU5ww50PpCcz8CWGEBnTQ-1 Received: by mail-qk1-f200.google.com with SMTP id y17so12029883qkf.15 for ; Mon, 21 Sep 2020 14:18:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Czb1qrslD9yUv/Haw0aWfjN1eWciuskZPTm0uxjzTrw=; b=eAuB3KmYUF5mo3b5jF5sFDyaYutB3+y1GN/k2iV5oJ71QJHGPXFUIy9DySP2XxHJHm 4WMRiXLmsxl09e91+RLWUjVafgmmZkiclUTnMsccm3avm6j4HGrohCkxCPJ1H9YdUYyI 0MLlljn7RHrw8v7Ni34bDbvST8VP1E3oRIqVHVNXOXfLOxfsvhUmDgBgE61HbqRwRqXq rvG0u4M0mwpkdIIYwmzcjM+cTvLSXklZgWRePr2p907m8xBbSwa+l4x2ctNJkeVlr/WZ buTh7Ygea2xcKEkKehnXa98VmgRiDmkTBL7f8Yxw4m7aL2SlgJXSgtMv+TUTK0i6R3nF AbMQ== X-Gm-Message-State: AOAM530Ob1sW9o/K/tM0XMWK5P/eMPiAnYixknAkzVS1mKO+aOcm5pkU wDrX227tSeT/Ft9TxoLuoe3APl7hznTak7z3AcXMKfRE2N4hBO9mOGXcRekNOmh+d/zzXiwJmO2 esnM9YSmv4fE= X-Received: by 2002:a37:a443:: with SMTP id n64mr1704893qke.288.1600723078260; Mon, 21 Sep 2020 14:17:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB9u04zjtBvkhW4vamCUqdPL1Um+sdXYj+ylUAkuu7tDAINW75kR2xK9/WpDWyhJDGrwYhGQ== X-Received: by 2002:a37:a443:: with SMTP id n64mr1704410qke.288.1600723071183; Mon, 21 Sep 2020 14:17:51 -0700 (PDT) Received: from xz-x1.redhat.com (bras-vprn-toroon474qw-lp130-11-70-53-122-15.dsl.bell.ca. [70.53.122.15]) by smtp.gmail.com with ESMTPSA id h68sm10225108qkf.30.2020.09.21.14.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 14:17:50 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Jason Gunthorpe , Andrew Morton , Jan Kara , Michal Hocko , Kirill Tkhai , Kirill Shutemov , Hugh Dickins , Peter Xu , Christoph Hellwig , Andrea Arcangeli , John Hubbard , Oleg Nesterov , Leon Romanovsky , Linus Torvalds , Jann Horn Subject: [PATCH 2/5] mm/fork: Pass new vma pointer into copy_page_range() Date: Mon, 21 Sep 2020 17:17:41 -0400 Message-Id: <20200921211744.24758-3-peterx@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200921211744.24758-1-peterx@redhat.com> References: <20200921211744.24758-1-peterx@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This prepares for the future work to trigger early cow on pinned pages du= ring fork(). No functional change intended. Signed-off-by: Peter Xu --- include/linux/mm.h | 2 +- kernel/fork.c | 2 +- mm/memory.c | 14 +++++++++----- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ca6e6a81576b..bf1ac54be55e 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1644,7 +1644,7 @@ struct mmu_notifier_range; void free_pgd_range(struct mmu_gather *tlb, unsigned long addr, unsigned long end, unsigned long floor, unsigned long ceiling); int copy_page_range(struct mm_struct *dst, struct mm_struct *src, - struct vm_area_struct *vma); + struct vm_area_struct *vma, struct vm_area_struct *new); int follow_pte_pmd(struct mm_struct *mm, unsigned long address, struct mmu_notifier_range *range, pte_t **ptepp, pmd_t **pmdpp, spinlock_t **ptlp); diff --git a/kernel/fork.c b/kernel/fork.c index 7237d418e7b5..843807ade6dd 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -589,7 +589,7 @@ static __latent_entropy int dup_mmap(struct mm_struct= *mm, =20 mm->map_count++; if (!(tmp->vm_flags & VM_WIPEONFORK)) - retval =3D copy_page_range(mm, oldmm, mpnt); + retval =3D copy_page_range(mm, oldmm, mpnt, tmp); =20 if (tmp->vm_ops && tmp->vm_ops->open) tmp->vm_ops->open(tmp); diff --git a/mm/memory.c b/mm/memory.c index 469af373ae76..7525147908c4 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -814,6 +814,7 @@ copy_one_pte(struct mm_struct *dst_mm, struct mm_stru= ct *src_mm, =20 static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *sr= c_mm, pmd_t *dst_pmd, pmd_t *src_pmd, struct vm_area_struct *vma, + struct vm_area_struct *new, unsigned long addr, unsigned long end) { pte_t *orig_src_pte, *orig_dst_pte; @@ -877,6 +878,7 @@ static int copy_pte_range(struct mm_struct *dst_mm, s= truct mm_struct *src_mm, =20 static inline int copy_pmd_range(struct mm_struct *dst_mm, struct mm_str= uct *src_mm, pud_t *dst_pud, pud_t *src_pud, struct vm_area_struct *vma, + struct vm_area_struct *new, unsigned long addr, unsigned long end) { pmd_t *src_pmd, *dst_pmd; @@ -903,7 +905,7 @@ static inline int copy_pmd_range(struct mm_struct *ds= t_mm, struct mm_struct *src if (pmd_none_or_clear_bad(src_pmd)) continue; if (copy_pte_range(dst_mm, src_mm, dst_pmd, src_pmd, - vma, addr, next)) + vma, new, addr, next)) return -ENOMEM; } while (dst_pmd++, src_pmd++, addr =3D next, addr !=3D end); return 0; @@ -911,6 +913,7 @@ static inline int copy_pmd_range(struct mm_struct *ds= t_mm, struct mm_struct *src =20 static inline int copy_pud_range(struct mm_struct *dst_mm, struct mm_str= uct *src_mm, p4d_t *dst_p4d, p4d_t *src_p4d, struct vm_area_struct *vma, + struct vm_area_struct *new, unsigned long addr, unsigned long end) { pud_t *src_pud, *dst_pud; @@ -937,7 +940,7 @@ static inline int copy_pud_range(struct mm_struct *ds= t_mm, struct mm_struct *src if (pud_none_or_clear_bad(src_pud)) continue; if (copy_pmd_range(dst_mm, src_mm, dst_pud, src_pud, - vma, addr, next)) + vma, new, addr, next)) return -ENOMEM; } while (dst_pud++, src_pud++, addr =3D next, addr !=3D end); return 0; @@ -945,6 +948,7 @@ static inline int copy_pud_range(struct mm_struct *ds= t_mm, struct mm_struct *src =20 static inline int copy_p4d_range(struct mm_struct *dst_mm, struct mm_str= uct *src_mm, pgd_t *dst_pgd, pgd_t *src_pgd, struct vm_area_struct *vma, + struct vm_area_struct *new, unsigned long addr, unsigned long end) { p4d_t *src_p4d, *dst_p4d; @@ -959,14 +963,14 @@ static inline int copy_p4d_range(struct mm_struct *= dst_mm, struct mm_struct *src if (p4d_none_or_clear_bad(src_p4d)) continue; if (copy_pud_range(dst_mm, src_mm, dst_p4d, src_p4d, - vma, addr, next)) + vma, new, addr, next)) return -ENOMEM; } while (dst_p4d++, src_p4d++, addr =3D next, addr !=3D end); return 0; } =20 int copy_page_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, - struct vm_area_struct *vma) + struct vm_area_struct *vma, struct vm_area_struct *new) { pgd_t *src_pgd, *dst_pgd; unsigned long next; @@ -1021,7 +1025,7 @@ int copy_page_range(struct mm_struct *dst_mm, struc= t mm_struct *src_mm, if (pgd_none_or_clear_bad(src_pgd)) continue; if (unlikely(copy_p4d_range(dst_mm, src_mm, dst_pgd, src_pgd, - vma, addr, next))) { + vma, new, addr, next))) { ret =3D -ENOMEM; break; } --=20 2.26.2