From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC74C4727C for ; Tue, 22 Sep 2020 14:37:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2FDF523A1B for ; Tue, 22 Sep 2020 14:37:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FDF523A1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 73837900090; Tue, 22 Sep 2020 10:37:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68D5F900094; Tue, 22 Sep 2020 10:37:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E80900090; Tue, 22 Sep 2020 10:37:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 33D42900086 for ; Tue, 22 Sep 2020 10:37:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EA2B88249980 for ; Tue, 22 Sep 2020 14:37:21 +0000 (UTC) X-FDA: 77290950282.02.list83_5e017772714e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id CA32A100B4D47 for ; Tue, 22 Sep 2020 14:37:21 +0000 (UTC) X-HE-Tag: list83_5e017772714e X-Filterd-Recvd-Size: 3063 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Sep 2020 14:37:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 008C9ACC2; Tue, 22 Sep 2020 14:37:57 +0000 (UTC) From: Vlastimil Babka To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Vlastimil Babka Subject: [PATCH 3/9] mm, page_alloc: remove setup_pageset() Date: Tue, 22 Sep 2020 16:37:06 +0200 Message-Id: <20200922143712.12048-4-vbabka@suse.cz> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200922143712.12048-1-vbabka@suse.cz> References: <20200922143712.12048-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We initialize boot-time pagesets with setup_pageset(), which sets high an= d batch values that effectively disable pcplists. We can remove this wrapper if we just set these values for all pagesets i= n pageset_init(). Non-boot pagesets then subsequently update them to the pr= oper values. No functional change. Signed-off-by: Vlastimil Babka --- mm/page_alloc.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 26069c8d1b19..76c2b4578723 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5823,7 +5823,7 @@ static void build_zonelists(pg_data_t *pgdat) * not check if the processor is online before following the pageset poi= nter. * Other parts of the kernel may not check if the zone is available. */ -static void setup_pageset(struct per_cpu_pageset *p); +static void pageset_init(struct per_cpu_pageset *p); static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); =20 @@ -5891,7 +5891,7 @@ build_all_zonelists_init(void) * (a chicken-egg dilemma). */ for_each_possible_cpu(cpu) - setup_pageset(&per_cpu(boot_pageset, cpu)); + pageset_init(&per_cpu(boot_pageset, cpu)); =20 mminit_verify_zonelist(); cpuset_init_current_mems_allowed(); @@ -6210,12 +6210,15 @@ static void pageset_init(struct per_cpu_pageset *= p) pcp =3D &p->pcp; for (migratetype =3D 0; migratetype < MIGRATE_PCPTYPES; migratetype++) INIT_LIST_HEAD(&pcp->lists[migratetype]); -} =20 -static void setup_pageset(struct per_cpu_pageset *p) -{ - pageset_init(p); - pageset_update(&p->pcp, 0, 1); + /* + * Set batch and high values safe for a boot pageset. A true percpu + * pageset's initialization will update them subsequently. Here we don'= t + * need to be as careful as pageset_update() as nobody can access the + * pageset yet. + */ + pcp->high =3D 0; + pcp->batch =3D 1; } =20 /* --=20 2.28.0