From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81261C4727E for ; Thu, 24 Sep 2020 19:29:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15CFC22208 for ; Thu, 24 Sep 2020 19:29:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15CFC22208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63A656B005C; Thu, 24 Sep 2020 15:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60F5B6B005D; Thu, 24 Sep 2020 15:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526376B0062; Thu, 24 Sep 2020 15:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 3C2106B005C for ; Thu, 24 Sep 2020 15:29:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 040B252C1 for ; Thu, 24 Sep 2020 19:29:01 +0000 (UTC) X-FDA: 77298942882.15.cakes35_530299d27161 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id CDF031814B0C1 for ; Thu, 24 Sep 2020 19:29:00 +0000 (UTC) X-HE-Tag: cakes35_530299d27161 X-Filterd-Recvd-Size: 3954 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 19:28:58 +0000 (UTC) IronPort-SDR: E8mvRlASMK8SsUJM3L5SQW6ZIiu2a7tH90opzRAScSWRR8rnmqwZHXol4+NnbGn9giIlzqyUq3 LSmihc+C1T8Q== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="161393947" X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="161393947" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 12:28:55 -0700 IronPort-SDR: /alJgHdzpr6m/E8oOg3GkCjvnAxXz1fHnWK/iozNJcTJB92wSlAKm5CGN1sqhOgLh0TVuK+3Qa 1UHE7REBvP9Q== X-IronPort-AV: E=Sophos;i="5.77,299,1596524400"; d="scan'208";a="455484772" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 12:28:55 -0700 Date: Thu, 24 Sep 2020 12:28:54 -0700 From: Sean Christopherson To: Haitao Huang Cc: Jarkko Sakkinen , Andy Lutomirski , X86 ML , linux-sgx@vger.kernel.org, LKML , Linux-MM , Andrew Morton , Matthew Wilcox , Jethro Beekman , Darren Kenny , Andy Shevchenko , asapek@google.com, Borislav Petkov , "Xing, Cedric" , chenalexchen@google.com, Conrad Parker , cyhanish@google.com, Dave Hansen , "Huang, Haitao" , Josh Triplett , "Huang, Kai" , "Svahn, Kai" , Keith Moyer , Christian Ludloff , Neil Horman , Nathaniel McCallum , Patrick Uiterwijk , David Rientjes , Thomas Gleixner , yaozhangx@google.com Subject: Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect() Message-ID: <20200924192853.GA18826@linux.intel.com> References: <20200918235337.GA21189@sjchrist-ice> <20200921124946.GF6038@linux.intel.com> <20200921165758.GA24156@linux.intel.com> <20200921210736.GB58176@linux.intel.com> <20200921211849.GA25403@linux.intel.com> <20200922052957.GA97272@linux.intel.com> <20200922053515.GA97687@linux.intel.com> <20200922164301.GB30874@linux.intel.com> <20200923135056.GD5160@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 24, 2020 at 02:11:37PM -0500, Haitao Huang wrote: > On Wed, 23 Sep 2020 08:50:56 -0500, Jarkko Sakkinen > wrote: > >I'll categorically deny noexec in the next patch set version. > > > >/Jarkko > > There are use cases supported currently in which enclave binary is received > via IPC/RPC and held in buffers before EADD. Denying noexec altogether would > break those, right? No. noexec only applies to file-backed VMAs, what you're describing is loading an enclave from an anon VMA, which will still have VM_MAYEXEC. I believe you're thinking of SELinux's EXECMEM, which is required to execute from anonymous memory, and which we talked about (more than once) applying to SGX enclaves. That being said, I still dislike the idea of requiring VM_MAYEXEC, it's a hack that doesn't really buy us much, if anything.