From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF39C4741F for ; Tue, 29 Sep 2020 14:55:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6629C20773 for ; Tue, 29 Sep 2020 14:55:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="eImcL4LJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6629C20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F67D6B0071; Tue, 29 Sep 2020 10:55:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CE946B0072; Tue, 29 Sep 2020 10:55:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70B006B0073; Tue, 29 Sep 2020 10:55:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 5A7CF6B0071 for ; Tue, 29 Sep 2020 10:55:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1055B181AE868 for ; Tue, 29 Sep 2020 14:55:22 +0000 (UTC) X-FDA: 77316397284.01.word27_1304d172718b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id D2416100473C0 for ; Tue, 29 Sep 2020 14:55:21 +0000 (UTC) X-HE-Tag: word27_1304d172718b X-Filterd-Recvd-Size: 5964 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Sep 2020 14:55:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601391320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9HO/9n9icXpRGOaw7exoBm2LCNPxUE5Eyu2A1eeiOQ=; b=eImcL4LJ9+xPI1gvbuUL+dTyMwpTQgk1m3wpiD3Z3l/ASvh9JfX446dwJLUw7fPD9WjOMV YdhUyHqbxQz+6f3/ii9xZoOD0iydN0+7HY5kpxqyXxTjVUT7VNN/njalb4Wz4HXPwHS3m6 Zwq0pIZKZ0bkUf8CtGJ+aNOxURKikJU= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 02F66AC12; Tue, 29 Sep 2020 14:55:20 +0000 (UTC) Date: Tue, 29 Sep 2020 16:55:19 +0200 From: Michal Hocko To: Vijay Balakrishna Cc: Andrew Morton , "Kirill A. Shutemov" , Oleg Nesterov , Song Liu , Andrea Arcangeli , Pavel Tatashin , Allen Pais , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [v4] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged Message-ID: <20200929145519.GF2277@dhcp22.suse.cz> References: <1601338047-18558-1-git-send-email-vijayb@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601338047-18558-1-git-send-email-vijayb@linux.microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 28-09-20 17:07:27, Vijay Balakrishna wrote: > When memory is hotplug added or removed the min_free_kbytes must be s@must@should@ > recalculated based on what is expected by khugepaged. Currently > after hotplug, min_free_kbytes will be set to a lower default and higher > default set when THP enabled is lost. This change restores min_free_kbytes > as expected for THP consumers. > > Fixes: f000565adb77 ("thp: set recommended min free kbytes") > > Signed-off-by: Vijay Balakrishna > Cc: stable@vger.kernel.org > Reviewed-by: Pavel Tatashin > Acked-by: Michal Hocko > --- > v3 -> v4 > - made changes to move khugepaged_min_free_kbytes_update into > init_per_zone_wmark_min and rested changes > [suggestion from Michal Hocko] > > [v2 1/2] > - removed symptoms references from changelog > > [v2 2/2] > - addressed following issues Michal Hocko raised: > . nr_free_buffer_pages can oveflow in int on very large machines > . min_free_kbytes can decrease the size theoretically > > v1 -> v2 > -------- > - addressed issue Kirill A. Shutemov raised: > . changes would override min_free_kbytes set by user > > include/linux/khugepaged.h | 5 +++++ > mm/khugepaged.c | 13 +++++++++++-- > mm/page_alloc.c | 3 +++ > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/include/linux/khugepaged.h b/include/linux/khugepaged.h > index bc45ea1efbf7..c941b7377321 100644 > --- a/include/linux/khugepaged.h > +++ b/include/linux/khugepaged.h > @@ -15,6 +15,7 @@ extern int __khugepaged_enter(struct mm_struct *mm); > extern void __khugepaged_exit(struct mm_struct *mm); > extern int khugepaged_enter_vma_merge(struct vm_area_struct *vma, > unsigned long vm_flags); > +extern void khugepaged_min_free_kbytes_update(void); > #ifdef CONFIG_SHMEM > extern void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr); > #else > @@ -85,6 +86,10 @@ static inline void collapse_pte_mapped_thp(struct mm_struct *mm, > unsigned long addr) > { > } > + > +static inline void khugepaged_min_free_kbytes_update(void) > +{ > +} > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > #endif /* _LINUX_KHUGEPAGED_H */ > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index cfa0dba5fd3b..4f7107476a6f 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -56,6 +56,9 @@ enum scan_result { > #define CREATE_TRACE_POINTS > #include > > +static struct task_struct *khugepaged_thread __read_mostly; > +static DEFINE_MUTEX(khugepaged_mutex); > + > /* default scan 8*512 pte (or vmas) every 30 second */ > static unsigned int khugepaged_pages_to_scan __read_mostly; > static unsigned int khugepaged_pages_collapsed; > @@ -2292,8 +2295,6 @@ static void set_recommended_min_free_kbytes(void) > > int start_stop_khugepaged(void) > { > - static struct task_struct *khugepaged_thread __read_mostly; > - static DEFINE_MUTEX(khugepaged_mutex); > int err = 0; > > mutex_lock(&khugepaged_mutex); > @@ -2320,3 +2321,11 @@ int start_stop_khugepaged(void) > mutex_unlock(&khugepaged_mutex); > return err; > } > + > +void khugepaged_min_free_kbytes_update(void) > +{ > + mutex_lock(&khugepaged_mutex); > + if (khugepaged_enabled() && khugepaged_thread) > + set_recommended_min_free_kbytes(); > + mutex_unlock(&khugepaged_mutex); > +} > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index fab5e97dc9ca..ac25d3526fa5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -69,6 +69,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -7891,6 +7892,8 @@ int __meminit init_per_zone_wmark_min(void) > setup_min_slab_ratio(); > #endif > > + khugepaged_min_free_kbytes_update(); > + > return 0; > } > postcore_initcall(init_per_zone_wmark_min) > -- > 2.28.0 -- Michal Hocko SUSE Labs