From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E56FC47420 for ; Wed, 30 Sep 2020 10:33:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D7652076E for ; Wed, 30 Sep 2020 10:33:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D7652076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD9756B005C; Wed, 30 Sep 2020 06:33:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAFA86B005D; Wed, 30 Sep 2020 06:33:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EC3E6B0068; Wed, 30 Sep 2020 06:33:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 88B476B005C for ; Wed, 30 Sep 2020 06:33:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4B015363F for ; Wed, 30 Sep 2020 10:33:41 +0000 (UTC) X-FDA: 77319366642.24.print49_130094827192 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 2CA431A4A5 for ; Wed, 30 Sep 2020 10:33:41 +0000 (UTC) X-HE-Tag: print49_130094827192 X-Filterd-Recvd-Size: 1637 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 10:33:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1B94EAF27; Wed, 30 Sep 2020 10:33:39 +0000 (UTC) Date: Wed, 30 Sep 2020 12:33:36 +0200 From: Oscar Salvador To: Anshuman Khandual Cc: linux-mm@kvack.org, Daniel Jordan , Zi Yan , John Hubbard , Mike Kravetz , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration Message-ID: <20200930103331.GA30472@linux> References: <1601445649-22163-1-git-send-email-anshuman.khandual@arm.com> <20200930074639.GA26786@linux> <5f8a390c-8280-9b04-bf4a-3454d5984bf1@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f8a390c-8280-9b04-bf4a-3454d5984bf1@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 03:32:10PM +0530, Anshuman Khandual wrote: > Right, it would be simple. But as Mike had mentioned before PageHuge() > check is more expensive than PageTransHuge(). This proposal just tries > not to call PageHuge() unless the page first clears PageTransHuge(), > saving some potential CPU cycles on normal pages. Ah, I remember now. I missed that, sorry. -- Oscar Salvador SUSE L3