From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F748C4727C for ; Wed, 30 Sep 2020 20:36:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A87CC2064E for ; Wed, 30 Sep 2020 20:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pRjjZ074" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A87CC2064E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6F608E0001; Wed, 30 Sep 2020 16:36:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1FF96B0068; Wed, 30 Sep 2020 16:36:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98F78E0001; Wed, 30 Sep 2020 16:36:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id B173F6B0062 for ; Wed, 30 Sep 2020 16:36:17 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6A68A181AE867 for ; Wed, 30 Sep 2020 20:36:17 +0000 (UTC) X-FDA: 77320885194.15.print08_5400e6c27195 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 457961814C712 for ; Wed, 30 Sep 2020 20:36:17 +0000 (UTC) X-HE-Tag: print08_5400e6c27195 X-Filterd-Recvd-Size: 7739 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 20:36:16 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id z17so3760700lfi.12 for ; Wed, 30 Sep 2020 13:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FvVU3w+wKNrGmSSrpD1fuhyo1DsqW+d7YWGQnG2VgIU=; b=pRjjZ074ybsg1YxE4qraHShSd8LDsjv4ETsECqDd/VFayRIW+63mGICoDt8RqUP4I4 2akClrjBlw2sGnVdOdYd7l3hG/Vq8ya+Nnhuh9jsOOQLLEssR2yk6Zi3ueP/Jqf0l1LM eh3boBbCXJJNuaTppIteQb4dCgNnKvDw55HdlkO0ZpeyOuwx/HEccdYmXWpylriTf0o2 R3u7qsuODlXbwWGnr87mJP47ab/qGHaEeWG4D8nwKI00sokjiJtLtVdMFuZpxVsriXuw CuVSqAhPF6wTWYec85Yke1Usd5oU0E1fXGF0ZrHJlpNWhWApCb+pkB4cDAupEOx+0s52 caHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FvVU3w+wKNrGmSSrpD1fuhyo1DsqW+d7YWGQnG2VgIU=; b=pERZksPHoGVoikaRZHdAhCigYob/gC6TGo4tX1pocGwtO7JgtvVlGUPC7zYe0qRHFi mEjUnlBrLNnaIYiNkfQDJnWfujLm9OxYejMeOd4Lf4LiLDI9uoPIz3Keyr4rKj8KgcPc kai7RAm6Oco/3R5rRwm99done0di0OyfOTQKk0I5NqVFGdQfneGFknGRlB9eln3XkBij 75P0oUwiQolenDqfjAjUBwSaZ0Ap4b0A2CLP0XSuI/astCUSjxj95UBHip23vsUG2doj XFSrDi07+u4BhvXx+G3Rf+gT6qMgPVdwd/+bwxmqQLvkO6e51nGW7FyyC9CAMgLZpaLh F/rw== X-Gm-Message-State: AOAM5323C1SbVO2aPbbRbD+7YKQn4QGLxzhqjoeCzRZBrEx9EQdWEllV 7Y/TnnMTRvF729JY6dDGzqg= X-Google-Smtp-Source: ABdhPJyO/xuwQDU03jhAhiML4MgJebyzTY0GvISjG9zVY9mj+iTPJS7F1V10Ii/DUNNERq3e5z9gcw== X-Received: by 2002:a05:6512:3692:: with SMTP id d18mr1331274lfs.62.1601498175210; Wed, 30 Sep 2020 13:36:15 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id b197sm304632lfd.251.2020.09.30.13.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 13:36:14 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 30 Sep 2020 22:36:12 +0200 To: Michal Hocko Cc: Uladzislau Rezki , Mel Gorman , "Paul E. McKenney" , LKML , RCU , linux-mm@kvack.org, Andrew Morton , Peter Zijlstra , Vlastimil Babka , Thomas Gleixner , "Theodore Y . Ts'o" , Joel Fernandes , Sebastian Andrzej Siewior , Oleksiy Avramchenko , Mel Gorman Subject: Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func. Message-ID: <20200930203612.GA22035@pc636> References: <20200924081614.GA14819@pc636> <20200925080503.GC3389@dhcp22.suse.cz> <20200925153129.GB25350@pc636> <20200925154741.GI3389@dhcp22.suse.cz> <20200929162514.GA8768@pc636> <20200930092732.GP2277@dhcp22.suse.cz> <20200930123535.GB18005@pc636> <20200930124413.GU2277@dhcp22.suse.cz> <20200930133954.GA19235@pc636> <20200930164600.GW2277@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930164600.GW2277@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 06:46:00PM +0200, Michal Hocko wrote: > On Wed 30-09-20 15:39:54, Uladzislau Rezki wrote: > > On Wed, Sep 30, 2020 at 02:44:13PM +0200, Michal Hocko wrote: > > > On Wed 30-09-20 14:35:35, Uladzislau Rezki wrote: > > > > On Wed, Sep 30, 2020 at 11:27:32AM +0200, Michal Hocko wrote: > > > > > On Tue 29-09-20 18:25:14, Uladzislau Rezki wrote: > > > > > > > > I look at it in scope of GFP_ATOMIC/GFP_NOWAIT issues, i.e. inability > > > > > > > > to provide a memory service for contexts which are not allowed to > > > > > > > > sleep, RCU is part of them. Both flags used to provide such ability > > > > > > > > before but not anymore. > > > > > > > > > > > > > > > > Do you agree with it? > > > > > > > > > > > > > > Yes this sucks. But this is something that we likely really want to live > > > > > > > with. We have to explicitly _document_ that really atomic contexts in RT > > > > > > > cannot use the allocator. From the past discussions we've had this is > > > > > > > likely the most reasonable way forward because we do not really want to > > > > > > > encourage anybody to do something like that and there should be ways > > > > > > > around that. The same is btw. true also for !RT. The allocator is not > > > > > > > NMI safe and while we should be able to make it compatible I am not > > > > > > > convinced we really want to. > > > > > > > > > > > > > > Would something like this be helpful wrt documentation? > > > > > > > > > > > > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > > > > > > index 67a0774e080b..9fcd47606493 100644 > > > > > > > --- a/include/linux/gfp.h > > > > > > > +++ b/include/linux/gfp.h > > > > > > > @@ -238,7 +238,9 @@ struct vm_area_struct; > > > > > > > * %__GFP_FOO flags as necessary. > > > > > > > * > > > > > > > * %GFP_ATOMIC users can not sleep and need the allocation to succeed. A lower > > > > > > > - * watermark is applied to allow access to "atomic reserves" > > > > > > > + * watermark is applied to allow access to "atomic reserves". > > > > > > > + * The current implementation doesn't support NMI and other non-preemptive context > > > > > > > + * (e.g. raw_spin_lock). > > > > > > > * > > > > > > > * %GFP_KERNEL is typical for kernel-internal allocations. The caller requires > > > > > > > * %ZONE_NORMAL or a lower zone for direct access but can direct reclaim. > > > > > > > > > > > > > To me it is clear. But also above conflicting statement: > > > > > > > > > > > > > > > > > > %GFP_ATOMIC users can not sleep and need the allocation to succeed. A %lower > > > > > > > > > > > > > > > > > > should be rephrased, IMHO. > > > > > > > > > > Any suggestions? Or more specifics about which part is conflicting? It > > > > > tries to say that there is a higher demand to succeed even though the > > > > > context cannot sleep to take active measures to achieve that. So the > > > > > only way to achieve that is to break the watermakrs to a certain degree > > > > > which is making them more "higher class" than other allocations. > > > > > > > > > Michal, i had only one concern about it. It says that %GFP_ATOMIC users > > > > can not sleep, i.e. callers know that they are in atomic, thus no any > > > > sleeping, but the chose they make will force them to sleep. > > > > > > I am not sure I follow you here. Do you mean they will be forced to > > > sleep with PREEMPT_RT? > > > > > Exactly :) > > We can make that more specific once RT patchset is merged. As of now > this is not the thing in the Linus tree. I believe there will be more to > clarify about atomic contexts in the RT tree as it means something else > than people are used to think. > Fair enough. Currently we have only the Kconfig CONFIG_PREEMPT_RT symbol, so RT patches are still not in place. -- Vlad Rezki