From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A0BC47423 for ; Thu, 1 Oct 2020 17:45:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75CCD2054F for ; Thu, 1 Oct 2020 17:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HIqQhj0r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75CCD2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF520900019; Thu, 1 Oct 2020 13:45:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA455900003; Thu, 1 Oct 2020 13:45:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4734900019; Thu, 1 Oct 2020 13:45:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 74962900003 for ; Thu, 1 Oct 2020 13:45:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 101511DFA for ; Thu, 1 Oct 2020 17:45:18 +0000 (UTC) X-FDA: 77324083116.20.push70_540086a2719d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id D683C180C07A3 for ; Thu, 1 Oct 2020 17:45:17 +0000 (UTC) X-HE-Tag: push70_540086a2719d X-Filterd-Recvd-Size: 6930 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 17:45:17 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z1so6803691wrt.3 for ; Thu, 01 Oct 2020 10:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SdTU4gQ/GSNzMeDvk9Yhuq+mmVJCx1AqWYuvXYSPp6E=; b=HIqQhj0r1gGYdw02V45ahQXi4QGLOB4PIPtcQRi7iRuA7fmkkN9svVGzTK1Y/rlcjA SPIdxpDNZQuuL+0BJjIgAMejpVODY6Fx47ubXD+cidu8YMiaR+omZqX6YldhiwKGbxob mUGHU6oINAGWbbhYD+l/Cz9z8q1AGWDxsX84tyYAIO3wg8Ta3LJRUVIDkLWRBvfeAjv9 pa0y/97UbN4botFE7fHjk/2zLdDTWd2IXAHCRUJRCjcWFwoMZ4ZysMnbM8bHX3nXQe71 cHpil8dlEuf+yZHPo+9tkopf+DMn/w3sVWswIXj5N+QXOjgK+wRQLErcpeMBMfU1Jq2N UPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SdTU4gQ/GSNzMeDvk9Yhuq+mmVJCx1AqWYuvXYSPp6E=; b=ZHoWsi/BaRqgnpbtbwSRBj6gJNsjYywSzjcyB9XxjjnU9dW8E5gwl2cbDb4Fyboqlk 3Bdgn3L5VhnwJEhKAAR9JtqLEIe4zsxGUdyp9S3Nap68u5CYeOCFUxvFtNfVY1smUIGK 0CKcnD8etaA59saWhAngij9LEvx8XTUURKRqwzye/RsOfTZ7aJOh/Zy8/84ca2KfvQNv RxmeoyadrpITqF1AXhQFDs0pFqb2QJZkcA+TupQ+OsB2z8JGPIONDCUUwJO31FBu/WwM tsUEHgWZ2d4hyBI54hXRJI0iNXXwTWs70jSPpBGpzdmxvNdP3AwiunQSjyeo8TKTtDPf /ubA== X-Gm-Message-State: AOAM532Jd+Xto4qmfqhLqDoymWaSHqlI7amLpSM8A4z/0ngBN4JKOVql DYidzI2oMl7uj9ZVBoyBoz/TdA== X-Google-Smtp-Source: ABdhPJzJmTheU5+EobBQTbg33EPACuLKFxTHdCBuGuc/t70VfL3q1/rNXGQEbgHtlTe5XcWvcpQN+g== X-Received: by 2002:adf:f6c8:: with SMTP id y8mr10971682wrp.217.1601574315975; Thu, 01 Oct 2020 10:45:15 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id w7sm9695314wrm.92.2020.10.01.10.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:45:15 -0700 (PDT) Date: Thu, 1 Oct 2020 19:45:09 +0200 From: elver@google.com To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/39] kasan: rename addr_has_shadow to addr_has_metadata Message-ID: <20201001174509.GL4162920@elver.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.5 (2020-06-23) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 25, 2020 at 12:50AM +0200, 'Andrey Konovalov' via kasan-dev wrote: > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver > --- > Change-Id: I03706fe34b38da7860c39aa0968e00001a7d1873 > --- > mm/kasan/kasan.h | 2 +- > mm/kasan/report.c | 6 +++--- > mm/kasan/report_generic.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 8dfacc0f73ea..0bf669fad345 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -146,7 +146,7 @@ static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_shadow(const void *addr) > +static inline bool addr_has_metadata(const void *addr) > { > return (addr >= kasan_shadow_to_mem((void *)KASAN_SHADOW_START)); > } > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 91b869673148..145b966f8f4d 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -329,7 +329,7 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > untagged_addr = reset_tag(tagged_addr); > > info.access_addr = tagged_addr; > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > info.first_bad_addr = find_first_bad_addr(tagged_addr, size); > else > info.first_bad_addr = untagged_addr; > @@ -340,11 +340,11 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > start_report(&flags); > > print_error_description(&info); > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > print_tags(get_tag(tagged_addr), info.first_bad_addr); > pr_err("\n"); > > - if (addr_has_shadow(untagged_addr)) { > + if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_addr)); > pr_err("\n"); > print_shadow_for_address(info.first_bad_addr); > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 42b2b5791733..ff067071cd28 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -117,7 +117,7 @@ const char *get_bug_type(struct kasan_access_info *info) > if (info->access_addr + info->access_size < info->access_addr) > return "out-of-bounds"; > > - if (addr_has_shadow(info->access_addr)) > + if (addr_has_metadata(info->access_addr)) > return get_shadow_bug_type(info); > return get_wild_bug_type(info); > } > -- > 2.28.0.681.g6f77f65b4e-goog > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/fd0103571c825317241bfdc43ef19766fd370e4f.1600987622.git.andreyknvl%40google.com.