From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9D3C4727E for ; Thu, 1 Oct 2020 17:46:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C23F20759 for ; Thu, 1 Oct 2020 17:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T3AeyqU7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C23F20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E62E090001A; Thu, 1 Oct 2020 13:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13E3900003; Thu, 1 Oct 2020 13:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D28FD90001A; Thu, 1 Oct 2020 13:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id A7A2C900003 for ; Thu, 1 Oct 2020 13:46:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3353D181AE863 for ; Thu, 1 Oct 2020 17:46:02 +0000 (UTC) X-FDA: 77324084964.20.watch12_3e0c9312719d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 1FCCC180C07A3 for ; Thu, 1 Oct 2020 17:46:02 +0000 (UTC) X-HE-Tag: watch12_3e0c9312719d X-Filterd-Recvd-Size: 5456 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 17:46:01 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z1so6805957wrt.3 for ; Thu, 01 Oct 2020 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4X89ICg6LS0dHFVQkSUqAoV+hQlz/eq43PpADvUh29Q=; b=T3AeyqU7xkY2nJbeE9ox+8W8WTr+v/MvS0TOtz0WBwvoAfbOn3b23v+aC6OV5Z9qeC X9jf8YhWtYireUwIaP6Fo5z0IP4R2VZWBAW0KGnfdqLiYw5dD4q20u6LJntLwPO2d/+7 XOXsMz6pqvfVRKFW17eyZZ4IpPEEgwVUI6iij7/zGPUm00u50UVij6kacWy/cS1P2Phz rHFKDa+ee27rxnrBM0CO9BgU+GZU+w3h5lGnJ8u1soUKKpvBU9BBm4J5pAonhtShRNbr JJ5ZWCy5oIeD1G28gPNx1qthN/D5OWxATs4qG7nCLWNEhVAirocoPYkaxNjxv5BhzUHi +91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4X89ICg6LS0dHFVQkSUqAoV+hQlz/eq43PpADvUh29Q=; b=hvIbUvkAKmAdcrnpKrF3V1Mh5EJ5tZiddgIwDIaaX6PIEweqJCgeXTLb1EZ3ONaKbJ dLSOxxpec8ENGiisH/C8jtggCm7OhtjNo8tq6bUsnacmk+VfdXX6u5/87BoqyP9iooW9 ZR68gH/yamk1pq3pTV88hYEC4Mu7J3oCpGUMlZ+8NFIutTIKEvMbGVJIkxesKHyxHNE7 Mo66EyY8jCW3+XIuAjVekNlX0/7GMvwZjpt4cWd/35g5BuYNnyLPMJwtq+2NQe7x1dFY KN/jIQG5HgP8pO/ktXoxMwxXCUVs3PdfXS+70ppEV+piM2TIKLYsS0w7bL3USQywZZHM +cXA== X-Gm-Message-State: AOAM5323Vt4+vhNIiXPvOIDMe9dYtM3x50IfzeLXTJoDgkN6rLjtMAwz dZ3N3tujpGpgOst2uyYSCmkX+A== X-Google-Smtp-Source: ABdhPJwgVoEbDG6cvTnMMQikPDpiTvYKZ5GZ/vqyc675l6eTSpho1m29kdZjBfyxcUZWkPeR+KBgFw== X-Received: by 2002:a5d:634e:: with SMTP id b14mr9870455wrw.190.1601574360526; Thu, 01 Oct 2020 10:46:00 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id k6sm888277wmf.30.2020.10.01.10.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:45:59 -0700 (PDT) Date: Thu, 1 Oct 2020 19:45:54 +0200 From: elver@google.com To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 17/39] kasan: rename print_shadow_for_address to print_memory_metadata Message-ID: <20201001174554.GM4162920@elver.google.com> References: <8580d4945df57614053084eee8f318edb64712d3.1600987622.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8580d4945df57614053084eee8f318edb64712d3.1600987622.git.andreyknvl@google.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000721, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 25, 2020 at 12:50AM +0200, Andrey Konovalov wrote: > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver > --- > Change-Id: I18397dddbed6bc6d365ddcaf063a83948e1150a5 > --- > mm/kasan/report.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 145b966f8f4d..9e4d539d62f4 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -250,7 +250,7 @@ static int shadow_pointer_offset(const void *row, const void *shadow) > (shadow - row) / SHADOW_BYTES_PER_BLOCK + 1; > } > > -static void print_shadow_for_address(const void *addr) > +static void print_memory_metadata(const void *addr) > { > int i; > const void *shadow = kasan_mem_to_shadow(addr); > @@ -311,7 +311,7 @@ void kasan_report_invalid_free(void *object, unsigned long ip) > pr_err("\n"); > print_address_description(object, tag); > pr_err("\n"); > - print_shadow_for_address(object); > + print_memory_metadata(object); > end_report(&flags); > } > > @@ -347,7 +347,7 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_addr)); > pr_err("\n"); > - print_shadow_for_address(info.first_bad_addr); > + print_memory_metadata(info.first_bad_addr); > } else { > dump_stack(); > } > -- > 2.28.0.681.g6f77f65b4e-goog >