From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5826FC4727E for ; Sat, 3 Oct 2020 05:23:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D090A206C3 for ; Sat, 3 Oct 2020 05:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lLlekOam" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D090A206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7950A900003; Sat, 3 Oct 2020 01:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76BFE6B0068; Sat, 3 Oct 2020 01:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68231900003; Sat, 3 Oct 2020 01:23:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 3B4346B0062 for ; Sat, 3 Oct 2020 01:23:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C19613634 for ; Sat, 3 Oct 2020 05:23:25 +0000 (UTC) X-FDA: 77329471170.22.chin61_5f02c29271aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id A580718038E60 for ; Sat, 3 Oct 2020 05:23:25 +0000 (UTC) X-HE-Tag: chin61_5f02c29271aa X-Filterd-Recvd-Size: 4247 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 3 Oct 2020 05:23:25 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id lw21so611993ejb.6 for ; Fri, 02 Oct 2020 22:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=1SGTXRb4W2GeXcOMkx7sItuBro8o/9vcs+gJu2aYrQY=; b=lLlekOam2VLJeeTUJ2KuRAGO50dUm7Rz8jwPJLC5yRWmFYzkbJzCBOzMTmZRPOh2BR YLB0m46SIPmfOkFbh4BkyB0LXGkNiOn5cDT7ABlu+4cHoML7iy8Ep5+RhFg5gRZW00nr yB30hQsdreZEoZtMdyUCnRX+7k5WUtOLCAcOW5gpm4f+QXqWBk8kAO5K0bOddhDkwNVa xjfIb21EoPtH8eRfG3UWS2gma2iEz9+qSLrE3ZDKTu/UiPL78/Ym3bpFIIhCdf/6sweo /Lc3nZG+XTZTBN/wjWz4Ut97bqOMWxs8PFWAIkwOLEFQRtONc25Rv3A6Dz4I43bZKcYf e6rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=1SGTXRb4W2GeXcOMkx7sItuBro8o/9vcs+gJu2aYrQY=; b=bAKL4sPL0CXW4bGJ5H5ByeNml9W4BWed4enwmp4e1jS9woGaDXKcOQ+XNFH781j6iN win+piTHTXj1DfylkcinP4RcmeCGiWpWXWWKxUgApqQ0zh9ISd3+BNMdbwzozr5CjytQ BF4KC6K6qmAaiecZEhawH7ppyFpaXtPVDCmhCuuaV/Rf7cxqtyFP6jGg9fL3phS4qBtB KPYtQ+3In8uPAe2GrhIfa0N5Up/WkkDGsQb35bIcM9l6PaordsOSFyWdb8xtMnc2puzM vN/KHwOsyvHvowZOij+uFDUQ5Suk7Nr97Gwhuapfw97FVOjyVxGlVFY7p67pDsnq88fx zr7w== X-Gm-Message-State: AOAM533lRXRds8neJkj3PKxg1Kiq71W5k8EkFhx7MvYJAyH/RDtbpHiQ rETxtGY+Z57d3EbM3ARCvY4= X-Google-Smtp-Source: ABdhPJxowrN3K2sPjrvpFL3w8CSuHI/73K0kbu/D5IsDEAplNIgE5/klO/jifujj9Nledm6aGPIQdg== X-Received: by 2002:a17:906:3ad0:: with SMTP id z16mr5577080ejd.193.1601702604035; Fri, 02 Oct 2020 22:23:24 -0700 (PDT) Received: from localhost.localdomain ([2a02:2450:10d2:194d:dc80:74e3:612d:b241]) by smtp.gmail.com with ESMTPSA id q3sm3059309edt.1.2020.10.02.22.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 22:23:23 -0700 (PDT) From: SeongJae Park To: John Hubbard Cc: Andrew Morton , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Ralph Campbell Subject: Re: [PATCH] selftests/vm: 10x speedup for hmm-tests Date: Sat, 3 Oct 2020 07:23:09 +0200 Message-Id: <20201003052309.30013-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201003011721.44238-1-jhubbard@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000160, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2 Oct 2020 18:17:21 -0700 John Hubbard wrote: > This patch reduces the running time for hmm-tests from about 10+ > seconds, to just under 1.0 second, for an approximately 10x speedup. > That brings it in line with most of the other tests in selftests/vm, > which mostly run in < 1 sec. > > This is done with a one-line change that simply reduces the number of > iterations of several tests, from 256, to 10. Could this result in reduced test capacity? If so, how about making the number easily tweakable? Thanks, SeongJae Park > Thanks to Ralph Campbell for suggesting changing NTIMES as a way to get the > speedup. > > Suggested-by: Ralph Campbell > Signed-off-by: John Hubbard > --- > > This is based on mmotm. > > tools/testing/selftests/vm/hmm-tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c > index 6b79723d7dc6..5d1ac691b9f4 100644 > --- a/tools/testing/selftests/vm/hmm-tests.c > +++ b/tools/testing/selftests/vm/hmm-tests.c > @@ -49,7 +49,7 @@ struct hmm_buffer { > #define TWOMEG (1 << 21) > #define HMM_BUFFER_SIZE (1024 << 12) > #define HMM_PATH_MAX 64 > -#define NTIMES 256 > +#define NTIMES 10 > > #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) > > -- > 2.28.0