From: Michal Hocko <email@example.com>
To: Anshuman Khandual <firstname.lastname@example.org>
Cc: email@example.com, Daniel Jordan <firstname.lastname@example.org>,
Zi Yan <email@example.com>, John Hubbard <firstname.lastname@example.org>,
Mike Kravetz <email@example.com>,
Oscar Salvador <firstname.lastname@example.org>,
Andrew Morton <email@example.com>,
Subject: Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration
Date: Mon, 5 Oct 2020 08:05:42 +0200 [thread overview]
Message-ID: <20201005060542.GM4555@dhcp22.suse.cz> (raw)
On Mon 05-10-20 07:59:12, Anshuman Khandual wrote:
> On 10/02/2020 05:34 PM, Michal Hocko wrote:
> > On Wed 30-09-20 11:30:49, Anshuman Khandual wrote:
> >> Add following new vmstat events which will track HugeTLB page migration.
> >> 1. HUGETLB_MIGRATION_SUCCESS
> >> 2. HUGETLB_MIGRATION_FAILURE
> >> It follows the existing semantics to accommodate HugeTLB subpages in total
> >> page migration statistics. While here, this updates current trace event
> >> 'mm_migrate_pages' to accommodate now available HugeTLB based statistics.
> > What is the actual usecase? And how do you deal with the complexity
> > introduced by many different hugetlb page sizes. Really, what is the
> > point to having such a detailed view on hugetlb migration?
> It helps differentiate various page migration events i.e normal, THP and
> HugeTLB and gives us more reliable and accurate measurement. Current stats
> as per PGMIGRATE_SUCCESS and PGMIGRATE_FAIL are misleading, as they contain
> both normal and HugeTLB pages as single entities, which is not accurate.
Yes this is true. But why does it really matter? Do you have a specific
> After this change, PGMIGRATE_SUCCESS and PGMIGRATE_FAIL will contain page
> migration statistics in terms of normal pages irrespective of whether any
> previous migrations until that point involved normal pages, THP or HugeTLB
> (any size) pages. At the least, this fixes existing misleading stats with
> PGMIGRATE_SUCCESS and PGMIGRATE_FAIL.
> Besides, it helps us understand HugeTLB migrations in more detail. Even
> though HugeTLB can be of various sizes on a given platform, these new
> stats HUGETLB_MIGRATION_SUCCESS and HUGETLB_MIGRATION_FAILURE give enough
> overall insight into HugeTLB migration events.
While true this all is way too vague to add yet another imprecise
next prev parent reply other threads:[~2020-10-05 6:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:00 [RFC V2] mm/vmstat: Add events for HugeTLB migration Anshuman Khandual
2020-09-30 7:46 ` Oscar Salvador
2020-09-30 10:02 ` Anshuman Khandual
2020-09-30 10:33 ` Oscar Salvador
2020-10-01 22:16 ` Mike Kravetz
2020-10-02 12:04 ` Michal Hocko
2020-10-05 2:29 ` Anshuman Khandual
2020-10-05 6:05 ` Michal Hocko [this message]
2020-10-06 2:56 ` Anshuman Khandual
2020-10-06 7:54 ` Michal Hocko
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).