From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E4AC4727F for ; Mon, 5 Oct 2020 11:43:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1509520774 for ; Mon, 5 Oct 2020 11:43:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1509520774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D0796B0062; Mon, 5 Oct 2020 07:43:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 680CF6B0068; Mon, 5 Oct 2020 07:43:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547036B006C; Mon, 5 Oct 2020 07:43:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 2513A6B0062 for ; Mon, 5 Oct 2020 07:43:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A282D3630 for ; Mon, 5 Oct 2020 11:43:03 +0000 (UTC) X-FDA: 77337685446.24.hour70_1a16a2e271bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 7F5341A4A0 for ; Mon, 5 Oct 2020 11:43:03 +0000 (UTC) X-HE-Tag: hour70_1a16a2e271bd X-Filterd-Recvd-Size: 3859 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 11:43:02 +0000 (UTC) IronPort-SDR: 0acREfC8uzPCInvFZwQcx7RHwKD4fVijuGqAr7fs9QD3oDX+Q5jgLjJNN6cgxzApR1PRjK4KZh 06NTDFfcsJhA== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="151009336" X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="151009336" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 04:43:01 -0700 IronPort-SDR: VDNSVHaXebCyecFKJNH0q24ztWK1mpo2jx7buzjkD5BF/lc4fl1TSxSDAr3xtwP9EQqSTOBx0J bJnnJgEFkMWg== X-IronPort-AV: E=Sophos;i="5.77,338,1596524400"; d="scan'208";a="459464201" Received: from bclindho-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.32.27]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2020 04:42:52 -0700 Date: Mon, 5 Oct 2020 14:42:50 +0300 From: Jarkko Sakkinen To: Christoph Hellwig Cc: Greg KH , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Haitao Huang , Chunyang Hui , Jordan Hand , Nathaniel McCallum , Seth Moore , Darren Kenny , Sean Christopherson , Suresh Siddha , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver Message-ID: <20201005114250.GB181338@linux.intel.com> References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com> <20201003045059.665934-12-jarkko.sakkinen@linux.intel.com> <20201003143925.GB800720@kroah.com> <20201005084554.GA3403@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005084554.GA3403@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 05, 2020 at 09:45:54AM +0100, Christoph Hellwig wrote: > On Sat, Oct 03, 2020 at 04:39:25PM +0200, Greg KH wrote: > > > @@ -0,0 +1,173 @@ > > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > > > You use gpl-only header files in this file, so how in the world can it > > be bsd-3 licensed? > > > > Please get your legal department to agree with this, after you explain > > to them how you are mixing gpl2-only code in with this file. > > > > > +// Copyright(c) 2016-18 Intel Corporation. > > > > Dates are hard to get right :( > > As is comment formatting apparently. Don't use // comments for anything > but the SPDX header, please. I'll bring some context to this. When I moved into using SPDX, I took the example from places where I saw also the copyright using "//". That's the reason for the choice. I.e. $ git grep "// Copyright" | wc -l 2123 I don't care, which one to use, just wondering is it done in the wrong way in all these sites? /Jarkko