From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D36C4363D for ; Wed, 7 Oct 2020 09:52:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C0E32076C for ; Wed, 7 Oct 2020 09:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="VOO4Zd2O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C0E32076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D57966B0068; Wed, 7 Oct 2020 05:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D07246B006C; Wed, 7 Oct 2020 05:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCF378E0001; Wed, 7 Oct 2020 05:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 8FF9D6B0068 for ; Wed, 7 Oct 2020 05:52:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 187018249980 for ; Wed, 7 Oct 2020 09:52:31 +0000 (UTC) X-FDA: 77344664502.06.hill76_53169a2271ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id EB6C010180E04 for ; Wed, 7 Oct 2020 09:52:30 +0000 (UTC) X-HE-Tag: hill76_53169a2271ce X-Filterd-Recvd-Size: 2259 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 09:52:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602064349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9YEdyVZwCu3c28PJPIbBnmYut5XP2GLOBi1ecqX5OY=; b=VOO4Zd2OEcuuBxsAEhNXy3HuHnlW1KHS0EM09c25Ld3WP+Avp6xVS5wRejt2pM080TRg1h cLqfKxBecA2ENqliIXeqcsVhktSBxKv53lJasl1gyfhDpsjolxYoikzSzUvttgLxIfLhGb yHO4OUGhR92XtYkT/GNl9++IhBuz9ZI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E192AED9; Wed, 7 Oct 2020 09:52:29 +0000 (UTC) Date: Wed, 7 Oct 2020 11:52:25 +0200 From: Michal Hocko To: Dave Hansen Cc: linux-kernel@vger.kernel.org, npiggin@gmail.com, akpm@linux-foundation.org, willy@infradead.org, yang.shi@linux.alibaba.com, linux-mm@kvack.org Subject: Re: [RFC][PATCH 00/12] mm: tweak page cache migration Message-ID: <20201007095225.GH29020@dhcp22.suse.cz> References: <20201006205103.268F74A9@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201006205103.268F74A9@viggo.jf.intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am I the only one missing patch 1-5? lore.k.o doesn't seem to link them under this message id either. On Tue 06-10-20 13:51:03, Dave Hansen wrote: > First of all, I think this little slice of code is a bit > under-documented. Perhaps this will help clarify things. > > I'm pretty confident the page_count() check in the first > patch is right, which is why I removed it outright. The > xas_load() check is a bit murkier, so I just left a > warning in for it. > > Cc: Nicholas Piggin > Cc: Andrew Morton > Cc: Matthew Wilcox (Oracle) > Cc: Yang Shi > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org -- Michal Hocko SUSE Labs