From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7028BC4363D for ; Wed, 7 Oct 2020 14:41:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE022212CC for ; Wed, 7 Oct 2020 14:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE022212CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD1C56B006E; Wed, 7 Oct 2020 10:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C812E6B0070; Wed, 7 Oct 2020 10:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70498E0001; Wed, 7 Oct 2020 10:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 8AAAA6B006E for ; Wed, 7 Oct 2020 10:41:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2F2511EE6 for ; Wed, 7 Oct 2020 14:41:33 +0000 (UTC) X-FDA: 77345392866.14.hen26_0b037fb271d0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 0126218229835 for ; Wed, 7 Oct 2020 14:41:32 +0000 (UTC) X-HE-Tag: hen26_0b037fb271d0 X-Filterd-Recvd-Size: 3232 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 7 Oct 2020 14:41:32 +0000 (UTC) Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 097EfEdZ005736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Oct 2020 10:41:15 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 3E8A6420107; Wed, 7 Oct 2020 10:41:14 -0400 (EDT) Date: Wed, 7 Oct 2020 10:41:14 -0400 From: "Theodore Y. Ts'o" To: Dan Williams Cc: Ralph Campbell , Linux MM , linux-xfs , linux-fsdevel , linux-nvdimm , Linux Kernel Mailing List , linux-ext4 , Matthew Wilcox , Jan Kara , Alexander Viro , Christoph Hellwig , Andreas Dilger , "Darrick J. Wong" , Andrew Morton Subject: Re: [PATCH] ext4/xfs: add page refcount helper Message-ID: <20201007144114.GB235506@mit.edu> References: <20201006230930.3908-1-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 06, 2020 at 07:40:05PM -0700, Dan Williams wrote: > On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > > > There are several places where ZONE_DEVICE struct pages assume a reference > > count == 1 means the page is idle and free. Instead of open coding this, > > add a helper function to hide this detail. > > > > Signed-off-by: Ralph Campbell > > Reviewed-by: Christoph Hellwig > > --- > > > > I'm resending this as a separate patch since I think it is ready to > > merge. Originally, this was part of an RFC and is unchanged from v3: > > https://lore.kernel.org/linux-mm/20201001181715.17416-1-rcampbell@nvidia.com > > > > It applies cleanly to linux-5.9.0-rc7-mm1 but doesn't really > > depend on anything, just simple merge conflicts when applied to > > other trees. > > I'll let the various maintainers decide which tree and when to merge. > > It isn't urgent since it is a clean up patch. > > Thanks Ralph, it looks good to me. Jan, or Ted care to ack? I don't > have much else pending for dax at the moment as Andrew is carrying my > dax updates for this cycle. Andrew please take this into -mm if you > get a chance. Otherwise I'll cycle back to it when some other dax > updates arrive in my queue. Acked-by: Theodore Ts'o # for fs/ext4/inode.c