From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E996C43467 for ; Thu, 8 Oct 2020 11:42:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9AFD20B1F for ; Thu, 8 Oct 2020 11:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9AFD20B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1967F6B0073; Thu, 8 Oct 2020 07:42:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D60246B0074; Thu, 8 Oct 2020 07:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0B8F6B0071; Thu, 8 Oct 2020 07:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 6CBE86B0072 for ; Thu, 8 Oct 2020 07:42:11 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EA08C1EE6 for ; Thu, 8 Oct 2020 11:42:10 +0000 (UTC) X-FDA: 77348569620.26.sense32_100e22a271d7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id C8C0A1804B661 for ; Thu, 8 Oct 2020 11:42:10 +0000 (UTC) X-HE-Tag: sense32_100e22a271d7 X-Filterd-Recvd-Size: 4071 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 8 Oct 2020 11:42:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BD377B28E; Thu, 8 Oct 2020 11:42:07 +0000 (UTC) From: Vlastimil Babka To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Vlastimil Babka Subject: [PATCH v2 5/7] mm, page_alloc: cache pageset high and batch in struct zone Date: Thu, 8 Oct 2020 13:41:59 +0200 Message-Id: <20201008114201.18824-6-vbabka@suse.cz> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201008114201.18824-1-vbabka@suse.cz> References: <20201008114201.18824-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All per-cpu pagesets for a zone use the same high and batch values, that = are duplicated there just for performance (locality) reasons. This patch adds= the same variables also to struct zone as a shared copy. This will be useful later for making possible to disable pcplists tempora= rily by setting high value to 0, while remembering the values for restoring th= em later. But we can also immediately benefit from not updating pagesets of = all possible cpus in case the newly recalculated values (after sysctl change = or memory online/offline) are actually unchanged from the previous ones. Signed-off-by: Vlastimil Babka --- include/linux/mmzone.h | 6 ++++++ mm/page_alloc.c | 17 +++++++++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index fb3bf696c05e..c63863794afc 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -470,6 +470,12 @@ struct zone { #endif struct pglist_data *zone_pgdat; struct per_cpu_pageset __percpu *pageset; + /* + * the high and batch values are copied to individual pagesets for + * faster access + */ + int pageset_high; + int pageset_batch; =20 #ifndef CONFIG_SPARSEMEM /* diff --git a/mm/page_alloc.c b/mm/page_alloc.c index f33c36312eb5..5b98dd5ab006 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5900,6 +5900,9 @@ static void build_zonelists(pg_data_t *pgdat) * Other parts of the kernel may not check if the zone is available. */ static void pageset_init(struct per_cpu_pageset *p); +/* These effectively disable the pcplists in the boot pageset completely= */ +#define BOOT_PAGESET_HIGH 0 +#define BOOT_PAGESET_BATCH 1 static DEFINE_PER_CPU(struct per_cpu_pageset, boot_pageset); static DEFINE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); =20 @@ -6289,8 +6292,8 @@ static void pageset_init(struct per_cpu_pageset *p) * need to be as careful as pageset_update() as nobody can access the * pageset yet. */ - pcp->high =3D 0; - pcp->batch =3D 1; + pcp->high =3D BOOT_PAGESET_HIGH; + pcp->batch =3D BOOT_PAGESET_BATCH; } =20 /* @@ -6314,6 +6317,14 @@ static void zone_set_pageset_high_and_batch(struct= zone *zone) new_batch =3D max(1UL, 1 * new_batch); } =20 + if (zone->pageset_high !=3D new_high || + zone->pageset_batch !=3D new_batch) { + zone->pageset_high =3D new_high; + zone->pageset_batch =3D new_batch; + } else { + return; + } + for_each_possible_cpu(cpu) { p =3D per_cpu_ptr(zone->pageset, cpu); pageset_update(&p->pcp, new_high, new_batch); @@ -6374,6 +6385,8 @@ static __meminit void zone_pcp_init(struct zone *zo= ne) * offset of a (static) per cpu variable into the per cpu area. */ zone->pageset =3D &boot_pageset; + zone->pageset_high =3D BOOT_PAGESET_HIGH; + zone->pageset_batch =3D BOOT_PAGESET_BATCH; =20 if (populated_zone(zone)) printk(KERN_DEBUG " %s zone: %lu pages, LIFO batch:%u\n", --=20 2.28.0