From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64501C433E7 for ; Mon, 12 Oct 2020 15:18:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CADA22076D for ; Mon, 12 Oct 2020 15:18:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=suse.com header.i=@suse.com header.b="HE4rZuTU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CADA22076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 156AA6B005C; Mon, 12 Oct 2020 11:18:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 107A06B005D; Mon, 12 Oct 2020 11:18:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1AD76B0062; Mon, 12 Oct 2020 11:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id BE9B06B005C for ; Mon, 12 Oct 2020 11:18:12 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 461EF8249980 for ; Mon, 12 Oct 2020 15:18:12 +0000 (UTC) X-FDA: 77363629224.28.hall32_5305959271fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 1DE686C0B for ; Mon, 12 Oct 2020 15:18:12 +0000 (UTC) X-HE-Tag: hall32_5305959271fb X-Filterd-Recvd-Size: 3144 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 12 Oct 2020 15:18:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602515890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KXm6WqyCf2FrwBUyLHe8A+/FxTPh7eaFi1IQMh6LHUA=; b=HE4rZuTUcmbYJQyqdXmHYAC6l2eGbV8XAtEP5luOYK++nZ4LlxNhfKG+GGn+g+R01v4cTx shfFCJsBodmXaoeLmPSl+75+JznHUl3/VjC2FzIk51YVnvXmKuu4VVQ3WMQoRhCRBItggh lxLvZol0GQnUCU+b7d/uLZZIrk5ciss= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 88AC4ACAC; Mon, 12 Oct 2020 15:18:10 +0000 (UTC) Date: Mon, 12 Oct 2020 17:18:04 +0200 From: Michal Hocko To: Ricardo =?iso-8859-1?Q?Ca=F1uelo?= Cc: akpm@linux-foundation.org, kernel@collabora.com, hch@lst.de, guro@fb.com, rientjes@google.com, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm, oom: enable rate-limiting controls for oom dumps Message-ID: <20201012151804.GG29725@dhcp22.suse.cz> References: <20201009093014.9412-1-ricardo.canuelo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20201009093014.9412-1-ricardo.canuelo@collabora.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 09-10-20 11:30:14, Ricardo Ca=F1uelo wrote: > Add two sysctl entries (vm.oom_dump_ratelimit and > vm.oom_dump_ratelimit_burst) to control the rate limiting interval and > burst, respectively, of the OOM killer output (oom_kill_process()). >=20 > These entries are disabled by default and can be enabled during kernel > configuration with CONFIG_DUMP_RATELIMIT. They take > DEFAULT_RATELIMIT_INTERVAL and DEFAULT_RATELIMIT_BURST as their default > values. >=20 > Signed-off-by: Ricardo Ca=F1uelo > --- >=20 > In some setups, the amount of output that the OOM killer generates when > it kills a process and dumps the list of tasks can be too > large. Unfortunately, the rate-limiting used for it uses the default > values for the rate limit interval and burst. This patch allows the use= r > to configure these values. How does controling burst and interval solve the problem? Btw. this should be a part of the changelog which should explain not only what but also why the change is needed. It is true that the oom report can generate a lot of output. This is something that is brought up for quite some time. The largest part of the output tends to be the list of tasks and this seems to be the case for you as well. Is the list of tasks so important that you need to have it in the log? If not you can simply disable this part of the log altogether by /proc/sys/vm/oom_dump_tasks. --=20 Michal Hocko SUSE Labs