From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D67C433E7 for ; Wed, 14 Oct 2020 20:36:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34CC92224D for ; Wed, 14 Oct 2020 20:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YOSWf8zU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34CC92224D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 37C926B005D; Wed, 14 Oct 2020 16:36:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32F866B0062; Wed, 14 Oct 2020 16:36:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243766B0068; Wed, 14 Oct 2020 16:36:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id E7AB06B005D for ; Wed, 14 Oct 2020 16:36:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 73265181AC9C6 for ; Wed, 14 Oct 2020 20:36:10 +0000 (UTC) X-FDA: 77371688100.26.stamp39_3f0ed932720e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 508481804B656 for ; Wed, 14 Oct 2020 20:36:10 +0000 (UTC) X-HE-Tag: stamp39_3f0ed932720e X-Filterd-Recvd-Size: 2741 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 14 Oct 2020 20:36:09 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A69022249; Wed, 14 Oct 2020 20:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602707768; bh=nDZMRzWG7gYP7mjsXiRsPfXA6cL+zIi6JULaouk468E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YOSWf8zUI42En+qWKtnoLC0kblv7jVr5ZG+fS4a+WgjNqRiQx6xikSMctmczqBPsN IxEgFLKKRV9H4kRX+chwy6Wa+tahUFGLMgW/jtSHjaVT59wTsP+SnnsEXsYdxk4cTC 5FS3TQIJGUlEfMHk+/PnVmZAjbnqlcpaaiFXj3g4= Date: Wed, 14 Oct 2020 13:36:07 -0700 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, Anshuman Khandual Subject: Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes Message-Id: <20201014133607.fbf63d060e331fcd6007b624@linux-foundation.org> In-Reply-To: <034db663-a5bd-fd5e-b7f6-3ec31310e8e5@linux.ibm.com> References: <20200902114222.181353-1-aneesh.kumar@linux.ibm.com> <20201013135858.f4a7f0c5f3b0a69a2a304cfe@linux-foundation.org> <034db663-a5bd-fd5e-b7f6-3ec31310e8e5@linux.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Oct 2020 08:45:16 +0530 "Aneesh Kumar K.V" wrote: > > Against mm-debug_vm_pgtable-avoid-none-pte-in-pte_clear_test.patch: > > > > https://lkml.kernel.org/r/87zh5wx51b.fsf@linux.ibm.com > > > yes this one we should get fixed. I was hoping someone familiar with > Riscv pte updates rules would pitch in. IIUC we need to update > RANDON_ORVALUE similar to how we updated it for s390 and ppc64. > > > Alternatively we can do this > > modified mm/debug_vm_pgtable.c > @@ -548,7 +548,7 @@ static void __init pte_clear_tests(struct mm_struct > *mm, pte_t *ptep, > pte_t pte = pfn_pte(pfn, prot); > > pr_debug("Validating PTE clear\n"); > - pte = __pte(pte_val(pte) | RANDOM_ORVALUE); > +// pte = __pte(pte_val(pte) | RANDOM_ORVALUE); > set_pte_at(mm, vaddr, ptep, pte); > barrier(); > pte_clear(mm, vaddr, ptep); > > till we get that feedback from RiscV team? Would it be better to do #ifdef CONFIG_S390 pte = __pte(pte_val(pte) | RANDOM_ORVALUE); #endif ?