From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7196C433DF for ; Fri, 16 Oct 2020 02:48:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2DE5720E65 for ; Fri, 16 Oct 2020 02:48:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HZYZPkqv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE5720E65 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC4E1940059; Thu, 15 Oct 2020 22:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4CFD940034; Thu, 15 Oct 2020 22:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A626A940059; Thu, 15 Oct 2020 22:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 6E459940034 for ; Thu, 15 Oct 2020 22:48:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0B21C3623 for ; Fri, 16 Oct 2020 02:48:22 +0000 (UTC) X-FDA: 77376254844.12.tree58_360012327219 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id D999C18016652 for ; Fri, 16 Oct 2020 02:48:21 +0000 (UTC) X-HE-Tag: tree58_360012327219 X-Filterd-Recvd-Size: 2222 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 02:48:21 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AF8A208E4; Fri, 16 Oct 2020 02:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602816500; bh=QoUnqKZJPGgPSD2L+NFlQaQN482vyk4CXuqa4iADZfM=; h=Date:From:To:Subject:In-Reply-To:From; b=HZYZPkqv6/flWKYEkMMHysbxfAa1q7Dz5wjDNRzZE+4vNUYa7yJv1lRz2zjf7bKIP khh3yxEjW1YLK0dgwvC4/cx3A41RlZBUxEfldfEibXK/IMSlppx+NFRZ3nndk/Y+TB HRW81CQiJJfI0h9aaNMmns3sMX58DdcgHimKgikQ= Date: Thu, 15 Oct 2020 19:48:19 -0700 From: Andrew Morton To: akpm@linux-foundation.org, linmiaohe@huawei.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 115/156] lib/percpu_counter.c: use helper macro abs() Message-ID: <20201016024819.q9mQrHzJJ%akpm@linux-foundation.org> In-Reply-To: <20201015192732.f448da14e9854c7cb7299956@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Miaohe Lin Subject: lib/percpu_counter.c: use helper macro abs() Use helper macro abs() to simplify the "x >= t || x <= -t" cmp. Link: https://lkml.kernel.org/r/20200927122746.5964-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- lib/percpu_counter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/percpu_counter.c~percpu_counter-use-helper-macro-abs +++ a/lib/percpu_counter.c @@ -85,7 +85,7 @@ void percpu_counter_add_batch(struct per preempt_disable(); count = __this_cpu_read(*fbc->counters) + amount; - if (count >= batch || count <= -batch) { + if (abs(count) >= batch) { unsigned long flags; raw_spin_lock_irqsave(&fbc->lock, flags); fbc->count += count; _