From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD80C433E7 for ; Sun, 18 Oct 2020 14:26:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAB6621655 for ; Sun, 18 Oct 2020 14:26:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAB6621655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3EA006B0068; Sun, 18 Oct 2020 10:26:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 399416B006E; Sun, 18 Oct 2020 10:26:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6646B0070; Sun, 18 Oct 2020 10:26:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 012FF6B0068 for ; Sun, 18 Oct 2020 10:26:01 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 878D3181AEF00 for ; Sun, 18 Oct 2020 14:26:01 +0000 (UTC) X-FDA: 77385270522.20.store61_2b15c212722f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 68447180C07A3 for ; Sun, 18 Oct 2020 14:26:01 +0000 (UTC) X-HE-Tag: store61_2b15c212722f X-Filterd-Recvd-Size: 1742 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 14:26:00 +0000 (UTC) Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 09IEPvdO008343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 18 Oct 2020 10:25:58 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 5346C420107; Sun, 18 Oct 2020 10:25:57 -0400 (EDT) Date: Sun, 18 Oct 2020 10:25:57 -0400 From: "Theodore Y. Ts'o" To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 12/18] ext4: Return error from ext4_readpage Message-ID: <20201018142557.GH181507@mit.edu> References: <20201016160443.18685-1-willy@infradead.org> <20201016160443.18685-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016160443.18685-13-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 16, 2020 at 05:04:37PM +0100, Matthew Wilcox (Oracle) wrote: > The error returned from ext4_map_blocks() was being discarded, leading > to the generic -EIO being returned to userspace. Now ext4 can return > more precise errors. > > Signed-off-by: Matthew Wilcox (Oracle) This change is independent of the synchronous readpage changes, correct? Or am I missing something? Cheers, - Ted