From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FFDC43457 for ; Sun, 18 Oct 2020 19:03:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2D9222268 for ; Sun, 18 Oct 2020 19:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="niIKSZoV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2D9222268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 09C096B005D; Sun, 18 Oct 2020 15:03:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04B3B6B0062; Sun, 18 Oct 2020 15:03:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54836B0068; Sun, 18 Oct 2020 15:03:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id BA8C16B005D for ; Sun, 18 Oct 2020 15:03:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 508E71EE6 for ; Sun, 18 Oct 2020 19:03:39 +0000 (UTC) X-FDA: 77385970158.06.rock58_28123b227230 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 2FCE2101A248D for ; Sun, 18 Oct 2020 19:03:39 +0000 (UTC) X-HE-Tag: rock58_28123b227230 X-Filterd-Recvd-Size: 3196 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sun, 18 Oct 2020 19:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=afnas33m8RDgPqFwBIzwHPaO8Wl+s0d8NVdlwk67jCU=; b=niIKSZoVLfUFY550hUfkx4kRIC x6gS8QQVJw1+5nLgAXhafbGp/5UcwkE08hcybfUFiDLNzVLpXiX14dN8yhebISI490WhUXc5Pqcrl +vBjc5ZmLj1smot28IZhHaUKTX/1n+TPtOPXmdr3mTVgR1eZhIOun3semjseZ6x4UIETEkn3Ef8/l 6ZT5EXA2u1seiPW0RGibewMNr85+mhsHtRqH95Xb3yMkKYfzd7v/x9V0yD9QbMj5oO7Ih6ligLtIZ H2KdfUaR2nI7pyA0fSvHUgNgGhSS0b7w5ait/mAMc6Etaz/4i/BmA+r7y09oZ0zwL4oLIXOnT9UOZ SeTad1qg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUDxn-0007oK-S6; Sun, 18 Oct 2020 19:03:28 +0000 Date: Sun, 18 Oct 2020 20:03:27 +0100 From: Matthew Wilcox To: John Hubbard Cc: Linus Torvalds , Andrew Morton , Jonathan Corbet , Jerome Glisse , Linux-MM , mm-commits@vger.kernel.org, Ralph Campbell , Shuah Khan , Jason Gary Gunthorpe Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h Message-ID: <20201018190327.GN20115@casper.infradead.org> References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 18, 2020 at 11:50:10AM -0700, John Hubbard wrote: > On 10/18/20 9:18 AM, Linus Torvalds wrote: > > On Sat, Oct 17, 2020 at 4:14 PM Andrew Morton wrote: > > > > > > --- a/mm/gup_test.c~selftests-vm-use-a-common-gup_testh > > > +++ a/mm/gup_test.c > > > @@ -4,22 +4,7 @@ > > > +#include "../../../../mm/gup_test.h" > > > +++ a/mm/gup_test.h > > > > There is no way I'm applying a crazy patch like this. > > > > That can't be right. > > > > And even if it works, it *still* isn't right. > > > > Linus > > > > I feel the same way about the ridiculous ../..'s in the include path. But that > seemed to be the accepted way (I even have an email that I'm trying to find, in > which someone confirmed that...ah here, it is [1], and I'm adding Jason to CC) > for the odd situation of sharing a header file between kernel and user space, > for the kselftest world. > > If there's a different acceptable way, I'd be delighted to use that. See where it says: CFLAGS = -Wall -I ../../../../usr/include $(EXTRA_CFLAGS) Does adding an extra -I../../../../mm to that line not do the trick?