From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch> Subject: [PATCH v3 00/16] follow_pfn and other iomap races Date: Wed, 21 Oct 2020 10:56:39 +0200 [thread overview] Message-ID: <20201021085655.1192025-1-daniel.vetter@ffwll.ch> (raw) Hi all, Round 3 of my patch series to clamp down a bunch of races and gaps around follow_pfn and other access to iomem mmaps. Previous version: v1: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ v2: https://lore.kernel.org/dri-devel/20201009075934.3509076-1-daniel.vetter@ffwll.ch And the discussion that sparked this journey: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ I was waiting for the testing result for habanalabs from Oded, but I guess Oded was waiting for my v3. Changes in v3: - Bunch of polish all over, no functional changes aside from one barrier in the resource code, for consistency. - A few more r-b tags. Changes in v2: - tons of small polish&fixes all over, thanks to all the reviewers who spotted issues - I managed to test at least the generic_access_phys and pci mmap revoke stuff with a few gdb sessions using our i915 debug tools (hence now also the drm/i915 patch to properly request all the pci bar regions) - reworked approach for the pci mmap revoke: Infrastructure moved into kernel/resource.c, address_space mapping is now set up at open time for everyone (which required some sysfs changes). Does indeed look a lot cleaner and a lot less invasive than I feared at first. The big thing I can't test are all the frame_vector changes in habanalbas, exynos and media. Gerald has given the s390 patch a spin already. Review, testing, feedback all very much welcome. Cheers, Daniel Daniel Vetter (16): drm/exynos: Stop using frame_vector helpers drm/exynos: Use FOLL_LONGTERM for g2d cmdlists misc/habana: Stop using frame_vector helpers misc/habana: Use FOLL_LONGTERM for userptr mm/frame-vector: Use FOLL_LONGTERM media: videobuf2: Move frame_vector into media subsystem mm: Close race in generic_access_phys s390/pci: Remove races against pte updates mm: Add unsafe_follow_pfn media/videbuf1|2: Mark follow_pfn usage as unsafe vfio/type1: Mark follow_pfn as unsafe PCI: Obey iomem restrictions for procfs mmap /dev/mem: Only set filp->f_mapping resource: Move devmem revoke code to resource framework sysfs: Support zapping of binary attr mmaps PCI: Revoke mappings like devmem arch/s390/pci/pci_mmio.c | 98 ++++++++++------- drivers/char/mem.c | 86 +-------------- drivers/gpu/drm/exynos/Kconfig | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++----- drivers/media/common/videobuf2/Kconfig | 1 - drivers/media/common/videobuf2/Makefile | 1 + .../media/common/videobuf2}/frame_vector.c | 54 ++++------ drivers/media/platform/omap/Kconfig | 1 - drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- drivers/misc/habanalabs/Kconfig | 1 - drivers/misc/habanalabs/common/habanalabs.h | 6 +- drivers/misc/habanalabs/common/memory.c | 50 ++++----- drivers/pci/pci-sysfs.c | 4 + drivers/pci/proc.c | 6 ++ drivers/vfio/vfio_iommu_type1.c | 4 +- fs/sysfs/file.c | 11 ++ include/linux/ioport.h | 6 +- include/linux/mm.h | 47 +------- include/linux/sysfs.h | 2 + include/media/frame_vector.h | 47 ++++++++ include/media/videobuf2-core.h | 1 + kernel/resource.c | 101 +++++++++++++++++- mm/Kconfig | 3 - mm/Makefile | 1 - mm/memory.c | 76 ++++++++++++- mm/nommu.c | 17 +++ security/Kconfig | 13 +++ 27 files changed, 403 insertions(+), 285 deletions(-) rename {mm => drivers/media/common/videobuf2}/frame_vector.c (85%) create mode 100644 include/media/frame_vector.h -- 2.28.0
next reply other threads:[~2020-10-21 8:57 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-21 8:56 Daniel Vetter [this message] 2020-10-21 8:56 ` [PATCH v3 01/16] drm/exynos: Stop using frame_vector helpers Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 03/16] misc/habana: Stop using frame_vector helpers Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 04/16] misc/habana: Use FOLL_LONGTERM for userptr Daniel Vetter 2020-10-23 9:12 ` Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 05/16] mm/frame-vector: Use FOLL_LONGTERM Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 06/16] media: videobuf2: Move frame_vector into media subsystem Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 07/16] mm: Close race in generic_access_phys Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 08/16] s390/pci: Remove races against pte updates Daniel Vetter 2020-10-21 9:37 ` Niklas Schnelle 2020-10-21 13:56 ` Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 09/16] mm: Add unsafe_follow_pfn Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 10/16] media/videbuf1|2: Mark follow_pfn usage as unsafe Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 11/16] vfio/type1: Mark follow_pfn " Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap Daniel Vetter 2020-10-21 12:50 ` Jason Gunthorpe 2020-10-21 14:42 ` Daniel Vetter 2020-10-21 15:13 ` Jason Gunthorpe 2020-10-21 15:54 ` Daniel Vetter 2020-10-21 16:37 ` Jason Gunthorpe 2020-10-21 19:24 ` Daniel Vetter 2020-10-21 23:20 ` Jason Gunthorpe 2020-10-22 7:00 ` Daniel Vetter 2020-10-22 11:43 ` Jason Gunthorpe 2020-10-22 13:04 ` Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 13/16] /dev/mem: Only set filp->f_mapping Daniel Vetter 2020-10-21 18:21 ` Dan Williams 2020-10-21 8:56 ` [PATCH v3 14/16] resource: Move devmem revoke code to resource framework Daniel Vetter 2020-10-21 18:59 ` Dan Williams 2020-10-21 19:25 ` Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 15/16] sysfs: Support zapping of binary attr mmaps Daniel Vetter 2020-10-21 8:56 ` [PATCH v3 16/16] PCI: Revoke mappings like devmem Daniel Vetter 2020-10-21 12:51 ` [PATCH v3 00/16] follow_pfn and other iomap races Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201021085655.1192025-1-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kvm@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --subject='Re: [PATCH v3 00/16] follow_pfn and other iomap races' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).