From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132D4C5517A for ; Thu, 22 Oct 2020 07:39:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E7546223C7 for ; Thu, 22 Oct 2020 07:39:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="E/MPYUGe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7546223C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21FC96B005D; Thu, 22 Oct 2020 03:39:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AA586B0062; Thu, 22 Oct 2020 03:39:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0218A6B0068; Thu, 22 Oct 2020 03:39:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id C6DF86B005D for ; Thu, 22 Oct 2020 03:39:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6E281180AD817 for ; Thu, 22 Oct 2020 07:39:48 +0000 (UTC) X-FDA: 77398762056.06.truck25_2403c0f2724f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 480DD1026639C for ; Thu, 22 Oct 2020 07:39:48 +0000 (UTC) X-HE-Tag: truck25_2403c0f2724f X-Filterd-Recvd-Size: 8463 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 07:39:47 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id h5so864998wrv.7 for ; Thu, 22 Oct 2020 00:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=E/MPYUGexYpX5poBWZtyJ39mlDhFG9B6MQdMbkqfAlosbuXR0KbLsXkH8XsRroHwK0 /z7PTmxv54Le3uyVqgU2BJoYAcDBAKDf93cFoIPUObTp1nwUXkwW9LrbIa/QW11E9gxi dUfc5MnZ1w7Z5dq/D5VWhQ+QyH68LGgtFOW8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=FUnmmeK5QmN6I6X95NR6HhlReLcd0WiZp6VBOWMixY8=; b=fSkCAPLkeOMX9mdotSD7MbvwzpTLiQRtwDyNwDP+PZpOvb2vYEdwzzhVwqCyWVlZI+ +PKomjAjelHzJ14t5A+lqMRgrvJWGYXngFedIGDeULOPKDjYAGpLzJuGKHxdDkndXxf/ 08PG2p3kzEpuSzphw1lcsHF+YAwu/DkL8ahn6891wC19QG/08fNWXvax8IS9J7Choh2m k+LXGFysB591nqNwDDz3zKfUG8WPojcfDtT8Srvcou2ziS998tQ9ro+QIoUNSWAYsfBY rw/EhvsOzL1Tk6Ynk/kzxsASs1rxOk/15cHGJPKDoxDieGaTepSZFzIYRzlH6vbP8cSu nckg== X-Gm-Message-State: AOAM532rMkDuNPRTR1HVXtx5c0mB7JjoRV7A70YTQLPwFK7tj0hxRP+v HVaQd5JkWQavN2hE7nbE/BAjKA== X-Google-Smtp-Source: ABdhPJw5HQV9NuUaTW2fOSG+4dZhqrMNCjk+Neg7/gkBYNKwDOO+9vGK8A43OgHPliV3xlB5PKsA7A== X-Received: by 2002:adf:f986:: with SMTP id f6mr1319485wrr.38.1603352386434; Thu, 22 Oct 2020 00:39:46 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j7sm2061526wrn.81.2020.10.22.00.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 00:39:45 -0700 (PDT) Date: Thu, 22 Oct 2020 09:39:43 +0200 From: Daniel Vetter To: Niklas Schnelle Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara Subject: Re: [PATCH v2 08/17] s390/pci: Remove races against pte updates Message-ID: <20201022073943.GS401619@phenom.ffwll.local> Mail-Followup-To: Niklas Schnelle , DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer , Daniel Vetter , Jason Gunthorpe , Dan Williams , Kees Cook , Andrew Morton , John Hubbard , =?iso-8859-1?B?Suly9G1l?= Glisse , Jan Kara References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-9-daniel.vetter@ffwll.ch> <6deb08dd-46f3-bf26-5362-fdc696f6fd74@linux.ibm.com> <20201012141906.GX438822@phenom.ffwll.local> <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3594c115-541f-806a-ee33-e99a2d1d31e8@linux.ibm.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 21, 2020 at 09:55:57AM +0200, Niklas Schnelle wrote: > Hi Daniel, >=20 > friendly ping. I haven't seen a new version of this patch series, > as I said I think your change for s390/pci is generally useful so > I'm curious, are you planning on sending a new version soon? > If you want you can also just sent this patch with the last few > nitpicks (primarily the mail address) fixed and I'll happily apply. (I think this was stuck somewhere in moderation, only showed up just now) I was waiting for the testing result for the habana driver from Oded, but I guess Oded was waiting for v3. Hence the delay. Cheers, Daniel >=20 > Best regards, > Niklas Schnelle >=20 > On 10/12/20 4:19 PM, Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 04:03:28PM +0200, Niklas Schnelle wrote: > ... snip .... > >>> Cc: Jason Gunthorpe > >>> Cc: Dan Williams > >>> Cc: Kees Cook > >>> Cc: Andrew Morton > >>> Cc: John Hubbard > >>> Cc: J=E9r=F4me Glisse > >>> Cc: Jan Kara > >>> Cc: Dan Williams > >> > >> The above Cc: line for Dan Williams is a duplicate > >> > >>> Cc: linux-mm@kvack.org > >>> Cc: linux-arm-kernel@lists.infradead.org > >>> Cc: linux-samsung-soc@vger.kernel.org > >>> Cc: linux-media@vger.kernel.org > >>> Cc: Niklas Schnelle > >>> Cc: Gerald Schaefer > >>> Cc: linux-s390@vger.kernel.org > >>> -- > >>> v2: Move VM_IO | VM_PFNMAP checks around so they keep returning EIN= VAL > >>> like before (Gerard) > >> > >> I think the above should go before the CC/Signed-off/Reviewev block. > >=20 > > This is a per-subsystem bikeshed :-) drivers/gpu definitely wants it > > above, but most core subsystems want it below. I'll move it. > >=20 > >>> --- > >>> arch/s390/pci/pci_mmio.c | 98 +++++++++++++++++++++++-------------= ---- > >>> 1 file changed, 57 insertions(+), 41 deletions(-) > >>> > >>> diff --git a/arch/s390/pci/pci_mmio.c b/arch/s390/pci/pci_mmio.c > >>> index 401cf670a243..1a6adbc68ee8 100644 > >>> --- a/arch/s390/pci/pci_mmio.c > >>> +++ b/arch/s390/pci/pci_mmio.c > >>> @@ -119,33 +119,15 @@ static inline int __memcpy_toio_inuser(void _= _iomem *dst, > >>> return rc; > >>> } > >>> =20 > >>> -static long get_pfn(unsigned long user_addr, unsigned long access, > >>> - unsigned long *pfn) > >>> -{ > >>> - struct vm_area_struct *vma; > >>> - long ret; > >>> - > >>> - mmap_read_lock(current->mm); > >>> - ret =3D -EINVAL; > >>> - vma =3D find_vma(current->mm, user_addr); > >>> - if (!vma) > >>> - goto out; > >>> - ret =3D -EACCES; > >>> - if (!(vma->vm_flags & access)) > >>> - goto out; > >>> - ret =3D follow_pfn(vma, user_addr, pfn); > >>> -out: > >>> - mmap_read_unlock(current->mm); > >>> - return ret; > >>> -} > >>> - > >>> SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr, > >>> const void __user *, user_buffer, size_t, length) > >>> { > >>> u8 local_buf[64]; > >>> void __iomem *io_addr; > >>> void *buf; > >>> - unsigned long pfn; > >>> + struct vm_area_struct *vma; > >>> + pte_t *ptep; > >>> + spinlock_t *ptl; > >> > >> With checkpatch.pl --strict the above yields a complained > >> "CHECK: spinlock_t definition without comment" but I think > >> that's really okay since your commit description is very clear. > >> Same oin line 277. > >=20 > > I think this is a falls positive, checkpatch doesn't realize that > > SYSCALL_DEFINE3 is a function, not a structure. And in a structure I'= d > > have added the kerneldoc or comment. > >=20 > > I'll fix up all the nits you've found for the next round. Thanks for > > taking a look. > > -Daniel > >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch