From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAB9C55179 for ; Thu, 22 Oct 2020 12:07:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 542132245F for ; Thu, 22 Oct 2020 12:07:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="ag1A3+hD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 542132245F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 579356B0062; Thu, 22 Oct 2020 08:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 529136B0068; Thu, 22 Oct 2020 08:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C8A76B006C; Thu, 22 Oct 2020 08:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 118956B0062 for ; Thu, 22 Oct 2020 08:07:48 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A07C3180AD815 for ; Thu, 22 Oct 2020 12:07:47 +0000 (UTC) X-FDA: 77399437374.24.tub33_4f0735b27250 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 8CFE71A4A5 for ; Thu, 22 Oct 2020 12:07:47 +0000 (UTC) X-HE-Tag: tub33_4f0735b27250 X-Filterd-Recvd-Size: 5605 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 12:07:47 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id l28so1927884lfp.10 for ; Thu, 22 Oct 2020 05:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZA39m5B4lfhB7qi65Cq382t5m8SNmLhvXePaPr7AO4w=; b=ag1A3+hDk6wBaHU7tVEqAGouGpo8ukJV++f6+bRpXuby9BfbKDoEexFJBA/cf+y2qp /IS9F7M0Iyubb8pI64mgjCbtpwWeprftcbIWFdchDE0IKQxzVnZt3TN7lBO9FNBZF23A /BqNhvrshCX6I/s4oatmngPWfTHgnKjatSCAHF6bloJOdoTi2TqyOrGZVjiTk2s0XJIB g9LK6pwxhhNyHuVF7kGYgniPzaV6lrBuEWp6CaEata+zn0ZB2rWyow7wfe693xA7l2Yo Q1vAxB6k4HKhq/cmLdhyvFVG6dgL9i6crSL8SQtHCNdTr6kuTg2rFzeB5/O6QpqO+Y+s GTiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZA39m5B4lfhB7qi65Cq382t5m8SNmLhvXePaPr7AO4w=; b=aSfuv3IfZ7DQ3V53G+ZvVEdRzbNHPWv+z/D0XhqH/sZ4iIEsi1Mkasy2572HaQXUg2 G9wHCoPQOlJ04Cwq/5gIaNdYGg8N3yz4K4Ac01kEjrRroI6TJ2eCiRl4I3bzhMSg9doW Lodu1Gzj+pr8NW9iJaxNEUVx8A2CJi+KPB9jzkkc/6N0Qal3ymf2JAoSB5v9YSoY6vpC bYj3arhBglZjoda0Qghw2pCQN30Px9kkPPHF9LS4v5Nvqw7OZ8nH+D5cswfdBisKxyOl kcpjL1/ANnXQCN4tojEhT9VHJeKyaMuqAJLU4psMOBpbwa7+UFrYsxmVoFXRxA5F0jlb fx5w== X-Gm-Message-State: AOAM532o9WmH0wfGKNBgmtaDyTN7pqUCuLi4bwpyuHG0ZkqXsAn096I/ IFH3IAgVIZI72thARxGgLcab3Q== X-Google-Smtp-Source: ABdhPJzv4cMC9f5whc1/8PrlqdKus3Ypn6OTbtFMlq/llXt/prAe3CBMuvyqIY+7JRXyBV1qXMs+hw== X-Received: by 2002:a05:6512:2098:: with SMTP id t24mr809068lfr.116.1603368465669; Thu, 22 Oct 2020 05:07:45 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id f129sm238766lfd.201.2020.10.22.05.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 05:07:44 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 70D33102F6D; Thu, 22 Oct 2020 15:07:44 +0300 (+03) Date: Thu, 22 Oct 2020 15:07:44 +0300 From: "Kirill A. Shutemov" To: Halil Pasic Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , David Rientjes , Andrea Arcangeli , Kees Cook , Will Drewry , "Edgecombe, Rick P" , "Kleen, Andi" , Liran Alon , Mike Rapoport , x86@kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: Re: [RFCv2 14/16] KVM: Handle protected memory in __kvm_map_gfn()/__kvm_unmap_gfn() Message-ID: <20201022120744.t5ap3f6maeuspkd3@box> References: <20201020061859.18385-1-kirill.shutemov@linux.intel.com> <20201020061859.18385-15-kirill.shutemov@linux.intel.com> <20201022052647.6a4d7e0b.pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022052647.6a4d7e0b.pasic@linux.ibm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 05:26:47AM +0200, Halil Pasic wrote: > On Tue, 20 Oct 2020 09:18:57 +0300 > "Kirill A. Shutemov" wrote: > > > We cannot access protected pages directly. Use ioremap() to > > create a temporary mapping of the page. The mapping is destroyed > > on __kvm_unmap_gfn(). > > > > The new interface gfn_to_pfn_memslot_protected() is used to detect if > > the page is protected. > > > > ioremap_cache_force() is a hack to bypass IORES_MAP_SYSTEM_RAM check in > > the x86 ioremap code. We need a better solution. > > > > Signed-off-by: Kirill A. Shutemov > > --- > > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- > > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > > arch/x86/include/asm/io.h | 2 + > > arch/x86/include/asm/pgtable_types.h | 1 + > > arch/x86/kvm/mmu/mmu.c | 6 ++- > > arch/x86/mm/ioremap.c | 16 ++++++-- > > include/linux/kvm_host.h | 3 +- > > include/linux/kvm_types.h | 1 + > > virt/kvm/kvm_main.c | 52 +++++++++++++++++++------- > > 9 files changed, 63 insertions(+), 22 deletions(-) > > > > You declare ioremap_cache_force() arch/x86/include/asm/io.h in and > define it in arch/x86/mm/ioremap.c which is architecture specific code, > but use it in __kvm_map_gfn() in virt/kvm/kvm_main.c which is common > code. > > Thus your series breaks the build for the s390 architecture. Have you > tried to (cross) compile for s390? Obviously not. I've got reports already from 0day and going to fix it. Thanks. -- Kirill A. Shutemov