From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 438D3C388F9 for ; Thu, 22 Oct 2020 12:34:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AD3622267 for ; Thu, 22 Oct 2020 12:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AD3622267 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEBDF6B0068; Thu, 22 Oct 2020 08:34:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B73486B006C; Thu, 22 Oct 2020 08:34:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A62FD6B006E; Thu, 22 Oct 2020 08:34:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 73F1C6B0068 for ; Thu, 22 Oct 2020 08:34:12 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7DFA889EB055 for ; Thu, 22 Oct 2020 12:34:10 +0000 (UTC) X-FDA: 77399503860.05.ants92_470e26e27251 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 62F2A18014D0D for ; Thu, 22 Oct 2020 12:34:10 +0000 (UTC) X-HE-Tag: ants92_470e26e27251 X-Filterd-Recvd-Size: 1737 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 12:34:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C14A0AD2F; Thu, 22 Oct 2020 12:34:08 +0000 (UTC) Date: Thu, 22 Oct 2020 14:34:06 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [PATCH v2 3/7] mm, page_alloc: remove setup_pageset() Message-ID: <20201022123355.GA26121@linux> References: <20201008114201.18824-1-vbabka@suse.cz> <20201008114201.18824-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008114201.18824-4-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 08, 2020 at 01:41:57PM +0200, Vlastimil Babka wrote: > We initialize boot-time pagesets with setup_pageset(), which sets high and > batch values that effectively disable pcplists. > > We can remove this wrapper if we just set these values for all pagesets in > pageset_init(). Non-boot pagesets then subsequently update them to the proper > values. > > No functional change. > > Signed-off-by: Vlastimil Babka > Reviewed-by: David Hildenbrand I think I already reviewed this one, but: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3