From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F102C4363A for ; Fri, 23 Oct 2020 12:11:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1FBC20EDD for ; Fri, 23 Oct 2020 12:11:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1FBC20EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D65A06B005D; Fri, 23 Oct 2020 08:11:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D168F6B0062; Fri, 23 Oct 2020 08:11:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B896B0068; Fri, 23 Oct 2020 08:11:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 936536B005D for ; Fri, 23 Oct 2020 08:11:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1A2D28BB863A for ; Fri, 23 Oct 2020 12:11:34 +0000 (UTC) X-FDA: 77403075708.01.end32_0f1170227259 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id D4F641004A08A for ; Fri, 23 Oct 2020 12:11:33 +0000 (UTC) X-HE-Tag: end32_0f1170227259 X-Filterd-Recvd-Size: 1734 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 12:11:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2C394ACB8; Fri, 23 Oct 2020 12:11:32 +0000 (UTC) Date: Fri, 23 Oct 2020 14:11:29 +0200 From: Oscar Salvador To: Laurent Cremmer Cc: Mike Kravetz , Andrew Morton , Mina Almasry , David Rientjes , linux-mm@kvack.org, Shuah Khan Subject: Re: [PATCH] hugetlb: fix locking in region_add,region_cgh,allocate_file_region_entries Message-ID: <20201023121129.GB3925@linux> References: <20201023074759.46605-1-laurent@oss.volkswagen.com> <20201023110204.GA3925@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 23, 2020 at 01:32:54PM +0200, Laurent Cremmer wrote: > I came to the same conclusion with the help of David's remarks :-) . > And in the end, this patch would be more about fixing the readability > of the code than fixing a live problem per-se. If it ain't broken, > don't fix it as they say :-) Yeah, definitely the code could benefit from a cleanup, so no one has to stare at it for a while before he gets the idea. -- Oscar Salvador SUSE L3