From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFC5C388F9 for ; Fri, 23 Oct 2020 15:46:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1FF64221F9 for ; Fri, 23 Oct 2020 15:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="nMYtmfd7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FF64221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AE066B005D; Fri, 23 Oct 2020 11:46:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F6A6B0062; Fri, 23 Oct 2020 11:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB5B06B0068; Fri, 23 Oct 2020 11:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id BF3A16B005D for ; Fri, 23 Oct 2020 11:46:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 421F7824999B for ; Fri, 23 Oct 2020 15:46:29 +0000 (UTC) X-FDA: 77403617298.20.foot28_2d00dc92725a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 22809180C07A3 for ; Fri, 23 Oct 2020 15:46:29 +0000 (UTC) X-HE-Tag: foot28_2d00dc92725a X-Filterd-Recvd-Size: 7385 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 15:46:28 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id z6so1542368qkz.4 for ; Fri, 23 Oct 2020 08:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p9SFHHcOJsampx1Cl5KD5pxmm62xezQzkl2AgXwIg08=; b=nMYtmfd7Kd0yx5RlvYYLzj90UoXDci6rmRFq7EPOhF/dJ2LTfSJHSEkkB+1OSlNe+w GiqkvSr1GKKUiy4PC53Tq4qvdqDZ/pev7wi/gB2rav3NCiDDuTIEcQ2FHfFIzGBIbirm kbjdDjXHa8ed6K9qDRZ/mpdAhJ8cjKXgfPV66k7KSWtrPTx9z8iX4xcaOPJCp06KUevt ze/AJxkW/LqTiLVjD3Lqxgx8nyU4cByWSskhBd3vfPkjlE9YgVAPnHoA4R1kCoM2Rcj+ BPBPV1UpX1SuDfLGu0eZSDNPNp3aM+tVNH+5rjnDPzwhm+lfy3ZcUwh1euuv8lXaVbqP eSWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p9SFHHcOJsampx1Cl5KD5pxmm62xezQzkl2AgXwIg08=; b=Ga3Kz9/Q35bmZaHnlRxq+q5Dnb80ZjtAQiyTfTKWqDWDLls5IqL8QhKjIPOfCOiXwJ 4l5uognj/xUTfvK3DMcNMjM7tVpU28m95JqnoS02AJBV1Ggi0n+PwXr3iFTQoCblpwko LcaOR5NN+232omtxEQRAq7aWvAhpYkja8aAWEk/ayFjHAhDhBsMcLix2AzqSJ48YFcTk ebmrxeAMQxiBKNTxdtMOpU44oe1fgbKNw8BpeHZA/7iviL2dNCIE6JIMJ8G6/CAwvxYy 4FP0apPkSh9Qi2Gs8dL/IcDgYhKJxSlxgz7yNs8x85tYFGafcEke46WDr891sy0XjGMM ibpw== X-Gm-Message-State: AOAM533gEnJHoNZN/scEo6zPxgsAj/oNgOjIiZM2SSVRv7N0nybBdrCB VaFSOidaST/KlbLBnZh97/exCw== X-Google-Smtp-Source: ABdhPJwtvG2d9rSTATn31XuUhkceHwaPagnD81bc37HcvcRtjxv7m8kqirsNscOdOjRY92diI2gYow== X-Received: by 2002:a05:620a:a41:: with SMTP id j1mr2893258qka.426.1603467987657; Fri, 23 Oct 2020 08:46:27 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:c400]) by smtp.gmail.com with ESMTPSA id t12sm942096qkg.132.2020.10.23.08.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 08:46:26 -0700 (PDT) Date: Fri, 23 Oct 2020 11:44:47 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Shakeel Butt , Richard Palethorpe , Linux MM , LKML , LTP List , Andrew Morton , Christoph Lameter , Michal Hocko , Tejun Heo , Vlastimil Babka Subject: Re: [PATCH v4] mm: memcg/slab: Stop reparented obj_cgroups from charging root Message-ID: <20201023154447.GA535375@cmpxchg.org> References: <87sga6vizp.fsf@suse.de> <20201022122858.8638-1-rpalethorpe@suse.com> <20201022172508.GF300658@carbon.dhcp.thefacebook.com> <20201023004026.GG300658@carbon.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023004026.GG300658@carbon.dhcp.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 05:40:26PM -0700, Roman Gushchin wrote: > From 19d66695f0ef1bf1ef7c51073ab91d67daa91362 Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Thu, 22 Oct 2020 17:12:32 -0700 > Subject: [PATCH] mm: memcg: link page counters to root if use_hierarchy is false > > Richard reported a warning which can be reproduced by running the LTP > madvise6 test (cgroup v1 in the non-hierarchical mode should be used): > > [ 9.841552] ------------[ cut here ]------------ > [ 9.841788] WARNING: CPU: 0 PID: 12 at mm/page_counter.c:57 page_counter_uncharge (mm/page_counter.c:57 mm/page_counter.c:50 mm/page_counter.c:156) > [ 9.841982] Modules linked in: > [ 9.842072] CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.9.0-rc7-22-default #77 > [ 9.842266] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.13.0-48-gd9c812d-rebuilt.opensuse.org 04/01/2014 > [ 9.842571] Workqueue: events drain_local_stock > [ 9.842750] RIP: 0010:page_counter_uncharge (mm/page_counter.c:57 mm/page_counter.c:50 mm/page_counter.c:156) > [ 9.842894] Code: 0f c1 45 00 4c 29 e0 48 89 ef 48 89 c3 48 89 c6 e8 2a fe ff ff 48 85 db 78 10 48 8b 6d 28 48 85 ed 75 d8 5b 5d 41 5c 41 5d c3 <0f> 0b eb ec 90 e8 4b f9 88 2a 48 8b 17 48 39 d6 72 41 41 54 49 89 > [ 9.843438] RSP: 0018:ffffb1c18006be28 EFLAGS: 00010086 > [ 9.843585] RAX: ffffffffffffffff RBX: ffffffffffffffff RCX: ffff94803bc2cae0 > [ 9.843806] RDX: 0000000000000001 RSI: ffffffffffffffff RDI: ffff948007d2b248 > [ 9.844026] RBP: ffff948007d2b248 R08: ffff948007c58eb0 R09: ffff948007da05ac > [ 9.844248] R10: 0000000000000018 R11: 0000000000000018 R12: 0000000000000001 > [ 9.844477] R13: ffffffffffffffff R14: 0000000000000000 R15: ffff94803bc2cac0 > [ 9.844696] FS: 0000000000000000(0000) GS:ffff94803bc00000(0000) knlGS:0000000000000000 > [ 9.844915] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 9.845096] CR2: 00007f0579ee0384 CR3: 000000002cc0a000 CR4: 00000000000006f0 > [ 9.845319] Call Trace: > [ 9.845429] __memcg_kmem_uncharge (mm/memcontrol.c:3022) > [ 9.845582] drain_obj_stock (./include/linux/rcupdate.h:689 mm/memcontrol.c:3114) > [ 9.845684] drain_local_stock (mm/memcontrol.c:2255) > [ 9.845789] process_one_work (./arch/x86/include/asm/jump_label.h:25 ./include/linux/jump_label.h:200 ./include/trace/events/workqueue.h:108 kernel/workqueue.c:2274) > [ 9.845898] worker_thread (./include/linux/list.h:282 kernel/workqueue.c:2416) > [ 9.846034] ? process_one_work (kernel/workqueue.c:2358) > [ 9.846162] kthread (kernel/kthread.c:292) > [ 9.846271] ? __kthread_bind_mask (kernel/kthread.c:245) > [ 9.846420] ret_from_fork (arch/x86/entry/entry_64.S:300) > [ 9.846531] ---[ end trace 8b5647c1eba9d18a ]--- > > The problem occurs because in the non-hierarchical mode non-root page > counters are not linked to root page counters, so the charge is not > propagated to the root memory cgroup. > > After the removal of the original memory cgroup and reparenting of the > object cgroup, the root cgroup might be uncharged by draining a objcg > stock, for example. It leads to an eventual underflow of the charge > and triggers a warning. > > Fix it by linking all page counters to corresponding root page > counters in the non-hierarchical mode. > > The patch doesn't affect how the hierarchical mode is working, > which is the only sane and truly supported mode now. > > Thanks to Richard for reporting, debugging and providing an > alternative version of the fix! > > Reported-by: ltp@lists.linux.it > Debugged-by: Richard Palethorpe > Fixes: bf4f059954dc ("mm: memcg/slab: obj_cgroup API") > Signed-off-by: Roman Gushchin > Cc: stable@vger.kernel.org Acked-by: Johannes Weiner