From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D16C388F7 for ; Sun, 25 Oct 2020 14:17:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 172B422269 for ; Sun, 25 Oct 2020 14:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nryzDadH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 172B422269 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 133166B005D; Sun, 25 Oct 2020 10:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 109F96B0062; Sun, 25 Oct 2020 10:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3AC76B0068; Sun, 25 Oct 2020 10:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id C0DF66B005D for ; Sun, 25 Oct 2020 10:17:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 49ABC8249980 for ; Sun, 25 Oct 2020 14:17:13 +0000 (UTC) X-FDA: 77410649946.12.level27_140382f2726b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 2B09D18004A1F for ; Sun, 25 Oct 2020 14:17:13 +0000 (UTC) X-HE-Tag: level27_140382f2726b X-Filterd-Recvd-Size: 2657 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sun, 25 Oct 2020 14:17:12 +0000 (UTC) Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15CD422226; Sun, 25 Oct 2020 14:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603635431; bh=CoHyOzDXRIyiI8+Y6QIv52+Qp9AQ46O3BTgdQ1ZDXxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nryzDadHK6eET9ANsik9TzVfAC9A0ShBYEgfmKa8JGuLUZ/cy2wfrc34n8Ga/f2AH yjKpaRiwL9lUuhYQNq1r5UjAIC4knRz6S4MvU1HHEn53/Yd1qX6zpCcO50RWKADBTh VKex//kiVso1nBAVdI+CHCzeaE8N6BJYxwyFpi78= Date: Sun, 25 Oct 2020 16:17:04 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Michal Hocko Subject: Re: [PATCH v2 1/7] mm, page_alloc: clean up pageset high and batch update Message-ID: <20201025141704.GG392079@kernel.org> References: <20201008114201.18824-1-vbabka@suse.cz> <20201008114201.18824-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008114201.18824-2-vbabka@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 08, 2020 at 01:41:55PM +0200, Vlastimil Babka wrote: > The updates to pcplists' high and batch valued are handled by multiple Nit: ^ values > functions that make the calculations hard to follow. Consolidate everything > to pageset_set_high_and_batch() and remove pageset_set_batch() and > pageset_set_high() wrappers. > > The only special case using one of the removed wrappers was: > build_all_zonelists_init() > setup_pageset() > pageset_set_batch() > which was hardcoding batch as 0, so we can just open-code a call to > pageset_update() with constant parameters instead. > > No functional change. > > Signed-off-by: Vlastimil Babka > Reviewed-by: Oscar Salvador > Reviewed-by: David Hildenbrand > Acked-by: Michal Hocko > --- > mm/page_alloc.c | 49 ++++++++++++++++++++----------------------------- > 1 file changed, 20 insertions(+), 29 deletions(-) -- Sincerely yours, Mike.