* [PATCH] mm/page-flags: Fix comment
@ 2020-10-27 2:58 Matthew Wilcox (Oracle)
2020-10-27 13:51 ` William Kucharski
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox (Oracle) @ 2020-10-27 2:58 UTC (permalink / raw)
To: linux-mm; +Cc: Matthew Wilcox (Oracle)
We haven't had 'dontuse' flags since 2002. Replace this obsolete
warning with a hopefully more useful one.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/page-flags.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 0d3402517e43..1a41ff36907b 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -86,8 +86,7 @@
*/
/*
- * Don't use the *_dontuse flags. Use the macros. Otherwise you'll break
- * locked- and dirty-page accounting.
+ * Don't use the pageflags directly. Use the PageFoo macros.
*
* The page flags field is split into two parts, the main flags area
* which extends from the low bits upwards, and the fields area which
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/page-flags: Fix comment
2020-10-27 2:58 [PATCH] mm/page-flags: Fix comment Matthew Wilcox (Oracle)
@ 2020-10-27 13:51 ` William Kucharski
0 siblings, 0 replies; 2+ messages in thread
From: William Kucharski @ 2020-10-27 13:51 UTC (permalink / raw)
To: Matthew Wilcox (Oracle); +Cc: linux-mm
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> On Oct 26, 2020, at 8:58 PM, Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
>
> We haven't had 'dontuse' flags since 2002. Replace this obsolete
> warning with a hopefully more useful one.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/page-flags.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 0d3402517e43..1a41ff36907b 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -86,8 +86,7 @@
> */
>
> /*
> - * Don't use the *_dontuse flags. Use the macros. Otherwise you'll break
> - * locked- and dirty-page accounting.
> + * Don't use the pageflags directly. Use the PageFoo macros.
> *
> * The page flags field is split into two parts, the main flags area
> * which extends from the low bits upwards, and the fields area which
> --
> 2.28.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 2:58 [PATCH] mm/page-flags: Fix comment Matthew Wilcox (Oracle)
2020-10-27 13:51 ` William Kucharski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).