From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB048C55178 for ; Thu, 29 Oct 2020 09:08:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C62D20780 for ; Thu, 29 Oct 2020 09:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="jhHChYEG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C62D20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 568586B0062; Thu, 29 Oct 2020 05:08:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 518196B0068; Thu, 29 Oct 2020 05:08:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406EF6B006C; Thu, 29 Oct 2020 05:08:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 13FE56B0062 for ; Thu, 29 Oct 2020 05:08:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9FB3883F6 for ; Thu, 29 Oct 2020 09:08:09 +0000 (UTC) X-FDA: 77424386298.30.blow83_200d1e42728c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 64662180B3AA7 for ; Thu, 29 Oct 2020 09:08:09 +0000 (UTC) X-HE-Tag: blow83_200d1e42728c X-Filterd-Recvd-Size: 2361 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 09:08:08 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603962487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pRfvIcEC60eWRFi87by9E7+LFhlD5mHOp4kKoOmBQUI=; b=jhHChYEGIqkgyrVF2bZZDAP9fShBJKnw5Z76v7XG/lfKacRenW4EL4SRGC/eZd1qasjwS2 cXgAP3eIkMrcSCfouk1jFCJmAe+jJ4WKqCfQbzrt+J4qDoDjNaVak+cdilW0CbujdHb2DS S50daeUjnIvhpfapMjy5qa/SKRtIe58= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A0EDAB2CF; Thu, 29 Oct 2020 09:08:07 +0000 (UTC) Date: Thu, 29 Oct 2020 10:08:06 +0100 From: Michal Hocko To: Muchun Song Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, iamjoonsoo.kim@lge.com, laoar.shao@gmail.com, chris@chrisdown.name, christian.brauner@ubuntu.com, peterz@infradead.org, mingo@kernel.org, keescook@chromium.org, tglx@linutronix.de, esyr@redhat.com, surenb@google.com, areber@redhat.com, elver@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Message-ID: <20201029090806.GD17500@dhcp22.suse.cz> References: <20201028035013.99711-1-songmuchun@bytedance.com> <20201028035013.99711-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028035013.99711-4-songmuchun@bytedance.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 28-10-20 11:50:13, Muchun Song wrote: [...] > -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) > +static struct lruvec * > +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat, > + int nid) I thought I have made it clear that this is not a good approach. Please do not repost new version without that being addressed. If there are any questions then feel free to ask for details. -- Michal Hocko SUSE Labs