From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1998AC55179 for ; Thu, 29 Oct 2020 13:45:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7487420838 for ; Thu, 29 Oct 2020 13:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="BqZ2R2ie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7487420838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D69AF6B0074; Thu, 29 Oct 2020 09:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D18226B0075; Thu, 29 Oct 2020 09:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2E436B0078; Thu, 29 Oct 2020 09:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 954BB6B0074 for ; Thu, 29 Oct 2020 09:45:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 29F108249980 for ; Thu, 29 Oct 2020 13:45:32 +0000 (UTC) X-FDA: 77425085304.22.lift89_2b0645e2728d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id DFF6318038E67 for ; Thu, 29 Oct 2020 13:45:31 +0000 (UTC) X-HE-Tag: lift89_2b0645e2728d X-Filterd-Recvd-Size: 4209 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 13:45:30 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id q25so3452576ioh.4 for ; Thu, 29 Oct 2020 06:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lMVsDoZ2rvYhRouYTnsQqKObuVh6EX/L2Iet4zmcg+0=; b=BqZ2R2ieXOiIyfj4R06JqpmwkZDKmSom+oB6s4vJ3gT+gZ0OND8K/gSscTX2Ax4YSL th+NpS/aAW9WU9gUbnUk6J2t8Tp6ot3gvUb+/Wqxbmh9oVvb4neSwLThNjXM4j2yFQUg Zt/qaKVHiCUkE6S2dy0ZLkpZ7hAoJZTPQ9hb2rwV67DMknJ8A1iSh8jHBADKov09dNWG wUL46gT3QRe9y0P/5t0OhMkwqxX8F/m+Py4topxcn5Ws8DywxAPZ/2FzlE6cx4EpvU/8 XPEiPhhjlKLee4syFyTA3ZhySwdIZlKRhkhJCAVIDBlBVvgErA68e84xR75aHFHvDqiv lo/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lMVsDoZ2rvYhRouYTnsQqKObuVh6EX/L2Iet4zmcg+0=; b=H9s3vQFSr/LAVbkljdaPTohqY4gVLMZ/NdfoE6VnsDyf6LHbdsckmwNRZKgNuDitNR cJl71LniebsgxaF+R6LT0CLS/CGrSesx2k0yJ+jgP62NzAJ6TSDAOwlVkQmcvhK9o+yi YmcOzHqWLTk8kPiiy24ho0VwT6TrM+XJgWjbOes7aC/KyoRBSEUHmNTlVyKZ1uYSC8Qh zSS8prG+dky0D+E9fjjI61uTmi/eJFbahCyg7kD6XBGXEPF+eq+FdamuXqgFGvSZCsib iw4yNfKVlrkcOsETnyraEoPVU8PK5edh6h296/JfhMvBkfdOQSOE+GIlwd3JpeqY5TCC 5fLA== X-Gm-Message-State: AOAM532GBzVxhY4KNh6K+KT/+nR1q2lGa0dn1Q+mgmZp4GbKSZ/HfKi4 yFZA8XFuGLB3+u4K+1chLEwmPg== X-Google-Smtp-Source: ABdhPJw/UxKZenF/5zce1bBQYI8Jab+fyaFmZKutTSonAjsrtKq4WJ82S4BHxXpvNmFvbfxO1fy6zA== X-Received: by 2002:a5d:8987:: with SMTP id m7mr3494563iol.20.1603979130469; Thu, 29 Oct 2020 06:45:30 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:536c]) by smtp.gmail.com with ESMTPSA id c13sm2352228ild.68.2020.10.29.06.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 06:45:29 -0700 (PDT) Date: Thu, 29 Oct 2020 09:43:46 -0400 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko Subject: Re: [PATCH v20 01/20] mm/memcg: warning on !memcg after readahead page charged Message-ID: <20201029134346.GB599825@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-2-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-2-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:46PM +0800, Alex Shi wrote: > Add VM_WARN_ON_ONCE_PAGE() macro. > > Since readahead page is charged on memcg too, in theory we don't have to > check this exception now. Before safely remove them all, add a warning > for the unexpected !memcg. > > Signed-off-by: Alex Shi > Acked-by: Michal Hocko > Acked-by: Hugh Dickins > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner