From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8362CC4742C for ; Sun, 1 Nov 2020 19:51:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D347522254 for ; Sun, 1 Nov 2020 19:51:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YChnSI6T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D347522254 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0790E6B005C; Sun, 1 Nov 2020 14:51:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 028B96B005D; Sun, 1 Nov 2020 14:51:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E32B56B0068; Sun, 1 Nov 2020 14:51:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id B34AB6B005C for ; Sun, 1 Nov 2020 14:51:14 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4BFC11EE6 for ; Sun, 1 Nov 2020 19:51:14 +0000 (UTC) X-FDA: 77436893268.10.fork56_3015663272aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 2B41916A4A5 for ; Sun, 1 Nov 2020 19:51:14 +0000 (UTC) X-HE-Tag: fork56_3015663272aa X-Filterd-Recvd-Size: 4954 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 19:51:13 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id s14so9780995qkg.11 for ; Sun, 01 Nov 2020 11:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rP4RExhHTYjlWl4BZb+1QvcI7StDkyRruWGLjrqa6uc=; b=YChnSI6Tw2pTGusfkNu7VS+a4Sx5U3iM0cPnYqIXOLKnhRtCIjpUDiNiveLgYPLuvl sCi4LmvSUnMOt/Ufkwba60ysz0m6Mga0Fg5ehiBXb1cDz2vukAgUdK4kUbyr/FydI0C0 1iVOZkpLZZYeTB7akP2q4qS8EdmPAqmBsqbkwugc4tOaJZXHZUbA4kJFRI+7uROwR/zu feIg0PeS+Mr8gKH+kHggh749aW1IeH640fvEd8KrjPzMOiOyWe2EK1xbjR3lubFYouMY J6t9XtrlU3OcA4e4DBFnboplMDoSbEdJRKD/N4h7aMGbd1kIeUt2MzF21/vRUkBHRQ3N PfJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=rP4RExhHTYjlWl4BZb+1QvcI7StDkyRruWGLjrqa6uc=; b=lsBKl4vIZsqsP+OMNFeAPh3HdH7o/1S5t+R+Tv0WKym1BC9EkPNetkMqSphAttEXzC H2OH2uL3BZQoBLlIR8PDjMcY6MIQmlUX+/XYp7BgRqxuqVTBA/gS1VFQuPbh2zmHwXhW 6GJj/C7rFFwvx9tGbkt+TKksMIZP+6I0TjMIb1dEWH5uHlaLKBAQBToeZ8GU6cnKzQhN ftHvEq3VPzUTq78OpIXKOxnqAcXYm62lT61xZhkazhcbjN6l4otoxoTZj3Vo+wUVjeVU 6EZf7/rhLPZWfpQDB+S4q2zWq/tjDCBEjDb3p4n9vpuQPWlCTjLYgowl25x094yjNaIq snvg== X-Gm-Message-State: AOAM532SNe3p56nyDOu0xJ/ljjFI+VyO7dSBpOI7lgwIorrJz/J8bKMF ueMvQwjfbgpakKG2KRdLTFc= X-Google-Smtp-Source: ABdhPJx+ifDmpgyyLCcnlEBQbmbvy6OCcXunBnW7zvX3xJcgaACeRGp7YQaxJi3Cyf3ExpE47GXSgw== X-Received: by 2002:a05:620a:15b1:: with SMTP id f17mr11400784qkk.54.1604260273055; Sun, 01 Nov 2020 11:51:13 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id t8sm6576061qtb.97.2020.11.01.11.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Nov 2020 11:51:12 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sun, 1 Nov 2020 14:51:10 -0500 To: Matthew Wilcox Cc: Arvind Sankar , kernel test robot , linux-next@vger.kernel.org, Stephen Rothwell , kbuild-all@lists.01.org, Linux Memory Management List , Nick Desaulniers , Kees Cook , Andrew Morton , stable@vger.kernel.org, Masahiro Yamada Subject: Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h Message-ID: <20201101195110.GA1751707@rani.riverdale.lan> References: <202010312104.Dk9VQJYb-lkp@intel.com> <20201101173105.1723648-1-nivedita@alum.mit.edu> <20201101173835.GC27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201101173835.GC27442@casper.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.001677, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 01, 2020 at 05:38:35PM +0000, Matthew Wilcox wrote: > On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote: > > Commit > > b9de06783f01 ("compiler.h: fix barrier_data() on clang") > > moved the definition of barrier() into compiler.h. > > That's not a real commit ID. It only exists in linux-next and > will expire after a few weeks. > > The right way to fix a patch in Andrew's tree is to send an email > asking him to apply it as a -fix patch. As part of Andrew's submission > process, he folds all the -fix patches into the parent patch and it > shows up pristine in Linus' tree. Ok. So I still send it as a separate patch and he does the folding, or should I send a revised patch that replaces the original one? > > > This causes build failures at least on alpha, because there are files > > that rely on barrier() being defined via the implicit include of > > compiler_types.h. > > That seems like a bug that should be fixed rather than reverting this > part of the patch? > I thought about that, but barrier() is used in a large number of places, so reverting seemed like the safer approach, in case more errors like this cropped up. I don't know if it's a bug, as it was defined in compiler_types.h before my original patch, I'm not sure if there's a reason only compiler_types.h rather than compiler.h is implicitly included via the Makefile. Cc'ing Masahiro Yamada in case he has comments on that part. Thanks.