From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10EFC2D0A3 for ; Sun, 1 Nov 2020 20:48:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD49F21527 for ; Sun, 1 Nov 2020 20:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RdFWirAa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD49F21527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B2586B006E; Sun, 1 Nov 2020 15:48:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 362196B0072; Sun, 1 Nov 2020 15:48:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2505D6B0073; Sun, 1 Nov 2020 15:48:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 116846B006E for ; Sun, 1 Nov 2020 15:48:41 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C2D84181AEF10 for ; Sun, 1 Nov 2020 20:48:40 +0000 (UTC) X-FDA: 77437038000.11.feast03_0810d8b272aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 9E819180F8B80 for ; Sun, 1 Nov 2020 20:48:40 +0000 (UTC) X-HE-Tag: feast03_0810d8b272aa X-Filterd-Recvd-Size: 2900 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 20:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HK4WJIQcNc1wsi9NV2soETQrxP57kXJKoEvFH6iI7xo=; b=RdFWirAaAzJbvECzZLuajNCNf3 +A89JNuVRkXwrDW22v1vju3Be479QAkuaO88OqZbqFfnp41ubc55jK7LrLI+kmT5wBzIEaeyaAnWW ePS7ZxysA7YlnnS360EEQAFqtzsH6UiUdXJPjSu0bRoQhhzq6M5SkDjudbfRRfO9xTvGIpT9T+pfw +74ZJGTaL598+hUQg47fdgavCiLfYk0gIZ3bcxZanzS7AB3E3rcl5riNGzaql8255sM1/a+t39V5t uQFJZkfzOapdqT+6RKHHGqMBoJ/waTyhLl+DPUWtdjqOLzvETO4tnSmnV3k2LRK3UwZS1zh1mYi3E rbAjQ+7Q==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZKHC-0003Fp-9Q; Sun, 01 Nov 2020 20:48:34 +0000 Date: Sun, 1 Nov 2020 20:48:34 +0000 From: Matthew Wilcox To: Joe Perches Cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] mm: shmem: Convert shmem_enabled_show to use sysfs_emit_at Message-ID: <20201101204834.GF27442@casper.infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 01, 2020 at 12:12:51PM -0800, Joe Perches wrote: > @@ -4024,7 +4024,7 @@ int __init shmem_init(void) > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && defined(CONFIG_SYSFS) > static ssize_t shmem_enabled_show(struct kobject *kobj, > - struct kobj_attribute *attr, char *buf) > + struct kobj_attribute *attr, char *buf) > { > static const int values[] = { > SHMEM_HUGE_ALWAYS, Why? > @@ -4034,16 +4034,19 @@ static ssize_t shmem_enabled_show(struct kobject *kobj, > SHMEM_HUGE_DENY, > SHMEM_HUGE_FORCE, > }; > - int i, count; > - > - for (i = 0, count = 0; i < ARRAY_SIZE(values); i++) { > - const char *fmt = shmem_huge == values[i] ? "[%s] " : "%s "; > + int len = 0; > + int i; Better: int i, len = 0; > - count += sprintf(buf + count, fmt, > - shmem_format_huge(values[i])); > + for (i = 0; i < ARRAY_SIZE(values); i++) { > + len += sysfs_emit_at(buf, len, > + shmem_huge == values[i] ? "%s[%s]" : "%s%s", > + i ? " " : "", > + shmem_format_huge(values[i])); This is ... complicated. I thought the point of doing all the sysfs_emit stuff was to simplify things.