From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DF8C4742C for ; Mon, 2 Nov 2020 15:15:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AAD4921D91 for ; Mon, 2 Nov 2020 15:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tYvaG/9d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAD4921D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A6BD6B0070; Mon, 2 Nov 2020 10:15:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 157D76B0071; Mon, 2 Nov 2020 10:15:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01F406B0072; Mon, 2 Nov 2020 10:15:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id C71386B0070 for ; Mon, 2 Nov 2020 10:15:42 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 59489181AC9CC for ; Mon, 2 Nov 2020 15:15:42 +0000 (UTC) X-FDA: 77439827724.23.snake44_3400eac272b1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 1D1933760C for ; Mon, 2 Nov 2020 15:15:41 +0000 (UTC) X-HE-Tag: snake44_3400eac272b1 X-Filterd-Recvd-Size: 4000 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 15:15:39 +0000 (UTC) Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30D5B21556; Mon, 2 Nov 2020 15:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604330137; bh=HUTlle6eGdFGRRBi2JxylJ6R01dvNLPTF9EEu8JnDzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tYvaG/9dInW01K1TdO7aN/JE/ddj5YkjOdNNg69Vx3IMO/KyPHo+L3t750XHeB7cy 9nHtZ/YgWXPmU7Jf3+rHocYXndpyDvstMLn2JsE5CdJ3oN4Ef/dmiDi3mtetYWFv3p XYQkck9tVbbZ/n1Alyl03sGboOgOce0/AdowI7CE= Date: Mon, 2 Nov 2020 17:15:24 +0200 From: Mike Rapoport To: David Hildenbrand Cc: Andrew Morton , Albert Ou , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Christian Borntraeger , Christoph Lameter , "David S. Miller" , Dave Hansen , David Rientjes , "Edgecombe, Rick P" , "H. Peter Anvin" , Heiko Carstens , Ingo Molnar , Joonsoo Kim , "Kirill A. Shutemov" , Len Brown , Michael Ellerman , Mike Rapoport , Palmer Dabbelt , Paul Mackerras , Paul Walmsley , Pavel Machek , Pekka Enberg , Peter Zijlstra , "Rafael J. Wysocki" , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 3/4] arch, mm: restore dependency of __kernel_map_pages() of DEBUG_PAGEALLOC Message-ID: <20201102151524.GB4879@kernel.org> References: <20201101170815.9795-1-rppt@kernel.org> <20201101170815.9795-4-rppt@kernel.org> <8eac2aa4-114e-f981-c8f8-ad8523175cf8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8eac2aa4-114e-f981-c8f8-ad8523175cf8@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 02, 2020 at 10:23:20AM +0100, David Hildenbrand wrote: > > > int __init kernel_map_pages_in_pgd(pgd_t *pgd, u64 pfn, unsigned long address, > > unsigned numpages, unsigned long page_flags) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 14e397f3752c..ab0ef6bd351d 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2924,7 +2924,11 @@ static inline bool debug_pagealloc_enabled_static(void) > > return static_branch_unlikely(&_debug_pagealloc_enabled); > > } > > -#if defined(CONFIG_DEBUG_PAGEALLOC) || defined(CONFIG_ARCH_HAS_SET_DIRECT_MAP) > > +#ifdef CONFIG_DEBUG_PAGEALLOC > > +/* > > + * To support DEBUG_PAGEALLOC architecture must ensure that > > + * __kernel_map_pages() never fails > > Maybe add here, that this implies mapping everything via PTEs during boot. This is more of an implementation detail, while assumption that __kernel_map_pages() does not fail is somewhat a requirement :) > Acked-by: David Hildenbrand Thanks! > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.