From: Roman Gushchin <guro@fb.com> To: Michal Hocko <mhocko@suse.com> Cc: "Johannes Weiner" <hannes@cmpxchg.org>, "Michal Koutný" <mkoutny@suse.com>, "Richard Palethorpe" <rpalethorpe@suse.com>, ltp@lists.linux.it, "Andrew Morton" <akpm@linux-foundation.org>, "Shakeel Butt" <shakeelb@google.com>, "Christoph Lameter" <cl@linux.com>, "Tejun Heo" <tj@kernel.org>, "Vlastimil Babka" <vbabka@suse.cz>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root Date: Tue, 3 Nov 2020 13:30:10 -0800 Message-ID: <20201103213010.GA1938922@carbon.dhcp.thefacebook.com> (raw) In-Reply-To: <20201103132221.GI21990@dhcp22.suse.cz> On Tue, Nov 03, 2020 at 02:22:21PM +0100, Michal Hocko wrote: > Hi, > I am sorry but I was quite busy at the time this has been discussed. > Now that I got to this thread finally I am wondering whether this > resp. other root cgroup exceptions have any follow up. I'll address a feedback I've got from Johannes and will post and updated version soon. > > I have seen the issue is fixed in Linus tree by 8de15e920dc8 ("mm: > memcg: link page counters to root if use_hierarchy is false"). Thanks > for taking care of that! I do agree that this approach is the most > reasonable immediate fix. Thanks! > > Btw. we have been carrying a warning about non hierarchical hierarchies > for years in our distribution kernels and haven't heard of any actual > bug reports (except for LTP driven ones). So we might be really close to > simply drop this functionality completely. This would simplify the code > and prevent from future surprises. Just sent an rfc patchset. Your feedback will be greatly appreciated! Thanks!
next prev parent reply index Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 19:07 Richard Palethorpe 2020-10-14 20:08 ` Roman Gushchin 2020-10-16 5:40 ` Richard Palethorpe 2020-10-16 9:47 ` Michal Koutný 2020-10-16 10:41 ` Richard Palethorpe 2020-10-16 15:05 ` Richard Palethorpe 2020-10-16 17:26 ` Michal Koutný 2020-10-16 14:53 ` Johannes Weiner 2020-10-16 17:02 ` Roman Gushchin 2020-10-16 17:15 ` Michal Koutný 2020-10-19 8:45 ` Richard Palethorpe 2020-10-19 9:58 ` [PATCH v3] " Richard Palethorpe 2020-10-19 16:58 ` Shakeel Butt 2020-10-20 5:52 ` Richard Palethorpe 2020-10-20 13:49 ` Richard Palethorpe 2020-10-20 16:56 ` Shakeel Butt 2020-10-21 20:32 ` Roman Gushchin 2020-10-20 17:24 ` Michal Koutný 2020-10-22 7:04 ` Richard Palethorpe 2020-10-22 12:28 ` [PATCH v4] " Richard Palethorpe 2020-10-22 16:37 ` Shakeel Butt 2020-10-22 17:25 ` Roman Gushchin 2020-10-22 23:59 ` Shakeel Butt 2020-10-23 0:40 ` Roman Gushchin 2020-10-23 15:44 ` Johannes Weiner 2020-10-23 16:41 ` Shakeel Butt 2020-10-26 7:32 ` Richard Palethorpe 2020-10-26 23:14 ` Roman Gushchin 2020-10-19 22:28 ` [RFC PATCH] " Roman Gushchin 2020-10-20 6:04 ` Richard Palethorpe 2020-10-20 12:02 ` Richard Palethorpe 2020-10-20 14:48 ` Richard Palethorpe 2020-10-20 16:27 ` Michal Koutný 2020-10-20 17:07 ` Roman Gushchin 2020-10-20 18:18 ` Johannes Weiner 2020-10-21 19:33 ` Roman Gushchin 2020-10-23 16:30 ` Johannes Weiner 2020-11-10 1:27 ` Roman Gushchin 2020-11-10 15:11 ` Shakeel Butt 2020-11-10 19:13 ` Roman Gushchin 2020-11-20 17:46 ` Michal Koutný 2020-11-03 13:22 ` Michal Hocko 2020-11-03 21:30 ` Roman Gushchin [this message] 2020-10-20 16:55 ` Shakeel Butt 2020-10-20 17:17 ` Roman Gushchin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201103213010.GA1938922@carbon.dhcp.thefacebook.com \ --to=guro@fb.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux.com \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=ltp@lists.linux.it \ --cc=mhocko@suse.com \ --cc=mkoutny@suse.com \ --cc=rpalethorpe@suse.com \ --cc=shakeelb@google.com \ --cc=tj@kernel.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ linux-mm@kvack.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git