From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F538C2D0A3 for ; Wed, 4 Nov 2020 17:01:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 961FB20735 for ; Wed, 4 Nov 2020 17:01:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="ES+N8651" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 961FB20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97B8D6B005D; Wed, 4 Nov 2020 12:01:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92C696B0068; Wed, 4 Nov 2020 12:01:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F61C6B006E; Wed, 4 Nov 2020 12:01:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 4FA136B005D for ; Wed, 4 Nov 2020 12:01:27 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C7F9E362D for ; Wed, 4 Nov 2020 17:01:26 +0000 (UTC) X-FDA: 77447351772.16.chalk56_2a07692272c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 205B7100E6932 for ; Wed, 4 Nov 2020 17:01:24 +0000 (UTC) X-HE-Tag: chalk56_2a07692272c2 X-Filterd-Recvd-Size: 3944 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 17:01:22 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id x20so19955396qkn.1 for ; Wed, 04 Nov 2020 09:01:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=etqFAurUJDSd19LJRgQeMrJKrf7mPzvCgyUjOeBZwDk=; b=ES+N86515B56XodKDYWHJ6tTw+f4nct5ajluD4TsKqk6ihVSOr3ho3WXDMqBsc1nH6 k08i2yVKNfYWndRFpSgEOLsmfnjHftjDfID7V/1kviFzkyAXE4cSwlspsMdANTYqCrhF uTIjSURiPNH3jNp0zyCLAnL7z0A6cYHNx8sFjmGuJtUj6+xy/zRrWzAX8lql8mBtIDb9 dm5TvYpbBO8y9H+NI4o+Tp2FaBP4aWVkM3LxevBq0q0WwhB/Mc1gAGvcj0Q405XUs1Ly WVZSd6WgDkmEuy0DpgwhI9qDKyKkYSlR+XBiZ7AVLZxpWup5vJfx/cNJuYMoaS5wQ124 SHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=etqFAurUJDSd19LJRgQeMrJKrf7mPzvCgyUjOeBZwDk=; b=iKE8VVu7rbL96ZGMmAbXMy+1hZK+UpSDgnA3pmZm8fzNivvMmLGDIAaUexKVPL2r4F ii869EopaY0zOmAgXIMhHpjWbFH8kUrSOhGPbqGeBKrwPtfm/gQ9/Dkfb6wLFGpYIzRP BkFub13G0mqi2dcP0uutmfdmOmZKXdllV5UeySv8e6Y+lz1gxnoUs7rCg0+GInYnE7kY H7U+0MlHds4JvHDSMVCs1kxK68gngKR91BF6OWs4y+jyaLOxLGKDbxJozOk6zFldS74N 67JFsJtpNFRyJVFtwEens3v40JG3ge4gqXt66p2qK0fnmZ+1vdijnrXWYg3zd5w1jkk9 G6iQ== X-Gm-Message-State: AOAM531zz/Bw/75YB7DVcLO8AI+jijJu2JS/r5WFdixp3CT8URSwKF89 iw626rxLGBEwwYvYSEV98tmVAg== X-Google-Smtp-Source: ABdhPJy4ELJ5A+0c+aiIpO/0PWwqwBfJHYTp6Wgubcwb0Sa+XPFIikhEv/wbMn4Qpk4k3eOwTOnkeA== X-Received: by 2002:a37:ef05:: with SMTP id j5mr27458100qkk.223.1604509281779; Wed, 04 Nov 2020 09:01:21 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:9e9e]) by smtp.gmail.com with ESMTPSA id m6sm2796993qki.112.2020.11.04.09.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 09:01:20 -0800 (PST) Date: Wed, 4 Nov 2020 11:59:35 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 00/20] per memcg lru lock Message-ID: <20201104165935.GA744831@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <811216d4-4972-4721-d6b9-1028c02f4290@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <811216d4-4972-4721-d6b9-1028c02f4290@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.007385, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 04, 2020 at 07:55:39PM +0800, Alex Shi wrote: > @@ -1380,6 +1383,14 @@ struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgd > return lruvec; > } > > +/** > + * lock_page_lruvec - return lruvec for the locked page. I would say "lock and return the lruvec for a given page" > + * @page: the page > + * > + * This series functions should be used in either conditions: > + * PageLRU is cleared or unset > + * or, page->_refcount is zero or page is locked The other changes look good to me, thanks!