From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7830C55178 for ; Fri, 6 Nov 2020 08:20:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EA83208B3 for ; Fri, 6 Nov 2020 08:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA83208B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C0F06B005C; Fri, 6 Nov 2020 03:20:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 971436B005D; Fri, 6 Nov 2020 03:20:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D65B6B0068; Fri, 6 Nov 2020 03:20:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 640C66B005C for ; Fri, 6 Nov 2020 03:20:00 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0C048180AD80F for ; Fri, 6 Nov 2020 08:20:00 +0000 (UTC) X-FDA: 77453295360.28.smell50_340e021272d1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id DB2CF6D66 for ; Fri, 6 Nov 2020 08:19:59 +0000 (UTC) X-HE-Tag: smell50_340e021272d1 X-Filterd-Recvd-Size: 1209 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 08:19:59 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AEF7368B05; Fri, 6 Nov 2020 09:19:56 +0100 (CET) Date: Fri, 6 Nov 2020 09:19:56 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v2 14/18] mm/filemap: Split filemap_readahead out of filemap_get_pages Message-ID: <20201106081956.GH31585@lst.de> References: <20201104204219.23810-1-willy@infradead.org> <20201104204219.23810-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104204219.23810-15-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > if (PageReadahead(page)) { > + err = filemap_readahead(iocb, filp, mapping, page, > + last_index); > + if (err) { > pvec->nr--; > goto err; > } Not really new in this patch, but don't we need to drop the page refcount here?