From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC80FC388F2 for ; Fri, 6 Nov 2020 08:21:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 669B020A8B for ; Fri, 6 Nov 2020 08:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 669B020A8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE22F6B006E; Fri, 6 Nov 2020 03:21:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6A596B0070; Fri, 6 Nov 2020 03:21:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5A346B0074; Fri, 6 Nov 2020 03:21:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 79A6B6B006E for ; Fri, 6 Nov 2020 03:21:55 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 22D9A8249980 for ; Fri, 6 Nov 2020 08:21:55 +0000 (UTC) X-FDA: 77453300190.10.glass82_44125a6272d1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id F132616A0DE for ; Fri, 6 Nov 2020 08:21:54 +0000 (UTC) X-HE-Tag: glass82_44125a6272d1 X-Filterd-Recvd-Size: 1437 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 08:21:54 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7619E68B05; Fri, 6 Nov 2020 09:21:52 +0100 (CET) Date: Fri, 6 Nov 2020 09:21:52 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@lst.de, kent.overstreet@gmail.com Subject: Re: [PATCH v2 16/18] mm/filemap: Don't relock the page after calling readpage Message-ID: <20201106082152.GJ31585@lst.de> References: <20201104204219.23810-1-willy@infradead.org> <20201104204219.23810-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104204219.23810-17-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 04, 2020 at 08:42:17PM +0000, Matthew Wilcox (Oracle) wrote: > We don't need to get the page lock again; we just need to wait for > the I/O to finish, so use wait_on_page_locked_killable() like the > other callers of ->readpage. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Kent Overstreet Looks good, Reviewed-by: Christoph Hellwig although I still think a little comment would not hurt.