From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055F2C4741F for ; Fri, 6 Nov 2020 22:59:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60A4B2072E for ; Fri, 6 Nov 2020 22:59:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PLQlbnYD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60A4B2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB86C6B005C; Fri, 6 Nov 2020 17:59:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6A436B006E; Fri, 6 Nov 2020 17:59:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97F0C6B0070; Fri, 6 Nov 2020 17:59:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 66FA96B005C for ; Fri, 6 Nov 2020 17:59:21 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 12545362C for ; Fri, 6 Nov 2020 22:59:21 +0000 (UTC) X-FDA: 77455511322.10.cord24_460809f272d6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id EC09716A0DE for ; Fri, 6 Nov 2020 22:59:20 +0000 (UTC) X-HE-Tag: cord24_460809f272d6 X-Filterd-Recvd-Size: 5176 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 22:59:20 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id u4so2107864pgr.9 for ; Fri, 06 Nov 2020 14:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lPzksUR9ZyZwSsQ8tnKwK0p0kGK7K1utClt0jJk/L8I=; b=PLQlbnYDD6tHrqH2zfCgx9joRW/t6JIVQKXStdygoYx0y1YGrmnpXvFDJZPyKbNlxc oMpQ6KCY2VhlJ4ozLKpr0nFQn+yQiQfYtwLauMc0h3Wx6yL4xbrpdLJZTJAtHkIOKLDd vS4yiBJWcxc/R5K0T8Rs4kB0vTLEIVE6d2SIFAZut2XjrHgha0xLUvzjnyK0qGDUL8Ed Onqpa1Ara4s9pyDAslidDQg8HhncryPu8J/EeVl/693fshl+M29eLlo181YOFNvIQ5ym y0RX4tTwaUDpGDHpqlyh3CpXm0qakig9E9iqhx6AvjgWfrk5cuFhvfKLhvSCIL6pGDnW P+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=lPzksUR9ZyZwSsQ8tnKwK0p0kGK7K1utClt0jJk/L8I=; b=FJJ/+BpGQJu6ho3TD1hDwmjRrQljyDsvXGIYSAcLseUIiN5lLUXvHEd3QInaSvI2Sm ODSPphCdgcjsCCSV2+RtRql1Hpv46LF7prZkpZ+MrSbJ10o08reU47nyqecZMiZL2f3m qG74szckC6kzz1r6XlP2TswS2v+UyGNOdpizdJeGzvkAt552f4weAcQh1BmZDkHwbbQE OUM/NRg21bZzpMjhF5uodSIdzsQiyUqZfAFDcQd34rlMnKJtQOIsFJ+ome9ACM+DxiNc KjRmDZ+AAYtY1WHUgirjjFGbE13vG76lFj8aKa5Sq51KRukzG6u8zHf38oEFaSnQI+27 ASCA== X-Gm-Message-State: AOAM5305DwEdqSXU+0kfN7a+H+0h7Vwkph6M+pHO8zV6/zSgom8zWx9B emOJWtyCYig4xqXGVrb4q4I= X-Google-Smtp-Source: ABdhPJxx2uc6cJXbM/n0hMuIvPfZ+Ku4/iGm9oaaJFo7H4nBel3IiiCzmB5eVGVWTUG3Tr3iIWCu6w== X-Received: by 2002:a17:90b:93:: with SMTP id bb19mr1899256pjb.102.1604703559474; Fri, 06 Nov 2020 14:59:19 -0800 (PST) Received: from google.com ([2620:15c:211:201:7220:84ff:fe09:5e58]) by smtp.gmail.com with ESMTPSA id g7sm3643399pjl.11.2020.11.06.14.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 14:59:17 -0800 (PST) Date: Fri, 6 Nov 2020 14:59:16 -0800 From: Minchan Kim To: Randy Dunlap Cc: Andrew Morton , LKML , linux-mm , Michal Hocko Subject: Re: [PATCH] mm: introduce oom_kill_disable sysctl knob Message-ID: <20201106225916.GA1383786@google.com> References: <20201106203238.1375577-1-minchan@kernel.org> <57a31f2e-bb08-7303-e5fc-fe00e832cee6@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57a31f2e-bb08-7303-e5fc-fe00e832cee6@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 12:46:47PM -0800, Randy Dunlap wrote: > Hi, > > Fix a few typos: > > On 11/6/20 12:32 PM, Minchan Kim wrote: > > --- > > Documentation/admin-guide/sysctl/vm.rst | 14 ++++++++++++++ > > include/linux/mm.h | 2 ++ > > include/linux/oom.h | 1 + > > kernel/sysctl.c | 9 +++++++++ > > mm/oom_kill.c | 24 ++++++++++++++++++++++++ > > 5 files changed, 50 insertions(+) > > > > diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst > > index f455fa00c00f..49dcedfaf0c0 100644 > > --- a/Documentation/admin-guide/sysctl/vm.rst > > +++ b/Documentation/admin-guide/sysctl/vm.rst > > @@ -694,6 +694,20 @@ is used in oom_kill_allocating_task. > > > > The default value is 0. > > > > +oom_kill_disable > > +================ > > + > > +This disables or enables OOM killing in out-of-memory situations. > > + > > +If this is set to one, the OOM killer is disabled so OOM kill never > > +hapens in out-of-memory situation. It could cause system dangerous > > happens It could cause a dangerous system > > > +state due to memory allocation failure so user should be careful to > > careful when > > +use it. > > using it. > > > + > > +If this is set to zero, the OOM killer is enabled so OOM kill happens > > +in out-of-memory situations. > > + > > +The default value is 0. > > > > overcommit_kbytes > > ================= > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > index 8b84661a6410..0f48cdeeb1e7 100644 > > --- a/mm/oom_kill.c > > +++ b/mm/oom_kill.c > > > #ifdef CONFIG_NUMA > > /** > > * oom_cpuset_eligible() - check task eligiblity for kill > > eligibility > > but that's not in your patch, so don't bother with it. :) Sure, I will resend it with fixing after waiting some feedback. Thanks for the review, Randy.