From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5936CC2D0A3 for ; Tue, 10 Nov 2020 03:37:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBA20216C4 for ; Tue, 10 Nov 2020 03:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="U3q0RUWv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBA20216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDD926B0078; Mon, 9 Nov 2020 22:37:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6B726B0073; Mon, 9 Nov 2020 22:37:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCCA6B0078; Mon, 9 Nov 2020 22:37:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 55F566B0073 for ; Mon, 9 Nov 2020 22:37:14 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ED02F181AEF1A for ; Tue, 10 Nov 2020 03:37:13 +0000 (UTC) X-FDA: 77467097946.02.pest56_260985b272f1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id C969510097AA0 for ; Tue, 10 Nov 2020 03:37:13 +0000 (UTC) X-HE-Tag: pest56_260985b272f1 X-Filterd-Recvd-Size: 5914 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 03:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=5LafMIUog0t1R4fvpnZSdZTQ3XRYlwYMfxi8ZQP6OkA=; b=U3q0RUWv1xPD2RzLqRiAwTQG7s DA2C2TggH9C82kwAOYFMHgvQYL179PG/hpPBCtixJp2G6LB818K/7e0RbFHhb/LWwIsn39f6xQk0+ YJpElvNzTfp5vpHPVjJLESk+0WnQvbf41DaIjVYoUiCYwCw3ubR2vjfWNyAcdYzD0w7TSQOM0+Ny/ IQPYQXbUhcYiOqdmgjWKDja3xOg9hxahNwYMrjftjq3G8T0vFE999yluQHmOFroPLyMh81yMSs7sm EZcTN7SjChwvC8ufnCmmJxAR1eQw3tuUTvvLDjG5jdGSKxb0PrJ1uXMh3ZWWbv5SwRp3odlqYCDRv i1fM0GPA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcKT0-00065Y-9k; Tue, 10 Nov 2020 03:37:10 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , hch@lst.de, kent.overstreet@gmail.com Subject: [PATCH v3 09/18] mm/filemap: Change filemap_read_page calling conventions Date: Tue, 10 Nov 2020 03:36:54 +0000 Message-Id: <20201110033703.23261-10-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20201110033703.23261-1-willy@infradead.org> References: <20201110033703.23261-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Make this function more generic by passing the file instead of the iocb. Check in the callers whether we should call readpage or not. Also make it return an errno / 0 / AOP_TRUNCATED_PAGE, and make calling put_page() the caller's responsibility. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet --- mm/filemap.c | 89 +++++++++++++++++++++++++--------------------------- 1 file changed, 42 insertions(+), 47 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 3e2994a84a81..52d606916477 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2197,56 +2197,38 @@ static void filemap_get_read_batch(struct address= _space *mapping, rcu_read_unlock(); } =20 -static struct page *filemap_read_page(struct kiocb *iocb, struct file *f= ilp, - struct address_space *mapping, struct page *page) +static int filemap_read_page(struct file *file, struct address_space *ma= pping, + struct page *page) { - struct file_ra_state *ra =3D &filp->f_ra; int error; =20 - if (iocb->ki_flags & (IOCB_NOIO | IOCB_NOWAIT | IOCB_WAITQ)) { - unlock_page(page); - put_page(page); - return ERR_PTR(-EAGAIN); - } - /* - * A previous I/O error may have been due to temporary - * failures, eg. multipath errors. - * PG_error will be set again if readpage fails. + * A previous I/O error may have been due to temporary failures, + * eg. multipath errors. PG_error will be set again if readpage + * fails. */ ClearPageError(page); /* Start the actual read. The read will unlock the page. */ - error =3D mapping->a_ops->readpage(filp, page); - - if (unlikely(error)) { - put_page(page); - return error !=3D AOP_TRUNCATED_PAGE ? ERR_PTR(error) : NULL; - } + error =3D mapping->a_ops->readpage(file, page); + if (error) + return error; + if (PageUptodate(page)) + return 0; =20 + error =3D lock_page_killable(page); + if (error) + return error; if (!PageUptodate(page)) { - error =3D lock_page_killable(page); - if (unlikely(error)) { - put_page(page); - return ERR_PTR(error); - } - if (!PageUptodate(page)) { - if (page->mapping =3D=3D NULL) { - /* - * invalidate_mapping_pages got it - */ - unlock_page(page); - put_page(page); - return NULL; - } - unlock_page(page); - shrink_readahead_size_eio(ra); - put_page(page); - return ERR_PTR(-EIO); + if (page->mapping =3D=3D NULL) { + /* page truncated */ + error =3D AOP_TRUNCATED_PAGE; + } else { + shrink_readahead_size_eio(&file->f_ra); + error =3D -EIO; } - unlock_page(page); } - - return page; + unlock_page(page); + return error; } =20 static struct page *filemap_update_page(struct kiocb *iocb, struct file = *filp, @@ -2288,7 +2270,18 @@ static struct page *filemap_update_page(struct kio= cb *iocb, struct file *filp, return page; =20 readpage: - return filemap_read_page(iocb, filp, mapping, page); + if (iocb->ki_flags & (IOCB_NOIO | IOCB_NOWAIT | IOCB_WAITQ)) { + unlock_page(page); + put_page(page); + return ERR_PTR(-EAGAIN); + } + error =3D filemap_read_page(iocb->ki_filp, mapping, page); + if (!error) + return page; + put_page(page); + if (error =3D=3D AOP_TRUNCATED_PAGE) + return NULL; + return ERR_PTR(error); truncated: unlock_page(page); put_page(page); @@ -2304,7 +2297,7 @@ static struct page *filemap_create_page(struct kioc= b *iocb, struct page *page; int error; =20 - if (iocb->ki_flags & IOCB_NOIO) + if (iocb->ki_flags & (IOCB_NOIO | IOCB_NOWAIT | IOCB_WAITQ)) return ERR_PTR(-EAGAIN); =20 page =3D page_cache_alloc(mapping); @@ -2313,12 +2306,14 @@ static struct page *filemap_create_page(struct ki= ocb *iocb, =20 error =3D add_to_page_cache_lru(page, mapping, index, mapping_gfp_constraint(mapping, GFP_KERNEL)); - if (error) { - put_page(page); - return error !=3D -EEXIST ? ERR_PTR(error) : NULL; - } - - return filemap_read_page(iocb, filp, mapping, page); + if (!error) + error =3D filemap_read_page(iocb->ki_filp, mapping, page); + if (!error) + return page; + put_page(page); + if (error =3D=3D -EEXIST || error =3D=3D AOP_TRUNCATED_PAGE) + return NULL; + return ERR_PTR(error); } =20 static int filemap_get_pages(struct kiocb *iocb, struct iov_iter *iter, --=20 2.28.0