From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592EAC4741F for ; Tue, 10 Nov 2020 09:58:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F27020780 for ; Tue, 10 Nov 2020 09:58:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="V70csC1e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F27020780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD6406B005C; Tue, 10 Nov 2020 04:58:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A86706B006C; Tue, 10 Nov 2020 04:58:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E026B006E; Tue, 10 Nov 2020 04:58:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 6B5A66B005C for ; Tue, 10 Nov 2020 04:58:15 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 114EBD234 for ; Tue, 10 Nov 2020 09:58:15 +0000 (UTC) X-FDA: 77468058150.10.rake40_0506875272f4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id E12DC16A047 for ; Tue, 10 Nov 2020 09:58:14 +0000 (UTC) X-HE-Tag: rake40_0506875272f4 X-Filterd-Recvd-Size: 4101 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 09:58:14 +0000 (UTC) Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6414020780; Tue, 10 Nov 2020 09:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605002293; bh=qTvuhXI8yb9kzIsmvWorljez87NX0Y7TlxO8SGs8940=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V70csC1e3dgcXVirLFjHrv9tWI1nvZ5tApBo8lcp1y65qHAipgmBVwHGTpk43f5KD pJFPrvgoL8ZRRRNHgjoCsQjx375vGV36RdtwrT9Vp8VpYXTa6/kBMroduHe2dFtCDY Roqaz1u6T4gP52GjieCtBolTwgxo07FQUdmh81sA= Date: Tue, 10 Nov 2020 11:58:06 +0200 From: Mike Rapoport To: Stefan Agner Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, akpm@linux-foundation.org, sjenning@linux.vnet.ibm.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS Message-ID: <20201110095806.GH301837@kernel.org> References: <20201108064659.GD301837@kernel.org> <7782fb694a6b0c500e8f32ecf895b2bf@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7782fb694a6b0c500e8f32ecf895b2bf@agner.ch> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:29:54AM +0100, Stefan Agner wrote: > On 2020-11-08 07:46, Mike Rapoport wrote: > > On Sat, Nov 07, 2020 at 04:22:06PM +0100, Stefan Agner wrote: > >> Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't > >> include it in asm/pgtable.h. Include asm/sparsemem.h directly to get > >> the MAX_PHYSMEM_BITS define on all architectures. ... > >> Fixes: 61989a80fb3a ("staging: zsmalloc: zsmalloc memory allocation library") > >> Signed-off-by: Stefan Agner > >> --- > >> mm/zsmalloc.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > >> index c36fdff9a371..260bd48aacd0 100644 > >> --- a/mm/zsmalloc.c > >> +++ b/mm/zsmalloc.c > >> @@ -40,6 +40,7 @@ > >> #include > >> #include > >> #include > >> +#include > > > > asm/sparsemem.h is not available on some architectures. > > It's better to use linux/mmzone.h instead. > > > > Hm, linux/mmzone.h only includes asm/sparsemem.h when CONFIG_SPARSEMEM > is enabled. However, on ARM at least I can have configurations without > CONFIG_SPARSEMEM and physical address extension on (e.g. > multi_v7_defconfig + CONFIG_LPAE + CONFIG_ZSMALLOC). > > While sparsemem seems to be a good idea with LPAE it really seems not > required (see also https://lore.kernel.org/patchwork/patch/567589/). > > There seem to be also other architectures which define MAX_PHYSMEM_BITS > only when SPARSEMEM is enabled, e.g. > arch/riscv/include/asm/sparsemem.h... > > Not sure how to get out of this.. Maybe make ZSMALLOC dependent on > SPARSEMEM? It feels a bit silly restricting ZSMALLOC selection only due > to a compile time define... I think we can define MAX_POSSIBLE_PHYSMEM_BITS in one of arch/arm/inclide/asm/pgtable-{2,3}level-*.h headers to values supported by !LPAE and LPAE. That's what x86 does: $ git grep -w MAX_POSSIBLE_PHYSMEM_BITS arch/ arch/x86/include/asm/pgtable-3level_types.h:#define MAX_POSSIBLE_PHYSMEM_BITS 36 arch/x86/include/asm/pgtable_64_types.h:#define MAX_POSSIBLE_PHYSMEM_BITS 52 It seems that actual numbers would be 36 for !LPAE and 40 for LPAE, but I'm not sure about that. > -- > Stefan > > >> #include > >> #include > >> #include > >> -- > >> 2.29.1 > >> > >> -- Sincerely yours, Mike.