From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CF0C56201 for ; Tue, 10 Nov 2020 18:25:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21DBF20829 for ; Tue, 10 Nov 2020 18:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lTYD3pHc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21DBF20829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B7E96B005D; Tue, 10 Nov 2020 13:25:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9678F6B0068; Tue, 10 Nov 2020 13:25:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A4BF6B0071; Tue, 10 Nov 2020 13:25:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 5E43E6B005D for ; Tue, 10 Nov 2020 13:25:21 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E93FE362D for ; Tue, 10 Nov 2020 18:25:20 +0000 (UTC) X-FDA: 77469336000.23.pan33_490566a272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id C833537606 for ; Tue, 10 Nov 2020 18:25:20 +0000 (UTC) X-HE-Tag: pan33_490566a272f7 X-Filterd-Recvd-Size: 2258 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gxTWVrKCu8fGIsjS7YDvqum7aOq90Rdj1IzGnbiADLQ=; b=lTYD3pHcXSAttpgS82rgafuvio BeEI7h8PZ6Pdb4kzOSja8QJ8qxZC+893goPRVsfHzqPnxI9r5LK+H0QL8YItwaC5uV8R1REmpxDkf igUchFqJXjZMsCzZde95sd69vss9UxxQRTQL7uCcpyxmiGZyBe0hmuoqu7HW97Q2Yx8kM6wUfR1sm fuMl8GygcVW34wUgsUrcSZkgJ+f9X/oUibnBx7FFUFHoaNsOSydcupNj8N4UYAgs8lx3p+xGFz5XD KzIrH+IV7usQPOlJpbfo6XdfegUgbyod6NSsQPJtkqosGxBn9jT+/uKH7HxRPK5KlXFpZwwjWBGz/ Cb9HxbFg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcYKR-0001z3-M9; Tue, 10 Nov 2020 18:25:15 +0000 Date: Tue, 10 Nov 2020 18:25:15 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kent.overstreet@gmail.com Subject: Re: [PATCH v3 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec Message-ID: <20201110182515.GK17076@casper.infradead.org> References: <20201110033703.23261-1-willy@infradead.org> <20201110033703.23261-4-willy@infradead.org> <20201110182118.GB28701@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110182118.GB28701@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 07:21:18PM +0100, Christoph Hellwig wrote: > On Tue, Nov 10, 2020 at 03:36:48AM +0000, Matthew Wilcox (Oracle) wrote: > > Using a pagevec lets us keep the pages and the number of pages together > > which simplifies a lot of the calling conventions. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > I hate the > 80 char lines in a few spots, but otherwise this looks good: They're all gone by the end of this series. It's just less churn to ignore the 80 columns limit for the intermediate patches. > Reviewed-by: Christoph Hellwig