From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A641C388F7 for ; Tue, 10 Nov 2020 18:50:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 53E0D20829 for ; Tue, 10 Nov 2020 18:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="aD1YSSjm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53E0D20829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C50A26B0036; Tue, 10 Nov 2020 13:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C00356B005C; Tue, 10 Nov 2020 13:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEF1C6B005D; Tue, 10 Nov 2020 13:50:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 8446C6B0036 for ; Tue, 10 Nov 2020 13:50:40 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 20F66181AEF10 for ; Tue, 10 Nov 2020 18:50:40 +0000 (UTC) X-FDA: 77469399840.16.stage05_5c1707c272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id E8071100E691B for ; Tue, 10 Nov 2020 18:50:39 +0000 (UTC) X-HE-Tag: stage05_5c1707c272f7 X-Filterd-Recvd-Size: 3613 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:50:39 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id dj6so6372266qvb.3 for ; Tue, 10 Nov 2020 10:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ao4gO8dckdnbUrVLtqZDO6K8/CHWVv04osrwbe3s3CE=; b=aD1YSSjm5h1E5fKJUFCbr7un4ITDFwPpH6MF9varMrqIuVbGJBuFVykbxLg6VBTlR2 tUkpEBkPpR8DPcUIo0qFS6gFiGku7QOoKoQBtjKBKDNpokJOdt4IStbsoWjphGGuEIe3 rsI4GBvWMkch7slymkedYAaZbD+xCPLbfIZ6GnBCRmIMgFA/3XwHS4WrRB+h21kNDxEv yOCKKNCwlspZuRBiQvvK9EdTbTaHZ+3cJcK3xZLEcFIWMSEjzeJQGDQ+wlOIpFQISCyd rss3dJMftolMW5jlmv73BOiORadddv7rPLT2D1Ncc6b1S+mG7UF7n7uZBlthn8zRh769 2Paw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ao4gO8dckdnbUrVLtqZDO6K8/CHWVv04osrwbe3s3CE=; b=XsjeQCHbqguAq9+We1xcvackfmYwV/EyUMqKiGvW88MS2L6457hH5DfumAKn7vxI9P rxiL5CB2MjfwouhzcpbGJESaSedauzck2TI4wxHhMab8u9hTsUH245SjIllm0MFo3xjZ 0OZu83f3vec67ijWC9AtXwEB3962z5eTZQsuNu//CRMfq8aYBK8qxfldcig3uYRBtJDE K1YobjyKW1jVAkVc7GCr79ILFTbC7d0HksjhNvxWpUCQ8qcoTZ3UZCvAVIuKsjiDG3Ns CgmjWL+PyQp5z/brTB8SluCUFitzObmFl5+e//Z2ftDIHFoqAVGT646JcWbTDgDPg1Ss Q+Ag== X-Gm-Message-State: AOAM530eZT6/20xqf4yOf1zBXPRsMUtPaYYMaTGUbF8BJ6YLw484aReH nCXiBybGB1ldh2EHgpZX6AoERA== X-Google-Smtp-Source: ABdhPJzzxCdfp78n0ASzjgdakdyVzAJCxf5dldOeoZdGScdsYAQ1wKF4N8gSu4becV/R64CgioXQlQ== X-Received: by 2002:ad4:4943:: with SMTP id o3mr20168428qvy.9.1605034238663; Tue, 10 Nov 2020 10:50:38 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:64f7]) by smtp.gmail.com with ESMTPSA id c76sm9398105qkb.20.2020.11.10.10.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 10:50:37 -0800 (PST) Date: Tue, 10 Nov 2020 13:48:50 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Shakeel Butt , Michal Hocko , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: memcg: fix obsolete code comments Message-ID: <20201110184850.GA850433@cmpxchg.org> References: <20201110184615.311974-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110184615.311974-1-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:46:15AM -0800, Roman Gushchin wrote: > This patch fixes/removes some obsolete comments in the code related > to the kernel memory accounting: > - kmem_cache->memcg_params.memcg_caches has been removed > by commit 9855609bde03 ("mm: memcg/slab: use a single set of > kmem_caches for all accounted allocations") > - memcg->kmemcg_id is not used as a gate for kmem accounting since > commit 0b8f73e10428 ("mm: memcontrol: clean up alloc, online, > offline, free functions") > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner Thanks Roman