From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F4FC56201 for ; Tue, 10 Nov 2020 19:01:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34AAD2076E for ; Tue, 10 Nov 2020 19:01:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="pk0sA6n4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34AAD2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B07496B005D; Tue, 10 Nov 2020 14:01:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6B66B0068; Tue, 10 Nov 2020 14:01:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCB96B006C; Tue, 10 Nov 2020 14:01:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 6FD726B005D for ; Tue, 10 Nov 2020 14:01:49 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 19EE582499A8 for ; Tue, 10 Nov 2020 19:01:49 +0000 (UTC) X-FDA: 77469427938.16.waste41_2603c75272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id B3231100E6917 for ; Tue, 10 Nov 2020 19:01:48 +0000 (UTC) X-HE-Tag: waste41_2603c75272f7 X-Filterd-Recvd-Size: 5121 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 19:01:47 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id z17so2692915qvy.11 for ; Tue, 10 Nov 2020 11:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JVcNggoHnnZHnilf65d3Odr5BSO3kl6mZ2aAWXQzRAo=; b=pk0sA6n4GDC9Xw1ArnL9O5vFNkTR5jEvlt0tkXEf4OOrdrRf0iF57WkXkq+aZYt5md SOSYGeOwJSxgei8KKg5Yo31SLqDaLSsHfymGg1j+h3i5xP9aG3N3Ponj3RSQUSa3S+Da MAJrkym3VnKjHe2aMbbHNw47MDcHZDhsY95JowUiHyKM48Bt4wQnhEQcVMcrdx1F0wQ4 cqL0zycLg4WR6wrxM8A0O8Pahsaxszc2AP39S+/sfFz72xb9uTzEVB8x6wGdrjSFMGIg oWkRlt3BsWF82RX0mGXyCgQrt1W2lsZfBe7aYt7B3k8TF536jzWY+531OJzHc1fJTPDz nsCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JVcNggoHnnZHnilf65d3Odr5BSO3kl6mZ2aAWXQzRAo=; b=T1bfvMwm6N1X+Hg3JLQvE2OJxmRWX4q2NORibGRfMofV/nEnRJSfHw61uuZWezIAW3 tnIk+h1uBRjvDtlUG3+4ccCeyuASAoni0tqgkwOmnFIy3AmIQONvxL60MX1kMQGa15/5 z9bSbAapH/deaJtpNkcU5bMayC73B8PMPHbQ6ygaV4J2Rg+36SON+K1GTrZ6lJ1nQIQE h9Urptq0jVQ+99N3XYvZsVnoj2jsi7TllNMGrGUmPf0kf8mziu7M1dfi+RO5eTdwdfuw CIPJSHlc5oHL9sXA4xuRl8WimqNDHdmDsb/EJlwIJRBO1DxeYBlgkIU82NXgDKCKIEEP GAaA== X-Gm-Message-State: AOAM532iE0q5WQpUGJgo2NmZRwKW8Vo70YX0AS7jsAnnEuLoe33Krpxo 0Wua/I1B7Tk4nh3WM6CP/lR8IQ== X-Google-Smtp-Source: ABdhPJzqHu0u+YcHQbPCJo8kW9MtBEu4OpLULJDqXdjGYlwoVtkU7rGpiwrGxOD0A9HDtqP73E/74Q== X-Received: by 2002:a0c:9bac:: with SMTP id o44mr20889059qve.43.1605034907200; Tue, 10 Nov 2020 11:01:47 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:64f7]) by smtp.gmail.com with ESMTPSA id n41sm9027909qtb.18.2020.11.10.11.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 11:01:46 -0800 (PST) Date: Tue, 10 Nov 2020 13:59:58 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Alexander Duyck , Thomas Gleixner , Andrey Ryabinin Subject: Re: [PATCH v21 18/19] mm/lru: introduce the relock_page_lruvec function Message-ID: <20201110185958.GC850433@cmpxchg.org> References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <1604566549-62481-19-git-send-email-alex.shi@linux.alibaba.com> <66d8e79d-7ec6-bfbc-1c82-bf32db3ae5b7@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66d8e79d-7ec6-bfbc-1c82-bf32db3ae5b7@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 06, 2020 at 03:50:22PM +0800, Alex Shi wrote: > From 6c142eb582e7d0dbf473572ad092eca07ab75221 Mon Sep 17 00:00:00 2001 > From: Alexander Duyck > Date: Tue, 26 May 2020 17:31:15 +0800 > Subject: [PATCH v21 18/19] mm/lru: introduce the relock_page_lruvec function > > Use this new function to replace repeated same code, no func change. > > When testing for relock we can avoid the need for RCU locking if we simply > compare the page pgdat and memcg pointers versus those that the lruvec is > holding. By doing this we can avoid the extra pointer walks and accesses of > the memory cgroup. > > In addition we can avoid the checks entirely if lruvec is currently NULL. > > Signed-off-by: Alexander Duyck > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Acked-by: Johannes Weiner > Cc: Johannes Weiner > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: Andrey Ryabinin > Cc: Matthew Wilcox > Cc: Mel Gorman > Cc: Konstantin Khlebnikov > Cc: Hugh Dickins > Cc: Tejun Heo > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org Acked-by: Johannes Weiner