From: Roman Gushchin <guro@fb.com>
To: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Cc: Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Christoph Lameter <cl@linux.com>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>, Roman Gushchin <guro@fb.com>
Subject: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization
Date: Tue, 10 Nov 2020 11:57:52 -0800
Message-ID: <20201110195753.530157-1-guro@fb.com> (raw)
It's convenient to have page->objects initialized before calling
into account_slab_page(). In particular, this information can be
used to pre-alloc the obj_cgroup vector.
Let's call account_slab_page() a bit later, after the initialization
of page->objects.
This commit doesn't bring any functional change, but is required for
further optimizations.
Signed-off-by: Roman Gushchin <guro@fb.com>
---
mm/slub.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 8c9fa24ebbf3..ccdbb62e025d 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1622,9 +1622,6 @@ static inline struct page *alloc_slab_page(struct kmem_cache *s,
else
page = __alloc_pages_node(node, flags, order);
- if (page)
- account_slab_page(page, order, s);
-
return page;
}
@@ -1777,6 +1774,8 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
page->objects = oo_objects(oo);
+ account_slab_page(page, oo_order(oo), s, flags);
+
page->slab_cache = s;
__SetPageSlab(page);
if (page_is_pfmemalloc(page))
--
2.26.2
next reply index
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:57 Roman Gushchin [this message]
2020-11-10 19:57 ` [PATCH 2/2] mm: memcg/slab: pre-allocate obj_cgroups for slab caches with SLAB_ACCOUNT Roman Gushchin
2020-11-10 20:50 ` Andrew Morton
2020-11-10 21:51 ` Roman Gushchin
2020-11-12 16:23 ` Johannes Weiner
2020-11-13 0:19 ` Roman Gushchin
2020-11-13 1:12 ` Andrew Morton
2020-11-13 1:46 ` Roman Gushchin
2020-11-16 15:03 ` Johannes Weiner
2020-11-17 17:42 ` Shakeel Butt
2020-11-17 20:15 ` Roman Gushchin
2020-11-12 15:18 ` [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization Johannes Weiner
2020-11-17 17:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110195753.530157-1-guro@fb.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
linux-mm@kvack.org
public-inbox-index linux-mm
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kvack.linux-mm
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git