From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C8DC56201 for ; Wed, 11 Nov 2020 19:18:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27BBD20797 for ; Wed, 11 Nov 2020 19:18:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QIq5tT27" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27BBD20797 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53D876B005D; Wed, 11 Nov 2020 14:18:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF1F6B006C; Wed, 11 Nov 2020 14:18:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B8406B006E; Wed, 11 Nov 2020 14:18:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 0AA7C6B005D for ; Wed, 11 Nov 2020 14:18:49 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 99DC23626 for ; Wed, 11 Nov 2020 19:18:49 +0000 (UTC) X-FDA: 77473099578.14.wrist78_0f0bd2227300 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 872E61822987A for ; Wed, 11 Nov 2020 19:18:49 +0000 (UTC) X-HE-Tag: wrist78_0f0bd2227300 X-Filterd-Recvd-Size: 4600 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 19:18:49 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id b8so3644670wrn.0 for ; Wed, 11 Nov 2020 11:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OKGISrzawD1j8o64KuvlnCYWWA4Vpka6a0oknsEcZJw=; b=QIq5tT271m/1hqoWebW5vn4gjE/Uwv/AdBTyMmJwHN2JQe6QEGa0ZyGDwW6pU2iNaT 5SWCsDGxemAKPn6UMPHGqapWwXqzT/tOgSvb7qjVq3EmSur3oge2ITFmLWRO1weKQ99e IqxOfQIYjxxcx97KM1S+pB8TwWWjVAxxOd1lpoLpAQqdar/u4S1v5lopqNcn8oPupLJ4 JUItXv4lAOfU9oUFxlzWSjpn5+1KdyCLApwweGeHB7g+t8KKTWYHMLFDAXdnKEe7rK5g DA0SDqguVeNm3rnLi/KgQK19t/068ksnmR/iirxFZo/9cE4HHAYkwQzXde0T+p3RAkgQ p4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OKGISrzawD1j8o64KuvlnCYWWA4Vpka6a0oknsEcZJw=; b=DfFWzmMRhLf7aLe4e/DB9ByY3p1w2mnv3oMzqReOn/w0YaqrZeRKhmNcP300/GgS1W lxy7kNSrh4+7RMf6msidhEB8Lvevxu8tX4vYQIZpimaWWRowTMt3dounl3irN/sMqSsK 3jsC3EFevJLa23TICvq/xabWfTUkitkAV2qCy0mYS/g9UDgvIvtJkbpl0jjIXlhQbzVQ xNJ0xMNVHcQQfn7jblhUzg3YAItTkWsBzEsv6V20VcT7Q0WAdM5KuM7CIY2St0inDsEf cUNvM40jRDARV3+eXEUNUGd5ki9g58HR+FEZNIPZNj6P+rDbNiAOxklOqf9SVfXPA5bo qXeQ== X-Gm-Message-State: AOAM533KTDGHtHjYRvDHS03VMIIL0e4Q4ciMbH1SDT//1c+dEDYg8lZ6 4bCHnL4EUeTBB+l4cGhPLWSdpQ== X-Google-Smtp-Source: ABdhPJy+Ds6tB3o1+P+c80bWAGxCKjWqrwUjd7Kqi8jPSulhfgKnbIsHBik9b8Ze1Rj5O2bj8ybVjQ== X-Received: by 2002:adf:f644:: with SMTP id x4mr32047323wrp.5.1605122327874; Wed, 11 Nov 2020 11:18:47 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c6sm3806761wrh.74.2020.11.11.11.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 11:18:47 -0800 (PST) Date: Wed, 11 Nov 2020 20:18:41 +0100 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 17/20] kasan: clarify comment in __kasan_kfree_large Message-ID: <20201111191841.GS517454@elver.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > Currently it says that the memory gets poisoned by page_alloc code. > Clarify this by mentioning the specific callback that poisons the > memory. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Dmitry Vyukov > Link: https://linux-review.googlesource.com/id/I1334dffb69b87d7986fab88a1a039cc3ea764725 > --- > mm/kasan/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Marco Elver > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 40ff3ce07a76..4360292ad7f3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -436,5 +436,5 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) > { > if (ptr != page_address(virt_to_head_page(ptr))) > kasan_report_invalid_free(ptr, ip); > - /* The object will be poisoned by page_alloc. */ > + /* The object will be poisoned by kasan_free_pages(). */ > } > -- > 2.29.2.222.g5d2a92d10f8-goog >