From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC00C5519F for ; Thu, 12 Nov 2020 14:25:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EC7E22248 for ; Thu, 12 Nov 2020 14:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mPUVPqKe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EC7E22248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86B616B006E; Thu, 12 Nov 2020 09:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D5E6B0071; Thu, 12 Nov 2020 09:25:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A6D6B0072; Thu, 12 Nov 2020 09:25:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 43E706B006E for ; Thu, 12 Nov 2020 09:25:16 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C430A3624 for ; Thu, 12 Nov 2020 14:25:15 +0000 (UTC) X-FDA: 77475988590.11.magic42_4c0b2ce27307 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 9FF30180F8B81 for ; Thu, 12 Nov 2020 14:25:15 +0000 (UTC) X-HE-Tag: magic42_4c0b2ce27307 X-Filterd-Recvd-Size: 2486 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Nov 2020 14:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VcMks6Wi61G32KKQBazDbueQCM5KDLnMj38ZyrJ3Vq0=; b=mPUVPqKezBH0sm5pocs2w/1taz 1ANQLNTV1zNlQkSEv938A+v7xjQOunJjD1pGMFnh7w/+ScT+Ix3LEDiM5MUJceoJzqES+ffGT8wj6 dQu+3ofTRhraKJVXmaD8e/oBh1DDesC7q32VTl6/E2p6LmDo9oSB4dxdLWMf4gMDmEnv3ogJDZCut v8DqIKqfq7cOI2wJSPZF/jdJnJ88eJLlGy8t5DTv3rgBoniWVtkeMZtFa6V1vT47elTgjMPEIe5+A UsBQYiXLh4DjNcAt+0LrbQVV5DWOcK98obakGagJHOy2rXkvfSAiH2s0x51cTpLS6mxEpIWzgAapF ZfH4f6UA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdDXB-0006a5-28; Thu, 12 Nov 2020 14:25:09 +0000 Date: Thu, 12 Nov 2020 14:25:08 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Hugh Dickins , Johannes Weiner , Yang Shi , Dave Chinner , linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v3 03/12] mm/filemap: Add helper for finding pages Message-ID: <20201112142508.GA17076@casper.infradead.org> References: <20201026041408.25230-1-willy@infradead.org> <20201026041408.25230-4-willy@infradead.org> <20201027185642.GA15201@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027185642.GA15201@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 27, 2020 at 06:56:42PM +0000, Christoph Hellwig wrote: > > +static inline struct page *xas_find_get_entry(struct xa_state *xas, > > + pgoff_t max, xa_mark_t mark) > > I'd expect the xas_ prefix for function from xarray.h. Maybe this > wants a better name? The obvious name for this is find_get_entry(). But that already exists. Although it turns out it has only two users and one of them doesn't actually want to use it, so I'm going to rename find_get_entry() to mapping_get_entry() and then this can become find_get_entry().