From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B99C4742C for ; Fri, 13 Nov 2020 10:24:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C94C2224B for ; Fri, 13 Nov 2020 10:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hi6ZYCuB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C94C2224B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61EB16B0089; Fri, 13 Nov 2020 05:24:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A7FD6B008A; Fri, 13 Nov 2020 05:24:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F2D6B008C; Fri, 13 Nov 2020 05:24:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 15E476B0089 for ; Fri, 13 Nov 2020 05:24:30 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9EC1D180AD801 for ; Fri, 13 Nov 2020 10:24:29 +0000 (UTC) X-FDA: 77479010658.19.limit92_010e3cb2730e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 7E8611AD1B5 for ; Fri, 13 Nov 2020 10:24:29 +0000 (UTC) X-HE-Tag: limit92_010e3cb2730e X-Filterd-Recvd-Size: 3507 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 10:24:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605263067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B+WTkGmdnbMkZJ6lvWOrKglzHqkfUKwJ37Bf3POufS0=; b=hi6ZYCuBy9LTd32MYAOl7/1g6R/j+EPAtoejSTD+03b42sEHINgv7r/acGja+X956WhVPB OG8xUpON2Gg2XkPlKW59eT85WuMPr/U5jjifWsNErS9amquE5QcDuE46lnzL9T7uX7CMmi cDVrha+nhDPvEFgBYw/gisd0ao1PvdI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CA748AEFF; Fri, 13 Nov 2020 10:24:27 +0000 (UTC) Date: Fri, 13 Nov 2020 11:24:27 +0100 From: Petr Mladek To: "Zhang, Qiang" Cc: Andrew Morton , "tj@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: =?utf-8?B?5Zue5aSN?= =?utf-8?Q?=3A?= [PATCH] kthread_worker: Add flush delayed work func Message-ID: <20201113102427.GI20201@alley> References: <20201111091355.19476-1-qiang.zhang@windriver.com> <20201112160135.2b5720c66b020472892f2366@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 2020-11-13 08:59:37, Zhang, Qiang wrote: >=20 >=20 > ________________________________________ > =E5=8F=91=E4=BB=B6=E4=BA=BA: Andrew Morton > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=8813=E6=97=A5= 8:01 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Zhang, Qiang > =E6=8A=84=E9=80=81: pmladek@suse.com; tj@kernel.org; linux-mm@kvack.org= ; linux-kernel@vger.kernel.org > =E4=B8=BB=E9=A2=98: Re: [PATCH] kthread_worker: Add flush delayed work = func >=20 > [Please note this e-mail is from an EXTERNAL e-mail address] >=20 > On Wed, 11 Nov 2020 17:13:55 +0800 qiang.zhang@windriver.com wrote: >=20 > > Add 'kthread_flush_delayed_work' func, the principle of > > this func is wait for a dwork to finish executing the > > last queueing. > > > >We'd like to see some code which actually uses this new function > >please. Either in this patch or as one or more followup patches. > > > >btw, we call it "function", not "func". But neither is really needed = - > >just use () to identify a function. ie: >=20 > >: Add kthread_flush_delayed_work(). The principle of this is to wait = for > >: a dwork to finish executing the last queueing. >=20 > I don't see it being used in the kernel code so far, and I'm not sure i= f it's going to be used in subsequent scenarios (it like flush_delayed_wo= rk in workqueue )or whether it's currently using "kthread_work" some code= needs it. I agree with Andrew. It does not make sense to add/maintain new API when it is not going to be used. The kthread_worker API is used only when the kthread needs some special scheduling policy or priority. There always will be only few users in compare with the workqueues API. It is possible that this function will never be necessary. Best Regards, Petr