From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E57C388F7 for ; Fri, 13 Nov 2020 11:03:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E55E522250 for ; Fri, 13 Nov 2020 11:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="HXMyr8Xa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E55E522250 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76D4F6B00BA; Fri, 13 Nov 2020 06:03:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71B166B00BB; Fri, 13 Nov 2020 06:03:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BCEB6B00BC; Fri, 13 Nov 2020 06:03:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 2C4776B00BA for ; Fri, 13 Nov 2020 06:03:14 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C61EE1EE6 for ; Fri, 13 Nov 2020 11:03:13 +0000 (UTC) X-FDA: 77479108266.13.store11_371265e2730e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id A53DC18140B67 for ; Fri, 13 Nov 2020 11:03:13 +0000 (UTC) X-HE-Tag: store11_371265e2730e X-Filterd-Recvd-Size: 8674 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 11:03:13 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id b3so4367615pls.11 for ; Fri, 13 Nov 2020 03:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VTBEkY0EWBbMy5iIzZRtsaqCivtCwTiUQlKtEZa+cOQ=; b=HXMyr8XazQ6oTzSEwqXN6zTDQfzwHhzhGI9vF9dhhvZ4EyuBVJKj33LuCIeBNL1WJO 4i49MSS3mHAOPKlaowtPqF0hKSFYc4DeNeZ23+FxCSvgVL2UY1vA8cA1GIU1y2S+2ue9 k6Iu3xWN0uVnmNNobJsIPiB+23J/BOF1qLmkb4JCArM4HrZPkL+KiAupM8r28sq2B8lh pp61KKhCKGP1P5j3i6Cxtv+tIxo76J3d8L52b65YJ6wPS5KYhdcV1Y5Jt8XOpRSYH3dL pDXGANFAs3AGL8HGfeynfn023qG7xQviy2/sFmuKnR6+Rm4EFS+fquD+urXexrFetu8+ g+Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VTBEkY0EWBbMy5iIzZRtsaqCivtCwTiUQlKtEZa+cOQ=; b=lrrFGP5bFL599rHSdwEaunGbGU3x6HllZsIRECUxRqYlzMJ70Q+dIR+BdPbtdzvZW5 htDMBAduufpRA8ugrYvTGug6udPEnfcVizOPaUNDPNqzCi7fD+T9kRjJJr1vsRcpzLD5 QVSCMvm7NO+QkBHdmdVF44VML4b+sYIIVu2WoiwydlJPtvsq7a8utZiFBb9Av1XazSir ZvdZyGcu8ykDTnJ+mGd4hnX7FXurUeZ4cggVJHLLyWxLstVzO++alyOjkwvYKedeiCjw GOWraKxneYEANUQhbwnB5D9yBAaXyvwxAtz4sRzO0vHfv2DRxkUeIpz0MW1PfTHRoVgS l8fg== X-Gm-Message-State: AOAM530khMO6u1kDPf1HEYIm2ALJSbVRjmIZ8+eaN5ef7GzD77CgAl3Q hraiCSFApKMOFsV3QIcTw6twSg== X-Google-Smtp-Source: ABdhPJzrYDT5xoZpsO3M+6yIguGxa3HMCUVuWgvEDjS67lXujwXi8LjnpKOLMdYhmMzRef8jrVTIfw== X-Received: by 2002:a17:902:7487:b029:d6:c03b:bce4 with SMTP id h7-20020a1709027487b02900d6c03bbce4mr1570873pll.36.1605265392353; Fri, 13 Nov 2020 03:03:12 -0800 (PST) Received: from localhost.localdomain ([61.120.150.78]) by smtp.gmail.com with ESMTPSA id f1sm8909959pfc.56.2020.11.13.03.03.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2020 03:03:11 -0800 (PST) From: Muchun Song To: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, osalvador@suse.de, mhocko@suse.com Cc: duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Muchun Song Subject: [PATCH v4 12/21] mm/hugetlb: Introduce remap_huge_page_pmd_vmemmap helper Date: Fri, 13 Nov 2020 18:59:43 +0800 Message-Id: <20201113105952.11638-13-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20201113105952.11638-1-songmuchun@bytedance.com> References: <20201113105952.11638-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The __free_huge_page_pmd_vmemmap and __remap_huge_page_pmd_vmemmap are almost the same code. So introduce remap_free_huge_page_pmd_vmemmap helper to simplify the code. Signed-off-by: Muchun Song --- mm/hugetlb_vmemmap.c | 108 +++++++++++++++++++++------------------------= ------ 1 file changed, 45 insertions(+), 63 deletions(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 9918dc63c062..ae9dbfb682ab 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -221,6 +221,47 @@ static inline int freed_vmemmap_hpage_dec(struct pag= e *page) return atomic_dec_return_relaxed(&page->_mapcount) + 1; } =20 +static inline void free_vmemmap_page_list(struct list_head *list) +{ + struct page *page, *next; + + list_for_each_entry_safe(page, next, list, lru) { + list_del(&page->lru); + free_vmemmap_page(page); + } +} + +typedef void (*remap_pte_fn)(struct page *reuse, pte_t *ptep, + unsigned long start, unsigned long end, + struct list_head *pages); + +static void remap_huge_page_pmd_vmemmap(struct hstate *h, pmd_t *pmd, + unsigned long addr, + struct list_head *pages, + remap_pte_fn remap_fn) +{ + unsigned long next; + unsigned long start =3D addr + RESERVE_VMEMMAP_SIZE; + unsigned long end =3D addr + vmemmap_pages_size_per_hpage(h); + struct page *reuse =3D NULL; + + flush_cache_vunmap(start, end); + + addr =3D start; + do { + pte_t *ptep; + + ptep =3D pte_offset_kernel(pmd, addr); + if (!reuse) + reuse =3D pte_page(ptep[TAIL_PAGE_REUSE]); + + next =3D vmemmap_hpage_addr_end(addr, end); + remap_fn(reuse, ptep, addr, next, pages); + } while (pmd++, addr =3D next, addr !=3D end); + + flush_tlb_kernel_range(start, end); +} + static void __remap_huge_page_pte_vmemmap(struct page *reuse, pte_t *pte= p, unsigned long start, unsigned long end, @@ -255,31 +296,6 @@ static void __remap_huge_page_pte_vmemmap(struct pag= e *reuse, pte_t *ptep, } } =20 -static void __remap_huge_page_pmd_vmemmap(struct hstate *h, pmd_t *pmd, - unsigned long addr, - struct list_head *remap_pages) -{ - unsigned long next; - unsigned long start =3D addr + RESERVE_VMEMMAP_SIZE; - unsigned long end =3D addr + vmemmap_pages_size_per_hpage(h); - struct page *reuse =3D NULL; - - addr =3D start; - do { - pte_t *ptep; - - ptep =3D pte_offset_kernel(pmd, addr); - if (!reuse) - reuse =3D pte_page(ptep[TAIL_PAGE_REUSE]); - - next =3D vmemmap_hpage_addr_end(addr, end); - __remap_huge_page_pte_vmemmap(reuse, ptep, addr, next, - remap_pages); - } while (pmd++, addr =3D next, addr !=3D end); - - flush_tlb_kernel_range(start, end); -} - static inline void alloc_vmemmap_pages(struct hstate *h, struct list_hea= d *list) { int i; @@ -308,8 +324,8 @@ void alloc_huge_page_vmemmap(struct hstate *h, struct= page *head) BUG_ON(!pmd); =20 ptl =3D vmemmap_pmd_lock(pmd); - __remap_huge_page_pmd_vmemmap(h, pmd, (unsigned long)head, - &remap_pages); + remap_huge_page_pmd_vmemmap(h, pmd, (unsigned long)head, &remap_pages, + __remap_huge_page_pte_vmemmap); if (!freed_vmemmap_hpage_dec(pmd_page(*pmd))) { /* * Todo: @@ -319,16 +335,6 @@ void alloc_huge_page_vmemmap(struct hstate *h, struc= t page *head) spin_unlock(ptl); } =20 -static inline void free_vmemmap_page_list(struct list_head *list) -{ - struct page *page, *next; - - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); - free_vmemmap_page(page); - } -} - static void __free_huge_page_pte_vmemmap(struct page *reuse, pte_t *ptep= , unsigned long start, unsigned long end, @@ -351,31 +357,6 @@ static void __free_huge_page_pte_vmemmap(struct page= *reuse, pte_t *ptep, } } =20 -static void __free_huge_page_pmd_vmemmap(struct hstate *h, pmd_t *pmd, - unsigned long addr, - struct list_head *free_pages) -{ - unsigned long next; - unsigned long start =3D addr + RESERVE_VMEMMAP_SIZE; - unsigned long end =3D addr + vmemmap_pages_size_per_hpage(h); - struct page *reuse =3D NULL; - - addr =3D start; - do { - pte_t *ptep; - - ptep =3D pte_offset_kernel(pmd, addr); - if (!reuse) - reuse =3D pte_page(ptep[TAIL_PAGE_REUSE]); - - next =3D vmemmap_hpage_addr_end(addr, end); - __free_huge_page_pte_vmemmap(reuse, ptep, addr, next, - free_pages); - } while (pmd++, addr =3D next, addr !=3D end); - - flush_tlb_kernel_range(start, end); -} - static void split_vmemmap_pmd(pmd_t *pmd, pte_t *pte_p, unsigned long ad= dr) { int i; @@ -434,7 +415,8 @@ void free_huge_page_vmemmap(struct hstate *h, struct = page *head) if (vmemmap_pmd_huge(pmd)) split_vmemmap_huge_page(head, pmd); =20 - __free_huge_page_pmd_vmemmap(h, pmd, (unsigned long)head, &free_pages); + remap_huge_page_pmd_vmemmap(h, pmd, (unsigned long)head, &free_pages, + __free_huge_page_pte_vmemmap); freed_vmemmap_hpage_inc(pmd_page(*pmd)); spin_unlock(ptl); =20 --=20 2.11.0