From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F4AC388F7 for ; Fri, 13 Nov 2020 17:55:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6501221EB for ; Fri, 13 Nov 2020 17:55:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FE1+mMH0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6501221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 309886B009E; Fri, 13 Nov 2020 12:55:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C20D6B00A0; Fri, 13 Nov 2020 12:55:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AA196B00A1; Fri, 13 Nov 2020 12:55:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id DD2086B009E for ; Fri, 13 Nov 2020 12:55:17 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 85E1F8249980 for ; Fri, 13 Nov 2020 17:55:17 +0000 (UTC) X-FDA: 77480146674.16.eye62_5f14f7227311 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 6463F100E6917 for ; Fri, 13 Nov 2020 17:55:17 +0000 (UTC) X-HE-Tag: eye62_5f14f7227311 X-Filterd-Recvd-Size: 5732 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 17:55:16 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id c17so10829100wrc.11 for ; Fri, 13 Nov 2020 09:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=FE1+mMH0UYMQRcQQs7KpXFA4j/4+C7+LWdthCcraI4GjvHoVSq5egSXJ6dIWT52Tb/ VZbrsdVzeK7nkCczjAWhm1H4Rs3HIouuOPKj119ajegykHfj7CUteydCStxrj5x0hlnH XBDM6HOeJ8jwSjZEujY/i83583kf7woW21nDuLJmd6Epr58dbZeqVHYAkTmaAMgrJ/RM eBW4eIJ91niVQFmmNXKF7hfKI9w+QGuPppUGZ1Yr7Atxmji3ZgrN0xT7N1i1zsqbi6FY mQEzwScKiSGV5hZDxk0wTMrdRZg9UyCKaj0ThbUezV0lN9IMsEX9k9DCpqaAQlpiY3Vr 13ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/+PMzrqEXwIpHSYqiZIonnkK0eqVZnv5ws8C/JpM2Ro=; b=SHxSB0P83MLmZillle8mTK+7HV95beKHvb0LDGVEN+ddDPGk9MpKV3wFhvkPEtp48B bBYBwQPqj05/ofl8AFFvz+CojzlbhF6YuAb9b6I6Mm790OX7N+yl+UCTpL+nPbfHFuxN 5+3u38Q52RZXluKeRkPY2odhcA35HtVWmUKbcTuGHE19rFaZGxYkWUxFYJhbtTrJ0hJO QiurER9Tajv8CQf1yHGIMAtcb2Esud8l8lFzhFcWxCl6XEQmq49b2sKI8XKGE2/BPSVZ r4eb+h7Rxe6+QUdfkTTDKLzR6CGfx5HtXiJ8FzmwVoYMXhtnHBdD52bLUEt3nNix/azV Z9EA== X-Gm-Message-State: AOAM531gz6ehjy1xJVcoJHtGhf3SGwPJG3pmHhlrC4YtcmQTSjgox3nv Efy2TIja9HemPqYolG1rur1exQ== X-Google-Smtp-Source: ABdhPJy2CWSCtgMYhxtWZD2Bm08bwkJMMl3ksYfanoTA+WX4VeGO+SoCLrnlO7CMn2PoetaesDufLw== X-Received: by 2002:adf:e607:: with SMTP id p7mr4796819wrm.93.1605290115315; Fri, 13 Nov 2020 09:55:15 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id c185sm11477158wma.44.2020.11.13.09.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 09:55:14 -0800 (PST) Date: Fri, 13 Nov 2020 18:55:08 +0100 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Evgenii Stepanov , Andrey Ryabinin , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/20] kasan: add and integrate kasan boot parameters Message-ID: <20201113175508.GB3175464@elver.google.com> References: <20201113175254.GA3175464@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113175254.GA3175464@elver.google.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 13, 2020 at 06:52PM +0100, Marco Elver wrote: > On Tue, Nov 10, 2020 at 11:20PM +0100, 'Andrey Konovalov' via kasan-dev wrote: > [...] > > +/* kasan.mode=off/prod/full */ > > +static int __init early_kasan_mode(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_mode = KASAN_ARG_MODE_OFF; > > + else if (!strcmp(arg, "prod")) > > + kasan_arg_mode = KASAN_ARG_MODE_PROD; > > + else if (!strcmp(arg, "full")) > > + kasan_arg_mode = KASAN_ARG_MODE_FULL; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.mode", early_kasan_mode); > > + > > +/* kasan.stack=off/on */ > > +static int __init early_kasan_flag_stacktrace(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "off")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_OFF; > > + else if (!strcmp(arg, "on")) > > + kasan_arg_stacktrace = KASAN_ARG_STACKTRACE_ON; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > > +early_param("kasan.stacktrace", early_kasan_flag_stacktrace); > > + > > +/* kasan.fault=report/panic */ > > +static int __init early_kasan_fault(char *arg) > > +{ > > + if (!arg) > > + return -EINVAL; > > + > > + if (!strcmp(arg, "report")) > > + kasan_arg_fault = KASAN_ARG_FAULT_REPORT; > > + else if (!strcmp(arg, "panic")) > > + kasan_arg_fault = KASAN_ARG_FAULT_PANIC; > > + else > > + return -EINVAL; > > + > > + return 0; > > +} > [...] > > The above could be simplified, see suggestion below. > > Thanks, > -- Marco > > ------ >8 ------ > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index c91f2c06ecb5..71fc481ad21d 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -64,10 +64,8 @@ static int __init early_kasan_mode(char *arg) > kasan_arg_mode = KASAN_ARG_MODE_PROD; > else if (!strcmp(arg, "full")) > kasan_arg_mode = KASAN_ARG_MODE_FULL; > - else > - return -EINVAL; > > - return 0; > + return -EINVAL; Ah that clearly doesn't work. Hmm, never mind this suggestion, sorry. Thanks, -- Marco